Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 6 May 2020 08:21:39 -0700
From:   Stephen Hemminger <stephen@networkplumber.org>
To:     Po Liu <Po.Liu@nxp.com>
Cc:     dsahern@gmail.com, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, vinicius.gomes@intel.com,
        davem@davemloft.net, vlad@buslov.dev, claudiu.manoil@nxp.com,
        vladimir.oltean@nxp.com, alexandru.marginean@nxp.com
Subject: Re: [v4,iproute2-next 1/2] iproute2-next:tc:action: add a gate
 control action
Message-ID: <20200506082139.58dff261@hermes.lan>
In-Reply-To: <20200506084020.18106-1-Po.Liu@nxp.com>
References: <20200503063251.10915-2-Po.Liu@nxp.com>
        <20200506084020.18106-1-Po.Liu@nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed,  6 May 2020 16:40:19 +0800
Po Liu <Po.Liu@nxp.com> wrote:

> 		} else if (matches(*argv, "base-time") == 0) {
> +			NEXT_ARG();
> +			if (get_u64(&base_time, *argv, 10)) {
> +				invalidarg = "base-time";
> +				goto err_arg;
> +			}
> +		} else if (matches(*argv, "cycle-time") == 0) {
> +			NEXT_ARG();
> +			if (get_u64(&cycle_time, *argv, 10)) {
> +				invalidarg = "cycle-time";
> +				goto err_arg;
> +			}
> +		} else if (matches(*argv, "cycle-time-ext") == 0) {
> +			NEXT_ARG();
> +			if (get_u64(&cycle_time_ext, *argv, 10)) {
> +				invalidarg = "cycle-time-ext";
> +				goto err_arg;
> +			}

Could all these time values use existing TC helper routines?
See get_time().  The way you have it makes sense for hardware
but stands out versus the rest of tc.

It maybe that the kernel UAPI is wrong, and should be using same
time units as rest of tc. Forgot to review that part of the patch.