Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp51851ybj; Wed, 6 May 2020 11:20:42 -0700 (PDT) X-Google-Smtp-Source: APiQypLDelB57Rz8UDrpcYYY+s+UQ2Daf47vRcsR332vbTGPSWkPlssm/zhjxIhe+pSSHHCr/WQ3 X-Received: by 2002:a17:906:8611:: with SMTP id o17mr8457702ejx.221.1588789242462; Wed, 06 May 2020 11:20:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588789242; cv=none; d=google.com; s=arc-20160816; b=nmiTSVRDKIn1UWON31JAOkYlneY1+yDGHSgROCyxXBg/X/c7SD9E2IPqAKgJN0AJ7z Yj18Kha6nTXX3PTMqs5jBLf7vzTEPrBjIZK6ORZp3nxTsx9Qy2FNHcgUxyJRAiHRj5Fu HYguqGHpJTico75HZ1MLnXyoiq0I3zPX7Dwz5RAMAzMD0DN3lqmD89tzh4zX+o0Kjrlp RngRgEUVTK9DEHcGh0mPjUGQ35ENgIcvjKT1ZNv3+qIxUHnUybKL7w8+tUxcYsTL/xAI qdgGR3iubT6+6XC4RZsUKWUBtTtrqhbT/7r1ElQel9SjLCHwKfvx4v+ORg0Ic18qBh2L iluA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=/AJAJr7B3QKjZ0nQt0tJ7+Ma9Ntv3JDslAMn5XoI8kM=; b=dEMvFNVKdwzBb1O9+FjKjGvmVTTeMLkDg2rhOPl6anfKqj7jKQpscGcdhJ3mWbOhu7 Zhz89N6TTwesug/FJXqtQef0SfXJ/+02sJWLi/0Rg+pMwqOypba9NWVTWYfKx4W0cBxS IPzvRC/Rf3cwt23ykRs5OwqvktlcPOOFifm3cH5xJqT4ILFFayUXC95k+/qeiNcu3vLA 0ywtuzJhf17UaBxyrORLPmTyTGEkj5v1+l7UGxomSRgKFc5CuMe+0kCTI98Adf/xwUsF O2ZBNF7t3vH/1TkX1NchGCrNYj4PtdclR43l0Hj+Z916Tekq7gMJMTPfICEOwzydcq44 FkKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=TawhGh0V; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y7si1486799edv.512.2020.05.06.11.20.18; Wed, 06 May 2020 11:20:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=TawhGh0V; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730452AbgEFSQd (ORCPT + 99 others); Wed, 6 May 2020 14:16:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730084AbgEFSQc (ORCPT ); Wed, 6 May 2020 14:16:32 -0400 Received: from merlin.infradead.org (unknown [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 992A7C061A0F for ; Wed, 6 May 2020 11:16:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=/AJAJr7B3QKjZ0nQt0tJ7+Ma9Ntv3JDslAMn5XoI8kM=; b=TawhGh0VxeA9YJluTQSDJtyYM8 xX3NRY2qP1wiFVkW/WasVhIt/ypfsL11du7zkEQ+RA2FhGVBrwBtxLkggXwjz3tA/1TjKZDAdIMJu Krqk914HSWxBIJ+ck3r+C1TDilogeNCgKYF4Q+5HH59ymNICFzHEz95Y5Ecr4Pk0bYzFiCrRHxuM0 uD59StN1Hw8sTvN/lDMdfidV2HSphlBuXJedhyU7ohyc64JJhZewP3dOAaAuGe2mDFQbgs1Uyz0P3 h3s5Kk5vBVM3RG7MvYtgd1naiwktFag8uMl8Ps1MfR9Rt3FWTaNEsrqehvHZIbspESgynfBV6gYIV kVILN1BQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWOaS-0000vt-I2; Wed, 06 May 2020 18:16:04 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id B3ADB300739; Wed, 6 May 2020 20:16:02 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 9ADCA29DE2DED; Wed, 6 May 2020 20:16:02 +0200 (CEST) Date: Wed, 6 May 2020 20:16:02 +0200 From: Peter Zijlstra To: Josh Poimboeuf Cc: x86@kernel.org, linux-kernel@vger.kernel.org, rostedt@goodmis.org, mhiramat@kernel.org, bristot@redhat.com, jbaron@akamai.com, torvalds@linux-foundation.org, tglx@linutronix.de, mingo@kernel.org, namit@vmware.com, hpa@zytor.com, luto@kernel.org, ard.biesheuvel@linaro.org, pbonzini@redhat.com, mathieu.desnoyers@efficios.com Subject: Re: [PATCH v4 14/18] static_call: Add static_cond_call() Message-ID: <20200506181602.GZ3762@hirez.programming.kicks-ass.net> References: <20200501202849.647891881@infradead.org> <20200501202944.593400184@infradead.org> <20200506172455.ho5em2mtzn7qqfjl@treble> <20200506175852.GW3762@hirez.programming.kicks-ass.net> <20200506180924.tdn3zc7a3yte7kvv@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200506180924.tdn3zc7a3yte7kvv@treble> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 06, 2020 at 01:09:24PM -0500, Josh Poimboeuf wrote: > #define __ARCH_DEFINE_STATIC_CALL_TRAMP(name, insns) \ > asm(".pushsection .static_call.text, \"ax\" \n" \ > ".align 4 \n" \ > ".globl " STATIC_CALL_TRAMP_STR(name) " \n" \ > STATIC_CALL_TRAMP_STR(name) ": \n" \ > insns " \n" \ > ".type " STATIC_CALL_TRAMP_STR(name) ", @function \n" \ > ".size " STATIC_CALL_TRAMP_STR(name) ", . - " STATIC_CALL_TRAMP_STR(name) " \n" \ > ".popsection \n") > > #define ARCH_DEFINE_STATIC_CALL_TRAMP(name, func) \ > __ARCH_DEFINE_STATIC_CALL_TRAMP(name, "jmp.d32 " # func) Note that this one is now: .byte 0xe9; .long #func - (. + 4); due to clang not actually understanding jmp.d32 :-( > #define ARCH_DEFINE_STATIC_CALL_RETTRAMP(name, func) \ > __ARCH_DEFINE_STATIC_CALL_TRAMP(name, "ret; nop; nop; nop; nop") > > I like it. Makes it easy to see the differences between the tramps. OK, ok.. changed :-)