Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp96898ybj; Wed, 6 May 2020 12:25:50 -0700 (PDT) X-Google-Smtp-Source: APiQypJ3RPtPsKYAj7sTKHtPRULzsR4BNPfLVyN7nmPnFYMlG6mLvJfofip9USGcwZHKymZdwaBf X-Received: by 2002:a17:906:300a:: with SMTP id 10mr8947645ejz.139.1588793150645; Wed, 06 May 2020 12:25:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588793150; cv=none; d=google.com; s=arc-20160816; b=m+jqVhQskew7DKSupTIplHWIVdUYhuqNZ6EMGkzGX7fgwvHOG9f1YzMxVx6u2Ml5b7 JplvD9LEq9fR/j5kp6GVUO146cfSoM2hwBP+DWqfrlIt8gQnb4yYayp+Ystw8G3jhxLY tCo4T+c9l59dPkg5coC648lA32GFiSAjO8RKcJ/3osFMdackKfE75f5rFp/v2+MTTdGK 4TFfOmAUxqU8hO7n0x/jrPC8lI+9WuvdWRB7pmsIUYSmxMqnSTDJKUfQBuB398bwkp5K H9gAFW+S1OuUgWOUfTUK/7kDGews/yO1y2uddzVddSCyIjn/ggo7dtdVmvgKYcumjyIw xwCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=uOcIBwBnUauldiWLndzVmwzZBKURfhS3mRHhqqKZPOs=; b=ZKdyfKFIn0miUQpsyWZI5J7EFZ2FRT7s7o0G4qyb2SiBbVaPY2bfxrPfwFFwuBNQzg J1sqADlcoM03sJKKL3g+EImbaFDMsiPZbYxID7R4bDFtvLtaCvDT7sYypuCJv7RQJ+g8 goKvrHCeQdMZVpTdpyReMFXnFx1Q/9sYddGBlLJkiG6Xf08HWPvgfflD8AHehkJ5JYLY EOM9emOwDDjMDG7A4swkeBjZ9a1xVRpgMlhKEops/JJBF+YPi08U8NUCRshnSCC3bwhs 39tphl089EC5firTB7M/7d1LVSjS5E5czZ9uz4zpzOnrNvYNN1c6PONx6k4ooxneilFM fPeA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Ei0k57VL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v28si1694528edb.497.2020.05.06.12.25.27; Wed, 06 May 2020 12:25:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Ei0k57VL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730411AbgEFP25 (ORCPT + 99 others); Wed, 6 May 2020 11:28:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729639AbgEFPZx (ORCPT ); Wed, 6 May 2020 11:25:53 -0400 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2A54C061A0F; Wed, 6 May 2020 08:25:53 -0700 (PDT) Received: by mail-pj1-x1043.google.com with SMTP id e6so1032110pjt.4; Wed, 06 May 2020 08:25:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uOcIBwBnUauldiWLndzVmwzZBKURfhS3mRHhqqKZPOs=; b=Ei0k57VLk7N4E1tLvvZ/W7MHkb57jABqquZr5M0n8FHzv94us4sIsfRRTTjtwzJC3C XZpXtiP/3hYpjwUSQyzP7ItePPVEhLJEFdi942IWT4mUMySrX+xg2Hl5R9txLGwkXqQm /r+OvYPRXzuCALy7Rphp6MDbF2lYVmLEmiFiC7aLT2jhENPb2YSyi7A0hpWmZLMVDEBg zf2ZdcRPeDbZ8JhtAI2YC8GjaVL9R45v/JCP1frBXL9Yz56FitLq8IqFvQiQ7HvhtubW F9FxRsMODSAsct79wjZKuI+Nhp2PyaJLU9aXV8lhXbrBJEt+LVl1v8+QZA7HgV6laDK0 bYqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uOcIBwBnUauldiWLndzVmwzZBKURfhS3mRHhqqKZPOs=; b=tS8b8qoG8xYBQXDaz/he1CcsuBn+uZE9qz9f8+GvYPothiZm/m0KOpkP2RJ4Bt8ypE heEl4oJ4L9NEIVZERAkF3M/G7F2/gkiiK5fWiThGwuoPjQYsnCNMh9xtuf/mN1SS0lig n79Y01NSCaZzkp9JkyhSuZFXX3Cb0lapUM81kXGk6ZSwmRGS0q7ezCHFGXlmRV23Xbf0 rysQr5YgHrJDq8qTyUsCrnly/xjRWGWDFa+7Uq7dztGs3fMZ0Kq1J2VEdQFYIEcqNskk +LPy6oz8gBsVX0p25o0XYMJjFZ5/wmVtiQ9iHV9eWg42tPi9DCyZKGitzO4WU9B7ATD+ tDdA== X-Gm-Message-State: AGi0PuaXbp99uPURkuHY25NYl4CL+7VlCnvLGOph7y4vAkB2Qh3oTcBC y+cPM4SNHLBLo+rtCSYiqMPC/a4jpTQlteAHiro= X-Received: by 2002:a17:90a:fa81:: with SMTP id cu1mr10273546pjb.25.1588778753308; Wed, 06 May 2020 08:25:53 -0700 (PDT) MIME-Version: 1.0 References: <20200325231422.1502366-1-heiko@sntech.de> <20200325231422.1502366-8-heiko@sntech.de> In-Reply-To: <20200325231422.1502366-8-heiko@sntech.de> From: Andy Shevchenko Date: Wed, 6 May 2020 18:25:45 +0300 Message-ID: Subject: Re: [PATCH v2 7/7] serial: 8250_dw: add em485 support To: Heiko Stuebner Cc: Greg Kroah-Hartman , Jiri Slaby , Andy Shevchenko , "Matwey V. Kornilov" , "open list:SERIAL DRIVERS" , Linux Kernel Mailing List , Lukas Wunner , christoph.muellner@theobroma-systems.com, Giulio Benetti , Heiko Stuebner Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 26, 2020 at 1:17 AM Heiko Stuebner wrote: If it's not covered by either yours or Lukas' series, perhaps worth to address as well. .../8250_port.c:1427: warning: Function parameter or member 'p ' not described in 'serial8250_em485_stop_tx' .../8250_port.c:1427: warning: Excess function parameter 'up' description in 'serial8250_em485_stop_tx' -- With Best Regards, Andy Shevchenko