Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp189151ybj; Wed, 6 May 2020 14:53:51 -0700 (PDT) X-Google-Smtp-Source: APiQypLZYh4VXmj8N+/lqHWZO8m99Rc1DeNbp+iGNecHLQOlkwAX6E6cfyh+1LsuYQTykZBpdN8L X-Received: by 2002:aa7:d0d8:: with SMTP id u24mr9518655edo.138.1588802031823; Wed, 06 May 2020 14:53:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588802031; cv=none; d=google.com; s=arc-20160816; b=j71wxw1cMP5wg0V2lqLljCOTwNA/wtktYd8cAXe8/okgUX9lwTExr6K1Gk3QovDr/m c62HvIJXCGnHJy2a6IS2o1o1pkCpGYYNbzeNA8llEPuDcPcPMrNDxEyGDdPtFZ1WWErI 0xfnBwV9fyBl9nuPYdvOp7sblN4nVVauEYjPxl4hV1LcOdk/q5NRIUQQqIxgAmpEnGnq Kaprj+ecajp5rClDqmSETGjFNU5FIbTgMqdf5GMhBLLkOIVPv52DNbF5EwYU1LPn4njJ W63iIq6PsGNEGUonrrtn9jiueKEUgEs8tSXBvxScGSuKInvgmefQ1BdLT+EzTa/1ZDDr Y0Pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:ironport-sdr:ironport-sdr; bh=uSNh6b4/2fT4JY8mWb6acTWANTP5km5pzNtaK2WFrds=; b=boeyDoTMsik4FkXw/P4r6p37jQIKbV9ZPs5ky3lDaivn79Z+3ovSuxlGU4ew/A+JdJ apGjaq0whCqwnqLOk/dk1hC4wrOkmr66MAd6hJ6YFZe9GpRiixTAkV7Yv5kBUmfZkoDS ToElGtENDIOcte45nZCBYbSWYHil1r0I//GM29b7QF8p3VemR2XDZdfPIQdMzLiHgAMi zlmVGlZpSlSZ7H2suYcG0RZfp6AOUssK5R7BgWrQ6cC/9cJa2chp4GKJxXbULyWxZrX9 kud1nAJKc9vAJy9vpuCDOIkczMA0eYbqRGki88tScCc7XQUXeOxw1QEa0wNdFBn7JZag db9w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c7si2078534ejx.28.2020.05.06.14.53.28; Wed, 06 May 2020 14:53:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730112AbgEFVuu (ORCPT + 99 others); Wed, 6 May 2020 17:50:50 -0400 Received: from mga07.intel.com ([134.134.136.100]:37627 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728888AbgEFVuu (ORCPT ); Wed, 6 May 2020 17:50:50 -0400 IronPort-SDR: y3MzUdw3dkY54h0YwHTpUJomQUweU4DP0C14xEAFPSRk5SbEG0CHSHQDrzfRuN3ybDAr8XEokQ hnRQ2pqHS7bA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2020 14:50:49 -0700 IronPort-SDR: 5G8XdY4tOiPdm5joHaumsRQOl1rwSd60LdKvY92emy6QysvcKS/4UQOijPUKbKzaZgoKC1GklO WmCLCGbaYPQg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,360,1583222400"; d="scan'208";a="249902291" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.152]) by fmsmga007.fm.intel.com with ESMTP; 06 May 2020 14:50:48 -0700 Date: Wed, 6 May 2020 14:50:48 -0700 From: Sean Christopherson To: Jarkko Sakkinen Cc: linux-kernel@vger.kernel.org, x86@kernel.org, linux-sgx@vger.kernel.org, akpm@linux-foundation.org, dave.hansen@intel.com, nhorman@redhat.com, npmccallum@redhat.com, haitao.huang@intel.com, andriy.shevchenko@linux.intel.com, tglx@linutronix.de, kai.svahn@intel.com, bp@alien8.de, josh@joshtriplett.org, luto@kernel.org, kai.huang@intel.com, rientjes@google.com, cedric.xing@intel.com, puiterwijk@redhat.com Subject: Re: [PATCH v29 14/20] x86/sgx: ptrace() support for the SGX driver Message-ID: <20200506215048.GJ3329@linux.intel.com> References: <20200421215316.56503-1-jarkko.sakkinen@linux.intel.com> <20200421215316.56503-15-jarkko.sakkinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200421215316.56503-15-jarkko.sakkinen@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 22, 2020 at 12:53:10AM +0300, Jarkko Sakkinen wrote: > Add VMA callbacks for ptrace() that can be used with debug enclaves. > With debug enclaves data can be read and write the memory word at a time > by using ENCLS(EDBGRD) and ENCLS(EDBGWR) leaf instructions. > > Signed-off-by: Jarkko Sakkinen > --- > arch/x86/kernel/cpu/sgx/encl.c | 88 ++++++++++++++++++++++++++++++++++ > 1 file changed, 88 insertions(+) > > diff --git a/arch/x86/kernel/cpu/sgx/encl.c b/arch/x86/kernel/cpu/sgx/encl.c > index fe7dbca40bb4..0c5ea2968868 100644 > --- a/arch/x86/kernel/cpu/sgx/encl.c > +++ b/arch/x86/kernel/cpu/sgx/encl.c > @@ -326,6 +326,7 @@ int sgx_encl_may_map(struct sgx_encl *encl, unsigned long start, > return 0; > } > > + Unnecessary whitespace change. > static int sgx_vma_mprotect(struct vm_area_struct *vma, unsigned long start, > unsigned long end, unsigned long prot) > {