To: "Bryan O'Sullivan" <bos@pathscale.com>
Cc: rolandd@cisco.com, gregkh@suse.de, akpm@osdl.org, davem@davemloft.net,
       linux-kernel@vger.kernel.org, openib-general@openib.org
Subject: Re: [PATCH 4 of 20] ipath - support for HyperTransport devices
References: <0b1b4f4c093e2db6153e.1141922817@localhost.localdomain>
From: Roland Dreier <rdreier@cisco.com>
Date: Thu, 09 Mar 2006 15:01:49 -0800
In-Reply-To: <0b1b4f4c093e2db6153e.1141922817@localhost.localdomain> (Bryan O'Sullivan's message of "Thu,  9 Mar 2006 08:46:57 -0800")
Message-ID: <ada3bhrgr36.fsf@cisco.com>
User-Agent: Gnus/5.1007 (Gnus v5.10.7) XEmacs/21.4.18 (linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1265
Lines: 36

 > +		/* the HT capability type byte is 3 bytes after the
 > +		 * capability byte.
 > +		 */
 > +		if (pci_read_config_byte(pdev, pos + 3, &cap_type)) {
 > +			dev_info(&pdev->dev, "Couldn't read config "
 > +				 "command @ %d\n", pos);
 > +			continue;
 > +		}
 > +		if (!(cap_type & 0xE0)) {

It seems like all these hypertransport magic constants should be in a
general .h somewhere.  I'm not sure if it makes sense to put them in
<linux/pci.h>, or start a <linux/hypertransport.h>.

 > +				else if (linkctrl & (0xf << 8)) {
 > +					ipath_cdbg(
 > +						VERBOSE,
 > +						"Clear linkctrl%d CRC "
 > +						"Error bits %x\n", i,
 > +						linkctrl & (0xf << 8));
 > +					/*
 > +					 * now write them back to clear
 > +					 * the error.
 > +					 */
 > +					pci_write_config_byte(
 > +						pdev, link_off,
 > +						linkctrl & (0xf << 8));

The logic here is pretty hard to follow, and you're getting squeezed
pretty hard by indenting 5 tabs stops.  Can ipath_setup_ht_config() be
split up into subfunctions?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/