Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 6 May 2020 17:36:39 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Will Deacon <will@kernel.org>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>, x86@kernel.org,
        "Paul E. McKenney" <paulmck@kernel.org>,
        Andy Lutomirski <luto@kernel.org>,
        Alexandre Chartre <alexandre.chartre@oracle.com>,
        Frederic Weisbecker <frederic@kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <sean.j.christopherson@intel.com>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Petr Mladek <pmladek@suse.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Joel Fernandes <joel@joelfernandes.org>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Juergen Gross <jgross@suse.com>,
        Brian Gerst <brgerst@gmail.com>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        Josh Poimboeuf <jpoimboe@redhat.com>
Subject: Re: [patch V4 part 1 06/36] compiler: Simple READ/WRITE_ONCE()
 implementations
Message-ID: <20200506153639.GD5281@hirez.programming.kicks-ass.net>
References: <20200505131602.633487962@linutronix.de>
 <20200505134058.651504242@linutronix.de>
 <20200506133333.GK8043@willie-the-truck>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200506133333.GK8043@willie-the-truck>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, May 06, 2020 at 02:33:33PM +0100, Will Deacon wrote:
> On Tue, May 05, 2020 at 03:16:08PM +0200, Thomas Gleixner wrote:
> > READ/WRITE_ONCE_NOCHECK() is required for atomics in code which cannot be
> > instrumented like the x86 int3 text poke code. As READ/WRITE_ONCE() is
> > undergoing a rewrite, provide __{READ,WRITE}_ONCE_SCALAR().
> > 
> > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> > ---
> >  include/linux/compiler.h |    8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > --- a/include/linux/compiler.h
> > +++ b/include/linux/compiler.h
> > @@ -313,6 +313,14 @@ unsigned long read_word_at_a_time(const
> >  	__u.__val;					\
> >  })
> >  
> > +#define __READ_ONCE_SCALAR(x)				\
> > +	(*(const volatile typeof(x) *)&(x))
> > +
> > +#define __WRITE_ONCE_SCALAR(x, val)			\
> > +do {							\
> > +	*(volatile typeof(x) *)&(x) = val;		\
> > +} while (0)
> 
> FWIW, these end up being called __READ_ONCE() and __WRITE_ONCE() after
> the rewrite; the *_SCALAR() variants will call into kcsan_check_atomic_*().
> 
> If you go with that naming now, then any later conflict should fall out in
> the wash.

Ah excellent, clearly we had slightly different resoltions vs kcsan.
Thanks!