Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp252705ybj;
        Wed, 6 May 2020 16:42:40 -0700 (PDT)
X-Google-Smtp-Source: APiQypJSYad4e/1GrGV9DozaRGOu/3TTy+Qd4heE+utoqSai+ULkws2gOTiDDskDDO4bSumkGmK8
X-Received: by 2002:aa7:d542:: with SMTP id u2mr9680043edr.234.1588808560034;
        Wed, 06 May 2020 16:42:40 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1588808560; cv=none;
        d=google.com; s=arc-20160816;
        b=CclKBV3pbzfSGtZ6sPRPPzz3FnoCrWriGtQ3GXXVrRh6fY1QOVUxnvBpPzcNnQxCXD
         jPx8giHxCJl/tiqmy4s77oUgRgYSIiSqJSxoCkxs+EGlWDNRqPWJ7w5d84XFa0SxrY0E
         9Mi1MnSlarkovIGuFvzqN2L/haVpJYhMp5wzqEj7NNIV3FikovlVj6++C8YJKVez9xZ5
         qvlxUonAz2o7gRQABpOv3iLV8Q5kowZx0xJ6q1Ls8RVlr69GvoC/hzPkBRSJgeP6x+YA
         J+r4+96DFnPp0hJNKb7RqJPixWIJWRFM/Tjcj3SpJrN2Nwuq8S22RJZwl2CdUlor42kr
         jiHg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=LtT22bX+wNqubqIl2+xa/Itj0H1jSo8h6hPurEITx04=;
        b=XiSUnR9Uj+wtdL5JhQ4jQRVM8lK/etKCJkI3z62+JPkLbcbA5t18Ef7+7b9M9VtR+P
         NUJYN8RbtMSO5ZCIx1uOaE8DLF4cbl3HaYQ6yGsUa/nWFkDhXEeVLf9immlvaD/Nl2Vu
         ng5llfi6LbjE4reGsDmJ3fkQXsZ36fljCzum3bScZykUOtbrEkerKwXYGGq987w++TY6
         DleiQac2n+W+aDfxUYOwVUKwv7QP5TzefwqvmBO9/5M3HK142mazwxvPuIrxV3cNq1Pw
         qr1/IsIfNoZx5Vnn8uFNR0U7I8VW2aOo9BeCqjTN0EzjnlEALzhh1U3f1Jaq6ncpOhby
         laEQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=B8Rz9G6A;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id p11si2084981edm.108.2020.05.06.16.42.15;
        Wed, 06 May 2020 16:42:40 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=B8Rz9G6A;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728741AbgEFTXd (ORCPT <rfc822;lans.zhang2008@gmail.com>
        + 99 others); Wed, 6 May 2020 15:23:33 -0400
Received: from mail.kernel.org ([198.145.29.99]:47194 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727110AbgEFTXc (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 6 May 2020 15:23:32 -0400
Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.4])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id E4A7720870;
        Wed,  6 May 2020 19:23:31 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1588793012;
        bh=HT+hCyDDnp3A+m/VSXJaYiGdp3Y+AgCoLB8fV/ljk2w=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=B8Rz9G6AEtJsXLDcU5SN0axbD1UiixoRkMRXpd+reYcH1nNAqljAPm1kqXl6a62Fx
         OfeHQq8+PvUnHXBkkYxLMR98TSp6iVizYFtDu1jSTWBCot46PEfXlbDMCwIGKaB1gi
         IpcHIfbJG1bhaZlyPlunRqaMIf7V2DyCO+3weANQ=
Date:   Wed, 6 May 2020 12:23:29 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Leon Romanovsky <leon@leon.nu>
Cc:     Bartosz Golaszewski <brgl@bgdev.pl>,
        Rob Herring <robh+dt@kernel.org>,
        "David S . Miller" <davem@davemloft.net>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Felix Fietkau <nbd@openwrt.org>,
        John Crispin <john@phrozen.org>,
        Sean Wang <sean.wang@mediatek.com>,
        Mark Lee <Mark-MC.Lee@mediatek.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Fabien Parent <fparent@baylibre.com>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-netdev <netdev@vger.kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH 06/11] net: ethernet: mtk-eth-mac: new driver
Message-ID: <20200506122329.0a6b2ac4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <CALq1K=Lu0hv9UCgxgrwCVoOe9L7A4sgBEM=RW2d9JkizHmdBPQ@mail.gmail.com>
References: <20200505140231.16600-1-brgl@bgdev.pl>
        <20200505140231.16600-7-brgl@bgdev.pl>
        <CALq1K=Lu0hv9UCgxgrwCVoOe9L7A4sgBEM=RW2d9JkizHmdBPQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 6 May 2020 22:16:11 +0300 Leon Romanovsky wrote:
> > +#define MTK_MAC_DRVNAME                                "mtk_eth_mac"
> > +#define MTK_MAC_VERSION                                "1.0"  
> 
> Please don't add driver version to new driver.

It has already been pointed out. Please trim your replies.