Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp261106ybj; Wed, 6 May 2020 16:59:38 -0700 (PDT) X-Google-Smtp-Source: APiQypL97o7mzdJVJDF+xuJ7UKAAL/dMDdgpeibkiiFA++uHFUGHYc9aCAZB1hlP++aI9dHnoM0Z X-Received: by 2002:a05:6402:1b0b:: with SMTP id by11mr9364633edb.269.1588809578538; Wed, 06 May 2020 16:59:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588809578; cv=none; d=google.com; s=arc-20160816; b=1F/WDegChcRpTXSYID0Hb9LctkS4etu9dk2AU/nfN6Q3/yLeE4T2KMJyimWM2JxRKl Yp0FtwTJG8XVYuU4wt8VfbF69j/4IRyswravg/vWomVgVOjE9uogkBEvqXe/pgOns200 KDZY+hYnnjeLm3ZoBvHO2cf/EAUKvQFB1v9WnXt9oaw3tkQhjSdU0zZWSMLX1X5vJT02 MilZsUgjbUVt0/AoV1mBP4bbIM89N1HK1PWcyXI/6f5lbJYI7dKcHlHof7K5M8ubTG/1 69JMOZuBa0bzbbuz9f5G1o31pTHEcoQYWLnZ8aVVpqloFjmCwM0Vv6cRyxICIVdDWJFQ IZAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=P6y5gTb1cXbMxjbE6qJxYznCDJoIAHag3sL4DIMlEhk=; b=ZV3AyYPr+5iEcaOI2GRxMFVoNT2XGNf9JfD9grHSewQdcaC5qTSylFF+t+trZm/o/C rbo9RCkFLrvP2E1J/NWSnAEaZ1SDdQft0Mdb9Bi1jQK1n/7qnrozGkjV02McL2Xjysdz 6R+yTl+Kbky7F0z7LPu8sDFg1XKzg0e4fQZT3UrNGTzFCaz5iSiv6Yy/moEvrsHrRVSw WIk0Q+sNHyjRFXY8vgs3cHweYtlxri642kTOUAlAm5g+CVsVdKcf4YY0U51LGzfwwOMc gYzVkZ+WSz6I9fFJ+GxxG8Zz3Icjh6/CQnJDEFj3VZBmYbSMeqTl0NxvjNDUTk6w+9WT fnyA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t26si2032548edw.567.2020.05.06.16.59.15; Wed, 06 May 2020 16:59:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729936AbgEFVuU (ORCPT + 99 others); Wed, 6 May 2020 17:50:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1728888AbgEFVuU (ORCPT ); Wed, 6 May 2020 17:50:20 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39E79C061A0F; Wed, 6 May 2020 14:50:20 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id B6B831273C3A6; Wed, 6 May 2020 14:50:16 -0700 (PDT) Date: Wed, 06 May 2020 14:50:15 -0700 (PDT) Message-Id: <20200506.145015.1852712055909777150.davem@davemloft.net> To: antoine.tenart@bootlin.com Cc: sd@queasysnail.net, mstarovoitov@marvell.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: macsec: fix rtnl locking issue From: David Miller In-Reply-To: <20200506135830.587297-1-antoine.tenart@bootlin.com> References: <20200506135830.587297-1-antoine.tenart@bootlin.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 06 May 2020 14:50:17 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Antoine Tenart Date: Wed, 6 May 2020 15:58:30 +0200 > netdev_update_features() must be called with the rtnl lock taken. Not > doing so triggers a warning, as ASSERT_RTNL() is used in > __netdev_update_features(), the first function called by > netdev_update_features(). Fix this. > > Fixes: c850240b6c41 ("net: macsec: report real_dev features when HW offloading is enabled") > Signed-off-by: Antoine Tenart Applied, thank you.