Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH RE-SEND v1] PM / devfreq: Replace strncpy with strscpy
To:     Dmitry Osipenko <digetx@gmail.com>,
        MyungJoo Ham <myungjoo.ham@samsung.com>,
        Kyungmin Park <kyungmin.park@samsung.com>
Cc:     linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
From:   Chanwoo Choi <cw00.choi@samsung.com>
Organization: Samsung Electronics
Message-ID: <41092ded-8bb6-726f-6986-fee62a8a1325@samsung.com>
Date:   Thu, 7 May 2020 09:02:57 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101
        Thunderbird/59.0
MIME-Version: 1.0
In-Reply-To: <09712864-01a5-e2f9-b55f-e822169d30fc@gmail.com>
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <20200227170854.9949-1-digetx@gmail.com>
        <CGME20200417140545epcas1p38cdc6cc5e6059437e611cf7e771d0dbd@epcas1p3.samsung.com>
        <09712864-01a5-e2f9-b55f-e822169d30fc@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Dmitry,

On 4/17/20 11:04 PM, Dmitry Osipenko wrote:
> 27.02.2020 20:08, Dmitry Osipenko пишет:
>> GCC produces this warning when kernel compiled using `make W=1`:
>>
>>   warning: ‘strncpy’ specified bound 16 equals destination size [-Wstringop-truncation]
>>   772 |  strncpy(devfreq->governor_name, governor_name, DEVFREQ_NAME_LEN);
>>
>> The strncpy doesn't take care of NULL-termination of the destination
>> buffer, while the strscpy does.
>>
>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>> ---
>>  drivers/devfreq/devfreq.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
>> index 8494c5f05a73..2011f64bfa3a 100644
>> --- a/drivers/devfreq/devfreq.c
>> +++ b/drivers/devfreq/devfreq.c
>> @@ -769,7 +769,7 @@ struct devfreq *devfreq_add_device(struct device *dev,
>>  	devfreq->dev.release = devfreq_dev_release;
>>  	INIT_LIST_HEAD(&devfreq->node);
>>  	devfreq->profile = profile;
>> -	strncpy(devfreq->governor_name, governor_name, DEVFREQ_NAME_LEN);
>> +	strscpy(devfreq->governor_name, governor_name, DEVFREQ_NAME_LEN);
>>  	devfreq->previous_freq = profile->initial_freq;
>>  	devfreq->last_status.current_frequency = profile->initial_freq;
>>  	devfreq->data = data;
>>
> 
> Hello Chanwoo,
> 
> Do you have any objections to this patch?
> 

I'm sorry for late reply. I applied it for v5.8-rc1.
Thanks.


-- 
Best Regards,
Chanwoo Choi
Samsung Electronics