To: "Bryan O'Sullivan" <bos@pathscale.com>
Cc: rolandd@cisco.com, gregkh@suse.de, akpm@osdl.org, davem@davemloft.net,
       linux-kernel@vger.kernel.org, openib-general@openib.org
Subject: Re: [PATCH 7 of 20] ipath - misc driver support code
References: <2f16f504dd4b98c2ce7c.1141922820@localhost.localdomain>
From: Roland Dreier <rdreier@cisco.com>
Date: Thu, 09 Mar 2006 15:11:09 -0800
In-Reply-To: <2f16f504dd4b98c2ce7c.1141922820@localhost.localdomain> (Bryan O'Sullivan's message of "Thu,  9 Mar 2006 08:47:00 -0800")
Message-ID: <aday7zjfc36.fsf@cisco.com>
User-Agent: Gnus/5.1007 (Gnus v5.10.7) XEmacs/21.4.18 (linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 770
Lines: 22

 > +static unsigned handle_frequent_errors(struct ipath_devdata *dd,
 > +				       ipath_err_t errs, char msg[512],
 > +				       int *noprint)
 > +{
 > +	cycles_t nc;
 > +	static cycles_t nextmsg_time;
 > +	static unsigned nmsgs, supp_msgs;
 > +
 > +	/*
 > +	 * throttle back "fast" messages to no more than 10 per 5 seconds
 > +	 * (1.4-2GHz clock).  This isn't perfect, but it's a reasonable
 > +	 * heuristic. If we get more than 10, give a 5x longer delay
 > +	 */

Could this be replaced by printk_ratelimit()?

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/