Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 06 May 2020 17:22:05 -0700 (PDT)
Message-Id: <20200506.172205.208972233468631933.davem@davemloft.net>
To:     ahabdels@gmail.com
Cc:     kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, kuba@kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        dav.lebrun@gmail.com
Subject: Re: [net] seg6: fix SRH processing to comply with RFC8754
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20200504144211.5613-1-ahabdels@gmail.com>
References: <20200504144211.5613-1-ahabdels@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Ahmed Abdelsalam <ahabdels@gmail.com>
Date: Mon,  4 May 2020 14:42:11 +0000

> The Segment Routing Header (SRH) which defines the SRv6 dataplane is defined
> in RFC8754.
> 
> RFC8754 (section 4.1) defines the SR source node behavior which encapsulates
> packets into an outer IPv6 header and SRH. The SR source node encodes the
> full list of Segments that defines the packet path in the SRH. Then, the
> first segment from list of Segments is copied into the Destination address
> of the outer IPv6 header and the packet is sent to the first hop in its path
> towards the destination.
> 
> If the Segment list has only one segment, the SR source node can omit the SRH
> as he only segment is added in the destination address.
> 
> RFC8754 (section 4.1.1) defines the Reduced SRH, when a source does not
> require the entire SID list to be preserved in the SRH. A reduced SRH does
> not contain the first segment of the related SR Policy (the first segment is
> the one already in the DA of the IPv6 header), and the Last Entry field is
> set to n-2, where n is the number of elements in the SR Policy.
> 
> RFC8754 (section 4.3.1.1) defines the SRH processing and the logic to
> validate the SRH (S09, S10, S11) which works for both reduced and
> non-reduced behaviors.
> 
> This patch updates seg6_validate_srh() to validate the SRH as per RFC8754.
> 
> Signed-off-by: Ahmed Abdelsalam <ahabdels@gmail.com>

Applied, thanks.