Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] printk: Add loglevel for "do not print to consoles".
To:     Joe Perches <joe@perches.com>
Cc:     Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Petr Mladek <pmladek@suse.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        linux-kernel@vger.kernel.org, Dmitry Safonov <dima@arista.com>,
        Michal Hocko <mhocko@suse.com>,
        Yafang Shao <laoar.shao@gmail.com>
References: <20200424024239.63607-1-penguin-kernel@I-love.SAKURA.ne.jp>
 <20200425004609.GE8982@jagdpanzerIV.localdomain>
 <842ff40b-a232-6098-4333-996a3033b30a@i-love.sakura.ne.jp>
 <20200427062117.GC486@jagdpanzerIV.localdomain>
 <4dae86af-1d9a-f5a8-cff6-aa91ec038a79@i-love.sakura.ne.jp>
 <344199f1-639b-ee93-2388-57b0549641f9@i-love.sakura.ne.jp>
 <dfe10cb0359c37dff46c93dfacf909dd33b2593f.camel@perches.com>
From:   Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Message-ID: <0d513c80-8c8e-17b6-5b9c-73c7bca77252@i-love.sakura.ne.jp>
Date:   Thu, 7 May 2020 09:50:21 +0900
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <dfe10cb0359c37dff46c93dfacf909dd33b2593f.camel@perches.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2020/05/07 0:26, Joe Perches wrote:
> On Wed, 2020-05-06 at 18:45 +0900, Tetsuo Handa wrote:
>> On 2020/04/28 20:33, Tetsuo Handa wrote:
>>> On 2020/04/27 15:21, Sergey Senozhatsky wrote:
>>>>> KERN_NO_CONSOLES is for type of messages where "saved for later analysis" is
>>>>> important but "printed for immediate notification" is not important.
>>>>> In other words, KERN_NO_CONSOLES is NOT for dying messages where "printed for
>>>>> immediate notification" is important.
>>>>
>>>> per-console loglevel is a user configurable parameter.
>>>> KERN_NO_CONSOLES is a hard-coded policy.
>>>
>>> But given that whether to use KERN_NO_CONSOLES is configurable via e.g. sysctl,
>>> KERN_NO_CONSOLES will become a user configurable parameter. What's still wrong?
>>>
>>
>> Any problems remaining?
> 
> printk_get_level / printk_skip_level and the various
> uses of %pV using printk_get_level
> 

Excuse me, but what do you mean?

I wish printk() accepts "loglevel" argument detached from "fmt" argument (e.g.

  int printkl(int loglevel, const char *fmt_without_loglevel, ...);
  int vprintkl(int loglevel, const char *fmt_without_loglevel, va_list args);

) so that users of KERN_NO_CONSOLES need not to do like

  if (sysctl_no_console_for_XX)
    printk(KERN_INFO KERN_NO_CONSOLES pr_fmt(fmt) "%s\n", "hello");
  else
    printk(KERN_INFO pr_fmt(fmt) "%s\n", "hello");

or

  printk("%s" pr_fmt(fmt) "%s\n", sysctl_no_console_for_XX ? KERN_INFO KERN_NO_CONSOLES : KERN_INFO, "hello");

in order to conditionally embed KERN_NO_CONSOLES into

  pr_info("%s\n", "hello");

. But this patch is about whether KERN_NO_CONSOLES is acceptable. How to
pass KERN_NO_CONSOLES (if KERN_NO_CONSOLES is acceptable) is a future patch.