Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <63f58a1c334d8d44ddf1788091be9b2232054b03.camel@perches.com>
Subject: Re: [PATCH] printk: Add loglevel for "do not print to consoles".
From:   Joe Perches <joe@perches.com>
To:     Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc:     Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Petr Mladek <pmladek@suse.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        linux-kernel@vger.kernel.org, Dmitry Safonov <dima@arista.com>,
        Michal Hocko <mhocko@suse.com>,
        Yafang Shao <laoar.shao@gmail.com>
Date:   Wed, 06 May 2020 18:02:36 -0700
In-Reply-To: <0d513c80-8c8e-17b6-5b9c-73c7bca77252@i-love.sakura.ne.jp>
References: <20200424024239.63607-1-penguin-kernel@I-love.SAKURA.ne.jp>
         <20200425004609.GE8982@jagdpanzerIV.localdomain>
         <842ff40b-a232-6098-4333-996a3033b30a@i-love.sakura.ne.jp>
         <20200427062117.GC486@jagdpanzerIV.localdomain>
         <4dae86af-1d9a-f5a8-cff6-aa91ec038a79@i-love.sakura.ne.jp>
         <344199f1-639b-ee93-2388-57b0549641f9@i-love.sakura.ne.jp>
         <dfe10cb0359c37dff46c93dfacf909dd33b2593f.camel@perches.com>
         <0d513c80-8c8e-17b6-5b9c-73c7bca77252@i-love.sakura.ne.jp>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.36.1-2 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 2020-05-07 at 09:50 +0900, Tetsuo Handa wrote:
> On 2020/05/07 0:26, Joe Perches wrote:
> > On Wed, 2020-05-06 at 18:45 +0900, Tetsuo Handa wrote:
> > > On 2020/04/28 20:33, Tetsuo Handa wrote:
> > > > On 2020/04/27 15:21, Sergey Senozhatsky wrote:
> > > > > > KERN_NO_CONSOLES is for type of messages where "saved for later analysis" is
> > > > > > important but "printed for immediate notification" is not important.
> > > > > > In other words, KERN_NO_CONSOLES is NOT for dying messages where "printed for
> > > > > > immediate notification" is important.
> > > > > 
> > > > > per-console loglevel is a user configurable parameter.
> > > > > KERN_NO_CONSOLES is a hard-coded policy.
> > > > 
> > > > But given that whether to use KERN_NO_CONSOLES is configurable via e.g. sysctl,
> > > > KERN_NO_CONSOLES will become a user configurable parameter. What's still wrong?
> > > > 
> > > 
> > > Any problems remaining?
> > 
> > printk_get_level / printk_skip_level and the various
> > uses of %pV using printk_get_level
> > 
> 
> Excuse me, but what do you mean?
> 
> I wish printk() accepts "loglevel" argument detached from "fmt" argument (e.g.

I think that's a bad idea as it would expand
_every_ use of printk with another argument
and overall code size would increase for very
little value.

And do look at the code and uses of printk_get_level.