Date: Thu, 09 Mar 2006 15:29:34 -0800 (PST)
Message-Id: <20060309.152934.99760924.davem@davemloft.net>
To: dim@openvz.org
Cc: arnd@arndb.de, akpm@osdl.org, dev@openvz.org,
       netfilter-devel@lists.netfilter.org, rusty@rustcorp.com.au,
       linux-kernel@vger.kernel.org, devel@openvz.org
Subject: Re: {get|set}sockopt compat layer
From: "David S. Miller" <davem@davemloft.net>
In-Reply-To: <200603091324.00362.dim@openvz.org>
References: <200603071707.19138.dim@openvz.org>
	<200603071605.39177.arnd@arndb.de>
	<200603091324.00362.dim@openvz.org>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 962
Lines: 27

From: Dmitry Mishin <dim@openvz.org>
Date: Thu, 9 Mar 2006 13:23:59 +0300

> Hello, Arnd!
> 
> > For the compat_ioctl stuff, we don't have the function pointer inside an
> > #ifdef, the overhead is relatively small since there is only one of these
> > structures per module implementing a protocol, but it avoids having to
> > rebuild everything when changing CONFIG_COMPAT.
> >
> > It's probably not a big issue either way, maybe davem has a stronger
> > opinion on it either way.
> >
> Done.

I think this looks fine but it doesn't apply cleanly to the
current net-2.6.17 tree.

Could you cook up a fresh patch, and send it with a complete
changelog entry and appropriate Signed-off-by: lines?

Thanks a lot Dmitry.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/