To: "Bryan O'Sullivan" <bos@pathscale.com>
Cc: rolandd@cisco.com, gregkh@suse.de, akpm@osdl.org, davem@davemloft.net,
       linux-kernel@vger.kernel.org, openib-general@openib.org
Subject: Re: [PATCH 10 of 20] ipath - support for userspace apps using core driver
References: <71644dd19420ddb07a75.1141922823@localhost.localdomain>
From: Roland Dreier <rdreier@cisco.com>
Date: Thu, 09 Mar 2006 15:33:45 -0800
In-Reply-To: <71644dd19420ddb07a75.1141922823@localhost.localdomain> (Bryan O'Sullivan's message of "Thu,  9 Mar 2006 08:47:03 -0800")
Message-ID: <adazmjzdwh2.fsf@cisco.com>
User-Agent: Gnus/5.1007 (Gnus v5.10.7) XEmacs/21.4.18 (linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 531
Lines: 17

 > +		yield();	/* don't hog the cpu */

You probably don't want to do this -- yield() means "put me at the
tail of the runqueue."  I think cond_resched() is more likely what you
want.

 > +#endif
 > +/* END_NOSHIP_TO_OPENIB */

uhh... and I don't see an #if to match that #endif.

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/