Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp474632ybj; Wed, 6 May 2020 23:45:29 -0700 (PDT) X-Google-Smtp-Source: APiQypJGg6auK1yWinFdnUbUwMzpD/LJ8KNdNGX2cOVmNwKzciskW2v/foKHybJXCp5KylPuGvB2 X-Received: by 2002:aa7:c38a:: with SMTP id k10mr10611129edq.74.1588833929098; Wed, 06 May 2020 23:45:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588833929; cv=none; d=google.com; s=arc-20160816; b=IFI9HsQVrvGAIWPAlreIY0REkAgEqgETKQECsixY8bi7EbHPZn0GOytosQAGYvnRIM jyRaP46fv2UQGzbMConTjw/x5YKFqXKv6EOq9n/8TXJiHJtvcN27APOPpZsW8/AS9vgi f0E3MIhKGjoAC3y6dem9A2RiioZaEPSXKM7SH/MhhuY6T83mWz2GmQtpfQuMjdVWJ+fF wp26imkOlBJRiofarl4WdsqtZoAHiNWD38YHm8qC9ngUOhtQZIObZ2Wp5AY0C1dtgJni lfTQP16SK+M2pdWpPrAv1zuLlAm2q2u3TZXf2uu+56XsUI74Y7XH0sQBdOdpjedH36Hv rRFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=nCp6b2n5e+Qfus3W0eJxZK6OSrAMrAWZwKJOQ17komQ=; b=ZpdIw8KLeHEETbOHs6xZyEe4Y7119zlFSmDi8giGRqoWI3L81PJRh6viEZ++lVPn42 ZV7ymtfSa5XxIeibRcU08t4u9T1CcggJ76YfloZKHTL3sjbhwCJfd0A5+KieC5+FBSOl Hd73zMKmunLuipeDi1Gwo/phwptN/F09eq1fUr5ViTBk0jSEqwzgGf0MY9168PHzUT6y NpW+WWDbElFsPvO9ysaxT26mIahHjIpE44+w28ut2XAkM5svKDtM7nSu79I+n+D/oTzc wgQbSXnEfa/F7UhulMrHJa+WkXvyOZEl0rCHGHZE9pilKjG33+Mo9wz3+Hc9eO+oC4D5 FEww== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dv11si2640229ejb.136.2020.05.06.23.45.06; Wed, 06 May 2020 23:45:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726437AbgEGGm7 (ORCPT + 99 others); Thu, 7 May 2020 02:42:59 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:58664 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725793AbgEGGm4 (ORCPT ); Thu, 7 May 2020 02:42:56 -0400 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 42318413693EF0A90151; Thu, 7 May 2020 14:42:54 +0800 (CST) Received: from linux-lmwb.huawei.com (10.175.103.112) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.487.0; Thu, 7 May 2020 14:42:45 +0800 From: Samuel Zou To: , CC: , , Samuel Zou Subject: [PATCH -next] ALSA: portman2x4: Use bitwise instead of arithmetic operator for flags Date: Thu, 7 May 2020 14:48:55 +0800 Message-ID: <1588834135-14842-1-git-send-email-zou_wei@huawei.com> X-Mailer: git-send-email 2.6.2 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.103.112] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following coccinelle warning: sound/drivers/portman2x4.c:460:34-35: WARNING: sum of probable bitmasks, consider | Reported-by: Hulk Robot Signed-off-by: Samuel Zou --- sound/drivers/portman2x4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/drivers/portman2x4.c b/sound/drivers/portman2x4.c index ecefa7c..38603cb 100644 --- a/sound/drivers/portman2x4.c +++ b/sound/drivers/portman2x4.c @@ -457,7 +457,7 @@ static int portman_probe(struct parport *p) /* Set for RXDATA0 where no damage will be done. */ /* 5 */ - parport_write_control(p, RXDATA0 + STROBE); /* Write Strobe=1 to command reg. */ + parport_write_control(p, RXDATA0 | STROBE); /* Write Strobe=1 to command reg. */ /* 6 */ if ((parport_read_status(p) & ESTB) != ESTB) -- 2.6.2