Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp475928ybj; Wed, 6 May 2020 23:47:47 -0700 (PDT) X-Google-Smtp-Source: APiQypLTYV9PfcDWXJuXRCazp4BQW/8NGL7J81f8GYikh59c6TsQndXFvKtf+EJXpOWOFXiLgCho X-Received: by 2002:a50:ef0b:: with SMTP id m11mr10250958eds.25.1588834067441; Wed, 06 May 2020 23:47:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588834067; cv=none; d=google.com; s=arc-20160816; b=m+Bd/UNB+4WucVymnQW4nakKLl5xYDolZSOKZ0RXAoXmqAYJV5Pj4Nxn6cxue0uzTF CwZed+oXof0SklcZYYw1HO1ByEmEl6yRQ5ib6QPoIJsRrYhx1SUYfuvHsETKSuXCqyxk pFEXGs3eNqXnL2TSypKX5StGYKNA1Z0uN7zhluy7+nsHeGEmJawlyrSKF6lxTPNmuy/g sRQWJe3vycJFVHJR7faylKhF17Fsc0tTDF3yD6nd3K5ZzQ7mKJXe2AcwOgbi34iTP3U5 wZ0QkIsdJNqMa+CejCj6yNlO3cB5Cro2vuMT6dak6Qj0TYvkIz6kmOHk3KA0/gebHDF/ WJEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=xoIogZFvYN/JGOoiPvbmo6dQ6WwoJZegvGSupEyBo9k=; b=G7LDSdfHszZIB7vxyeiTsG2XJGKjagsS77Fds3JiyFRk1sE1Le9Noz/GMlw1UUa5T3 QcbmxuzAR5VlZTJ3IqmV/EWOXWY8RkIPAzrPg2zioLKtQfAQ2SRoFFBNwNrTV07HvRkG N25CQheqDebljkeT5YcIqut9EYJnNyuirH/Gjr6s26HsMhH8TnmsZSpmKG9t00wxIIJi eCdXca5tJjdUM5Q46cypuYLqBizRMnLnYRDVB4P5sJQEFfHagAgKKTUnlAse7rYLbrCK oBgFMnAGkqFb5Yz3wbiW/ECz9VDHCSw4CYj4dM779u6Yg2X7QaXESi4RKKJViTZ5nwqB H22g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=wGxD1c5C; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g13si1546209ejx.342.2020.05.06.23.47.24; Wed, 06 May 2020 23:47:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=wGxD1c5C; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726451AbgEGGps (ORCPT + 99 others); Thu, 7 May 2020 02:45:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:33580 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725905AbgEGGps (ORCPT ); Thu, 7 May 2020 02:45:48 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 951262078C; Thu, 7 May 2020 06:45:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588833948; bh=gm75SLJLcH+JMNI3GZMkQmuSFwAf5JbNY0WtEMPJqUY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wGxD1c5COzsllDgnff5fUZ8KoK3yIZEqdaBc/68jMU7MQ/3AKuqnNp/9aiy6avTnz ncAnmKDGHXjVkeUjq7l6TiVZnQ/pcwenIdSH2vV50XzXppzWQ5SgO4eZPpUtJCNdI+ wrZt4neRbzHokNBrxQy+oB0poCslOEPNme2B527A= Date: Thu, 7 May 2020 08:45:45 +0200 From: Greg KH To: Peter Chen Cc: linux-usb@vger.kernel.org, Bryan O'Donoghue , Peter Chen , Philipp Zabel , linux-kernel@vger.kernel.org, Stephen Boyd Subject: Re: [PATCH 1/1] usb: chipidea: msm: Ensure proper controller reset using role switch API Message-ID: <20200507064545.GB787064@kroah.com> References: <20200507004918.25975-1-peter.chen@kernel.org> <20200507004918.25975-2-peter.chen@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200507004918.25975-2-peter.chen@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 07, 2020 at 08:49:18AM +0800, Peter Chen wrote: > From: Bryan O'Donoghue > > Currently we check to make sure there is no error state on the extcon > handle for VBUS when writing to the HS_PHY_GENCONFIG_2 register. When using > the USB role-switch API we still need to write to this register absent an > extcon handle. > > This patch makes the appropriate update to ensure the write happens if > role-switching is true. > > Fixes: 05559f10ed79 ("usb: chipidea: add role switch class support") > > Cc: Peter Chen No blank line needed, and you can drop your own Cc: in the patch :) I'll edit it by hand... greg k-h