Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932164AbWCIXvi (ORCPT ); Thu, 9 Mar 2006 18:51:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932117AbWCIXvi (ORCPT ); Thu, 9 Mar 2006 18:51:38 -0500 Received: from test-iport-1.cisco.com ([171.71.176.117]:34585 "EHLO test-iport-1.cisco.com") by vger.kernel.org with ESMTP id S1752089AbWCIXvh (ORCPT ); Thu, 9 Mar 2006 18:51:37 -0500 To: "Bryan O'Sullivan" Cc: rolandd@cisco.com, gregkh@suse.de, akpm@osdl.org, davem@davemloft.net, linux-kernel@vger.kernel.org, openib-general@openib.org Subject: Re: [PATCH 9 of 20] ipath - char devices for diagnostics and lightweight subnet management X-Message-Flag: Warning: May contain useful information References: <1141948189.10693.48.camel@serpentine.pathscale.com> From: Roland Dreier Date: Thu, 09 Mar 2006 15:51:34 -0800 In-Reply-To: <1141948189.10693.48.camel@serpentine.pathscale.com> (Bryan O'Sullivan's message of "Thu, 09 Mar 2006 15:49:49 -0800") Message-ID: User-Agent: Gnus/5.1007 (Gnus v5.10.7) XEmacs/21.4.18 (linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-OriginalArrivalTime: 09 Mar 2006 23:51:35.0696 (UTC) FILETIME=[66699100:01C643D4] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 594 Lines: 14 Bryan> Yep, this is a real race, albeit incredibly unlikely. I Bryan> just turned ipath_sma_alive into an atomic_t, and wrapped Bryan> the open/close code in spinlocks. How does making it an atomic_t help? I think you're only going to be using atomic_set() and atomic_read(), and atomic_t doesn't provide anything in that case. - R. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/