Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp509163ybj; Thu, 7 May 2020 00:46:49 -0700 (PDT) X-Google-Smtp-Source: APiQypKgRhwxE5W5QYFTVKPxPYzCiXl7vrQOI/kPbZprFC6Wid7jAg89SilKwo9UKtW8JKPJMaHh X-Received: by 2002:a17:906:404d:: with SMTP id y13mr300496ejj.43.1588837608986; Thu, 07 May 2020 00:46:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588837608; cv=none; d=google.com; s=arc-20160816; b=wMtGfdF5sAK6qOTmRkRWZuygD7Viaf1A3hEMAN9SsJ1jeyeD1sqq2ADvwDK5wHsLTo iptylCglbVmZDeJVTzdhwGV+RFTMyfweBawvPwni6FXFR6q47BL12hMDNfgsbO2VDzVX 55fYo3Rlr/GEOZ/JU8Jfp2S/gBpHUUz0scA9kpwu162nJquVu/Ju+/KaI3yjoebeZQNl Bj1uZEE9JmcZ06Lss5QVlj2wBcAsNQYzeA8gOOU7J8S/NWCeRNbPUqBW10mkQjUZ7+6v RqQcOJFmkhaE3MIpdcR1/6MyXEfq+fgy5k41TCAq1DfoaWvQv7km3FXZD0uebvVlYyyz 005w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=h6uswedAMjpbqecNSfTjRCenxs9Rh0/ygb45+I7a8eQ=; b=UsMAywBLLZS/y2ZJoCif1GynO4DTZ/hQRBBWoUecyFvzkHHsAzy/99sqmXqmn8fBD5 gnyZYAfWqNlZEZmuu/xo9KhHGvyCQube8edcsnxBPlUMCW8GsupUvgksWWWcIeVXJbqH tv9uMqbUFaQMSHBicauwKXEOGOJAOIyA4f+Kk5/NpZ8vj5DAEdwkBXeyJ88+wk4xNR6h FKtV5OyoRPDbzZbEyvF37DMxNZWE42npc2BxCT6TCfE276zTHro+7EaFogpcRoS2mP6K dsoQ6FrkV+Bp0KGvmYwxTAi9E/3a4d5Ct59/SN6bwZtKk25LbSmWDYcLmPqr3q+bHMuM AXrQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="Sp2AEr/7"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l4si2603186edl.169.2020.05.07.00.46.24; Thu, 07 May 2020 00:46:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="Sp2AEr/7"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725947AbgEGHop (ORCPT + 99 others); Thu, 7 May 2020 03:44:45 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:55709 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725809AbgEGHop (ORCPT ); Thu, 7 May 2020 03:44:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588837484; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=h6uswedAMjpbqecNSfTjRCenxs9Rh0/ygb45+I7a8eQ=; b=Sp2AEr/7zkMDFJ98VyFjiU1eZanHM3ofW2zfYraxP2by+mOqPLYnqeJv+JcLNC7Sltkrqs GFnJYrDci+R4J+woT5Jen5/i0E1QQSu41/iP11Mg8D3C7rJlZj9I3N4La3cfjF+1G52z+e 98EUVBOk7NBK0jqM6prKrVGOy9Rz7v0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-278-9dXyWPYcOxCf54YDKpZcrw-1; Thu, 07 May 2020 03:44:40 -0400 X-MC-Unique: 9dXyWPYcOxCf54YDKpZcrw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D017C1895A2A; Thu, 7 May 2020 07:44:38 +0000 (UTC) Received: from T590 (ovpn-8-38.pek2.redhat.com [10.72.8.38]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 60B945D9C5; Thu, 7 May 2020 07:44:27 +0000 (UTC) Date: Thu, 7 May 2020 15:44:23 +0800 From: Ming Lei To: Christoph Hellwig Cc: axboe@kernel.dk, yuyufen@huawei.com, tj@kernel.org, jack@suse.cz, bvanassche@acm.org, tytso@mit.edu, hdegoede@redhat.com, gregkh@linuxfoundation.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: bdi: fix use-after-free for dev_name(bdi->dev) v3 (resend) Message-ID: <20200507074423.GA1285373@T590> References: <20200504124801.2832087-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200504124801.2832087-1-hch@lst.de> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 04, 2020 at 02:47:52PM +0200, Christoph Hellwig wrote: > Hi Jens, > > can you pick up this series? > > the first three patches are my take on the proposal from Yufen Yu > to fix the use after free of the device name of the bdi device. > > The rest is vaguely related cleanups. > > Changes since v2: > - switch vboxsf to a shorter bdi name > > Changes since v1: > - use a static dev_name buffer inside struct backing_dev_info > Looks fine: Reviewed-by: Ming Lei -- Ming