Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <CGME20200430124955epcas5p4b5c1dd7393a7b798d80206d071264df3@epcas5p4.samsung.com>
 <1588250972-8507-1-git-send-email-maninder1.s@samsung.com> <1588250972-8507-2-git-send-email-maninder1.s@samsung.com>
In-Reply-To: <1588250972-8507-2-git-send-email-maninder1.s@samsung.com>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Thu, 7 May 2020 17:13:02 +0900
Message-ID: <CAK7LNARQNmrCYofk5yG6diwrZnaqgUs0ASBo23k25SnOKM3viQ@mail.gmail.com>
Subject: Re: [PATCH 2/4] scripts/checkstack.pl: Add argument to print stacks
 greather than value.
To:     Maninder Singh <maninder1.s@samsung.com>
Cc:     "George G. Davis" <george_davis@mentor.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        a.sahrawat@samsung.com, Vaneet Narang <v.narang@samsung.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Apr 30, 2020 at 9:50 PM Maninder Singh <maninder1.s@samsung.com> wrote:
>
> Add arguments support to print stacks which are greater than
> argument value only.
>
> Signed-off-by: Vaneet Narang <v.narang@samsung.com>
> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> ---
>  scripts/checkstack.pl | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/checkstack.pl b/scripts/checkstack.pl
> index 412c459..8e5ef98 100755
> --- a/scripts/checkstack.pl
> +++ b/scripts/checkstack.pl
> @@ -35,7 +35,7 @@ use strict;
>  # $1 (first bracket) matches the dynamic amount of the stack growth
>  #
>  # use anything else and feel the pain ;)
> -my (@stack, $re, $dre, $x, $xs, $funcre);
> +my (@stack, $re, $dre, $x, $xs, $funcre, $min_stack);
>  {
>         my $arch = shift;
>         if ($arch eq "") {
> @@ -43,6 +43,11 @@ my (@stack, $re, $dre, $x, $xs, $funcre);
>                 chomp($arch);
>         }
>
> +       $min_stack = shift;
> +       if ($min_stack eq "" || $min_stack !~ /^\d+$/) {
> +               $min_stack = 100;
> +       }
> +
>         $x      = "[0-9a-f]";   # hex character
>         $xs     = "[0-9a-f ]";  # hex character or space
>         $funcre = qr/^$x* <(.*)>:$/;
> @@ -113,7 +118,7 @@ my ($func, $file, $lastslash, $total_size, $addr, $intro);
>
>  while (my $line = <STDIN>) {
>         if ($line =~ m/$funcre/) {
> -               if ($total_size > 100) {
> +               if ($total_size > $min_stack) {
>                         push @stack, "$intro$total_size\n";
>                 }
>
> @@ -150,7 +155,6 @@ while (my $line = <STDIN>) {
>                         $size += 0x80000000;
>                 }
>                 next if ($size > 0x10000000);
> -


This is a noise change.

You can do this in 1/4 if you want to.


>                 $total_size = $total_size + $size
>         }
>         elsif (defined $dre && $line =~ m/$dre/) {
> @@ -160,7 +164,7 @@ while (my $line = <STDIN>) {
>                 $total_size = $total_size + $size
>         }
>  }
> -if ($total_size > 100) {
> +if ($total_size > $min_stack) {
>         push @stack, "$intro$total_size\n";
>  }
>
> --
> 1.9.1
>


--
Best Regards

Masahiro Yamada