Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: aDOPUNuQuXya77sm5jk5VJKoaxwv11GiEZNQu/vbh/VIVfIMR81jxSQod3FfgthFPlRBQvsxsb
 2h6C+r1o7xHg==
From:   SeongJae Park <sjpark@amazon.com>
To:     <Jonathan.Cameron@Huawei.com>, SeongJae Park <sjpark@amazon.com>
CC:     <akpm@linux-foundation.org>, SeongJae Park <sjpark@amazon.de>,
        <aarcange@redhat.com>, <acme@kernel.org>,
        <alexander.shishkin@linux.intel.com>, <amit@kernel.org>,
        <benh@kernel.crashing.org>, <brendan.d.gregg@gmail.com>,
        <brendanhiggins@google.com>, <cai@lca.pw>,
        <colin.king@canonical.com>, <corbet@lwn.net>, <dwmw@amazon.com>,
        <irogers@google.com>, <jolsa@redhat.com>, <kirill@shutemov.name>,
        <mark.rutland@arm.com>, <mgorman@suse.de>, <minchan@kernel.org>,
        <mingo@redhat.com>, <namhyung@kernel.org>, <peterz@infradead.org>,
        <rdunlap@infradead.org>, <riel@surriel.com>, <rientjes@google.com>,
        <rostedt@goodmis.org>, <sblbir@amazon.com>, <shakeelb@google.com>,
        <shuah@kernel.org>, <sj38.park@gmail.com>, <snu@amazon.de>,
        <vbabka@suse.cz>, <vdavydov.dev@gmail.com>,
        <yang.shi@linux.alibaba.com>, <ying.huang@intel.com>,
        <linux-damon@amazon.com>, <linux-mm@kvack.org>,
        <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v10 06/16] mm/damon: Split regions into 4 subregions if possible
Date:   Thu, 7 May 2020 10:28:36 +0200
Message-ID: <20200507082836.32145-1-sjpark@amazon.com>
In-Reply-To: <20200505110815.10532-7-sjpark@amazon.com> (raw)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 5 May 2020 13:08:05 +0200 SeongJae Park <sjpark@amazon.com> wrote:

> From: SeongJae Park <sjpark@amazon.de>
> 
> Suppose that there are a very wide and cold region and a hot region, and
> both regions are identified by DAMON.  And then, the middle small region
> inside the very wide and cold region becomes hot.  DAMON will not be
> able to identify this new region because the adaptive regions adjustment
> mechanism splits each region to only two subregions.
> 
> This commit modifies the logic to split each region to 4 subregions if
> possible so that such problematic region can eventually identified.

As you can check with the 'Evaluations' section in the cover letter of this
patchset, the extend of the slowdown DAMON's recording feature made to the
target workload has doulbed (0.55% with v9, 1.02% with this patchset).  It's
still just a small number, but the worst case slowdown is 5.29%.  It was only
1.88% before.  I suspect this patch is the reason, as this is the only one
major change we made after v9.

For the reason, I would like to make this patch to split each region into 3 sub
regions instead of 4 subregions.  It will reduce the overhead a little bit
while still allow the corner case regions be eventually detected.  If you have
other concerns or opinions, please let me know.


Thanks,
SeongJae Park

> 
> Suggested-by: James Cameron <Jonathan.Cameron@Huawei.com>
> Signed-off-by: SeongJae Park <sjpark@amazon.de>
> ---
>  mm/damon.c | 44 +++++++++++++++++++++++++++-----------------
>  1 file changed, 27 insertions(+), 17 deletions(-)
> 
> diff --git a/mm/damon.c b/mm/damon.c
> index cec946197e13..342f905927a0 100644
> --- a/mm/damon.c
> +++ b/mm/damon.c
> @@ -650,26 +650,32 @@ static void damon_split_region_at(struct damon_ctx *ctx,
>  	damon_insert_region(new, r, damon_next_region(r));
>  }
>  
> -/* Split every region in the given task into two randomly-sized regions */
> -static void damon_split_regions_of(struct damon_ctx *ctx, struct damon_task *t)
> +/* Split every region in the given task into 'nr_subs' regions */
> +static void damon_split_regions_of(struct damon_ctx *ctx,
> +				     struct damon_task *t, int nr_subs)
>  {
>  	struct damon_region *r, *next;
> -	unsigned long sz_orig_region, sz_left_region;
> +	unsigned long sz_region, sz_sub = 0;
> +	int i;
>  
>  	damon_for_each_region_safe(r, next, t) {
> -		sz_orig_region = r->vm_end - r->vm_start;
> -
> -		/*
> -		 * Randomly select size of left sub-region to be at least
> -		 * 10 percent and at most 90% of original region
> -		 */
> -		sz_left_region = ALIGN_DOWN(damon_rand(1, 10) * sz_orig_region
> -					    / 10, MIN_REGION);
> -		/* Do not allow blank region */
> -		if (sz_left_region == 0 || sz_left_region >= sz_orig_region)
> -			continue;
> -
> -		damon_split_region_at(ctx, r, sz_left_region);
> +		sz_region = r->vm_end - r->vm_start;
> +
> +		for (i = 0; i < nr_subs - 1 &&
> +				sz_region > 2 * MIN_REGION; i++) {
> +			/*
> +			 * Randomly select size of left sub-region to be at
> +			 * least 10 percent and at most 90% of original region
> +			 */
> +			sz_sub = ALIGN_DOWN(damon_rand(1, 10) *
> +					sz_region / 10, MIN_REGION);
> +			/* Do not allow blank region */
> +			if (sz_sub == 0 || sz_sub >= sz_region)
> +				continue;
> +
> +			damon_split_region_at(ctx, r, sz_sub);
> +			sz_region = sz_sub;
> +		}
>  	}
>  }
>  
> @@ -687,14 +693,18 @@ static void kdamond_split_regions(struct damon_ctx *ctx)
>  {
>  	struct damon_task *t;
>  	unsigned int nr_regions = 0;
> +	int nr_subregions = 2;
>  
>  	damon_for_each_task(ctx, t)
>  		nr_regions += nr_damon_regions(t);
>  	if (nr_regions > ctx->max_nr_regions / 2)
>  		return;
>  
> +	if (nr_regions < ctx->max_nr_regions / 4)
> +		nr_subregions = 4;
> +
>  	damon_for_each_task(ctx, t)
> -		damon_split_regions_of(ctx, t);
> +		damon_split_regions_of(ctx, t, nr_subregions);
>  }
>  
>  /*
> -- 
> 2.17.1
>