Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp612007ybj; Thu, 7 May 2020 03:34:58 -0700 (PDT) X-Google-Smtp-Source: APiQypIAFg+BgwAzrZXJqsS54qn6iBUYFQpvUG9G7sGF35jyRkmPQZ9rhd4M3QVR26Nl9sBjWotn X-Received: by 2002:a17:906:748c:: with SMTP id e12mr10871053ejl.375.1588847698482; Thu, 07 May 2020 03:34:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588847698; cv=none; d=google.com; s=arc-20160816; b=hjMOivyW9C6Ixa+LRZiWfj7DCTg3KJOi8DrOWLxF8tGq47MLgSwz/VZTrbbDkEzUmF jbKlQwdV0C2bS04eRMtkA0zY2MpPt015/bHjYfD8BbbZWjj0q7X5cxKyhY8QueyeN3tw j9rnZq0XtNgf3S0fIyLttlnpOWONhoWMByX9f0zpgzZsHzevGD/oZtNPSNT9RrpXUG/f KbldKsF4LDuSF4tQlAqWiOyks9Zv8gtgc/jQ9/m0ZOs8/sOnJ+UO1tmRFdB6LNqHYaZ6 O6oD9X0TIoggNGCX4QrH8b1mRGuQ/fiRnXcLX2Xq9KsjUoOx/nRKVgqIcDzN6bWaoZlY r0rQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=IujT3BnTdhkrMKtq+VTmUdOP0D4iPN6l9Iqa4L/XwA0=; b=x6GLVbKEbJey7dRsUTtZzCa/2BmWO4Y/GmEpZLfiqtgBi99WeytmYud6q5Ui6OycOc CzLHX8CM4/PxBYwizx4aiIzVzI8x48f2tFeZpNDoEs+qYg0lWW4YKsu+swN5cqEmvxms G9XtudKZUil6hXy2FcUxG865YHXvbrdCsSaTgahak88BhvyZyPU38cVplYzHwcBxapEe k0xV1AzYicYhGkVfQKjxdCjqgVcxEAgLp00wU+Fy+KPc+CExMuJU9JwTQO2jQCsHy982 /Wj3J9i9UyA+6np4accfE8apgEK0K1prXyKxZfxCuHP8QjJhCXE1nOXxPzpp/Sw2Zx1g 1m4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="I/O/7DUT"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e7si2750787ejx.367.2020.05.07.03.34.33; Thu, 07 May 2020 03:34:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="I/O/7DUT"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726951AbgEGKcl (ORCPT + 99 others); Thu, 7 May 2020 06:32:41 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:30080 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726884AbgEGKck (ORCPT ); Thu, 7 May 2020 06:32:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588847557; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IujT3BnTdhkrMKtq+VTmUdOP0D4iPN6l9Iqa4L/XwA0=; b=I/O/7DUTVvqgD7XSrfjxPyzGepVuPIpTIE7yKZ1ERc0V3lnuRg5JZ2qRLGczHR6jdF9RuQ gxYbRGSPB82VLYtF9uBXdEjG0JXf7jH7t20SdZrJk9hh5OAD6vX6j+NkrvV49KZQbZLJhY 4rSwfs4s4/H7lRQfCaa45mmT7GxKXAw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-392-tKVJj8TCPVqFScAUzI77EQ-1; Thu, 07 May 2020 06:32:34 -0400 X-MC-Unique: tKVJj8TCPVqFScAUzI77EQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9D74E19200C2; Thu, 7 May 2020 10:32:31 +0000 (UTC) Received: from t480s.redhat.com (ovpn-113-245.ams2.redhat.com [10.36.113.245]) by smtp.corp.redhat.com (Postfix) with ESMTP id BF7955D9C5; Thu, 7 May 2020 10:32:24 +0000 (UTC) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, virtio-dev@lists.oasis-open.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, Michal Hocko , Andrew Morton , "Michael S . Tsirkin" , David Hildenbrand , Michal Hocko , Pankaj Gupta , Jason Wang , Oscar Salvador , Igor Mammedov , Dave Young , Dan Williams , Pavel Tatashin , Stefan Hajnoczi , Vlastimil Babka , Mel Gorman , Mike Rapoport , Alexander Duyck , Alexander Potapenko Subject: [PATCH v3 04/15] virtio-mem: Paravirtualized memory hotunplug part 2 Date: Thu, 7 May 2020 12:31:08 +0200 Message-Id: <20200507103119.11219-5-david@redhat.com> In-Reply-To: <20200507103119.11219-1-david@redhat.com> References: <20200507103119.11219-1-david@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We also want to unplug online memory (contained in online memory blocks and, therefore, managed by the buddy), and eventually replug it later. When requested to unplug memory, we use alloc_contig_range() to allocate subblocks in online memory blocks (so we are the owner) and send them to our hypervisor. When requested to plug memory, we can replug such memory using free_contig_range() after asking our hypervisor. We also want to mark all allocated pages PG_offline, so nobody will touch them. To differentiate pages that were never onlined when onlining the memory block from pages allocated via alloc_contig_range(), = we use PageDirty(). Based on this flag, virtio_mem_fake_online() can either online the pages for the first time or use free_contig_range(). It is worth noting that there are no guarantees on how much memory can actually get unplugged again. All device memory might completely be fragmented with unmovable data, such that no subblock can get unplugged. We are not touching the ZONE_MOVABLE. If memory is onlined to the ZONE_MOVABLE, it can only get unplugged after that memory was offlined manually by user space. In normal operation, virtio-mem memory is suggested to be onlined to ZONE_NORMAL. In the future, we will try to make unplug more likely to succeed. Add a module parameter to control if online memory shall be touched. As we want to access alloc_contig_range()/free_contig_range() from kernel module context, export the symbols. Note: Whenever virtio-mem uses alloc_contig_range(), all affected pages are on the same node, in the same zone, and contain no holes. Acked-by: Michal Hocko # to export contig range allocat= or API Tested-by: Pankaj Gupta Cc: "Michael S. Tsirkin" Cc: Jason Wang Cc: Oscar Salvador Cc: Michal Hocko Cc: Igor Mammedov Cc: Dave Young Cc: Andrew Morton Cc: Dan Williams Cc: Pavel Tatashin Cc: Stefan Hajnoczi Cc: Vlastimil Babka Cc: Mel Gorman Cc: Mike Rapoport Cc: Alexander Duyck Cc: Alexander Potapenko Signed-off-by: David Hildenbrand --- drivers/virtio/Kconfig | 1 + drivers/virtio/virtio_mem.c | 157 ++++++++++++++++++++++++++++++++---- mm/page_alloc.c | 2 + 3 files changed, 146 insertions(+), 14 deletions(-) diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig index d6dde7d2cf76..4c1e14615001 100644 --- a/drivers/virtio/Kconfig +++ b/drivers/virtio/Kconfig @@ -85,6 +85,7 @@ config VIRTIO_MEM depends on VIRTIO depends on MEMORY_HOTPLUG_SPARSE depends on MEMORY_HOTREMOVE + select CONTIG_ALLOC help This driver provides access to virtio-mem paravirtualized memory devices, allowing to hotplug and hotunplug memory. diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c index a3ec795be8be..74f0d3cb1d22 100644 --- a/drivers/virtio/virtio_mem.c +++ b/drivers/virtio/virtio_mem.c @@ -23,6 +23,10 @@ =20 #include =20 +static bool unplug_online =3D true; +module_param(unplug_online, bool, 0644); +MODULE_PARM_DESC(unplug_online, "Try to unplug online memory"); + enum virtio_mem_mb_state { /* Unplugged, not added to Linux. Can be reused later. */ VIRTIO_MEM_MB_STATE_UNUSED =3D 0, @@ -654,23 +658,35 @@ static int virtio_mem_memory_notifier_cb(struct not= ifier_block *nb, } =20 /* - * Set a range of pages PG_offline. + * Set a range of pages PG_offline. Remember pages that were never onlin= ed + * (via generic_online_page()) using PageDirty(). */ static void virtio_mem_set_fake_offline(unsigned long pfn, - unsigned int nr_pages) + unsigned int nr_pages, bool onlined) { - for (; nr_pages--; pfn++) - __SetPageOffline(pfn_to_page(pfn)); + for (; nr_pages--; pfn++) { + struct page *page =3D pfn_to_page(pfn); + + __SetPageOffline(page); + if (!onlined) + SetPageDirty(page); + } } =20 /* - * Clear PG_offline from a range of pages. + * Clear PG_offline from a range of pages. If the pages were never onlin= ed, + * (via generic_online_page()), clear PageDirty(). */ static void virtio_mem_clear_fake_offline(unsigned long pfn, - unsigned int nr_pages) + unsigned int nr_pages, bool onlined) { - for (; nr_pages--; pfn++) - __ClearPageOffline(pfn_to_page(pfn)); + for (; nr_pages--; pfn++) { + struct page *page =3D pfn_to_page(pfn); + + __ClearPageOffline(page); + if (!onlined) + ClearPageDirty(page); + } } =20 /* @@ -686,10 +702,26 @@ static void virtio_mem_fake_online(unsigned long pf= n, unsigned int nr_pages) * We are always called with subblock granularity, which is at least * aligned to MAX_ORDER - 1. */ - virtio_mem_clear_fake_offline(pfn, nr_pages); + for (i =3D 0; i < nr_pages; i +=3D 1 << order) { + struct page *page =3D pfn_to_page(pfn + i); =20 - for (i =3D 0; i < nr_pages; i +=3D 1 << order) - generic_online_page(pfn_to_page(pfn + i), order); + /* + * If the page is PageDirty(), it was kept fake-offline when + * onlining the memory block. Otherwise, it was allocated + * using alloc_contig_range(). All pages in a subblock are + * alike. + */ + if (PageDirty(page)) { + virtio_mem_clear_fake_offline(pfn + i, 1 << order, + false); + generic_online_page(page, order); + } else { + virtio_mem_clear_fake_offline(pfn + i, 1 << order, + true); + free_contig_range(pfn + i, 1 << order); + adjust_managed_page_count(page, 1 << order); + } + } } =20 static void virtio_mem_online_page_cb(struct page *page, unsigned int or= der) @@ -718,7 +750,8 @@ static void virtio_mem_online_page_cb(struct page *pa= ge, unsigned int order) if (virtio_mem_mb_test_sb_plugged(vm, mb_id, sb_id, 1)) generic_online_page(page, order); else - virtio_mem_set_fake_offline(PFN_DOWN(addr), 1 << order); + virtio_mem_set_fake_offline(PFN_DOWN(addr), 1 << order, + false); rcu_read_unlock(); return; } @@ -1186,6 +1219,72 @@ static int virtio_mem_mb_unplug_any_sb_offline(str= uct virtio_mem *vm, return 0; } =20 +/* + * Unplug the desired number of plugged subblocks of an online memory bl= ock. + * Will skip subblock that are busy. + * + * Will modify the state of the memory block. + * + * Note: Can fail after some subblocks were successfully unplugged. Can + * return 0 even if subblocks were busy and could not get unplugge= d. + */ +static int virtio_mem_mb_unplug_any_sb_online(struct virtio_mem *vm, + unsigned long mb_id, + uint64_t *nb_sb) +{ + const unsigned long nr_pages =3D PFN_DOWN(vm->subblock_size); + unsigned long start_pfn; + int rc, sb_id; + + /* + * TODO: To increase the performance we want to try bigger, consecutive + * subblocks first before falling back to single subblocks. Also, + * we should sense via something like is_mem_section_removable() + * first if it makes sense to go ahead any try to allocate. + */ + for (sb_id =3D 0; sb_id < vm->nb_sb_per_mb && *nb_sb; sb_id++) { + /* Find the next candidate subblock */ + while (sb_id < vm->nb_sb_per_mb && + !virtio_mem_mb_test_sb_plugged(vm, mb_id, sb_id, 1)) + sb_id++; + if (sb_id >=3D vm->nb_sb_per_mb) + break; + + start_pfn =3D PFN_DOWN(virtio_mem_mb_id_to_phys(mb_id) + + sb_id * vm->subblock_size); + rc =3D alloc_contig_range(start_pfn, start_pfn + nr_pages, + MIGRATE_MOVABLE, GFP_KERNEL); + if (rc =3D=3D -ENOMEM) + /* whoops, out of memory */ + return rc; + if (rc) + /* memory busy, we can't unplug this chunk */ + continue; + + /* Mark it as fake-offline before unplugging it */ + virtio_mem_set_fake_offline(start_pfn, nr_pages, true); + adjust_managed_page_count(pfn_to_page(start_pfn), -nr_pages); + + /* Try to unplug the allocated memory */ + rc =3D virtio_mem_mb_unplug_sb(vm, mb_id, sb_id, 1); + if (rc) { + /* Return the memory to the buddy. */ + virtio_mem_fake_online(start_pfn, nr_pages); + return rc; + } + + virtio_mem_mb_set_state(vm, mb_id, + VIRTIO_MEM_MB_STATE_ONLINE_PARTIAL); + *nb_sb -=3D 1; + } + + /* + * TODO: Once all subblocks of a memory block were unplugged, we want + * to offline the memory block and remove it. + */ + return 0; +} + /* * Try to unplug the requested amount of memory. */ @@ -1225,8 +1324,37 @@ static int virtio_mem_unplug_request(struct virtio= _mem *vm, uint64_t diff) cond_resched(); } =20 + if (!unplug_online) { + mutex_unlock(&vm->hotplug_mutex); + return 0; + } + + /* Try to unplug subblocks of partially plugged online blocks. */ + virtio_mem_for_each_mb_state_rev(vm, mb_id, + VIRTIO_MEM_MB_STATE_ONLINE_PARTIAL) { + rc =3D virtio_mem_mb_unplug_any_sb_online(vm, mb_id, + &nb_sb); + if (rc || !nb_sb) + goto out_unlock; + mutex_unlock(&vm->hotplug_mutex); + cond_resched(); + mutex_lock(&vm->hotplug_mutex); + } + + /* Try to unplug subblocks of plugged online blocks. */ + virtio_mem_for_each_mb_state_rev(vm, mb_id, + VIRTIO_MEM_MB_STATE_ONLINE) { + rc =3D virtio_mem_mb_unplug_any_sb_online(vm, mb_id, + &nb_sb); + if (rc || !nb_sb) + goto out_unlock; + mutex_unlock(&vm->hotplug_mutex); + cond_resched(); + mutex_lock(&vm->hotplug_mutex); + } + mutex_unlock(&vm->hotplug_mutex); - return 0; + return nb_sb ? -EBUSY : 0; out_unlock: mutex_unlock(&vm->hotplug_mutex); return rc; @@ -1332,7 +1460,8 @@ static void virtio_mem_run_wq(struct work_struct *w= ork) case -EBUSY: /* * The hypervisor cannot process our request right now - * (e.g., out of memory, migrating). + * (e.g., out of memory, migrating) or we cannot free up + * any memory to unplug it (all plugged memory is busy). */ case -ENOMEM: /* Out of memory, try again later. */ diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 1b265b09d342..64fcaf86763b 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -8461,6 +8461,7 @@ int alloc_contig_range(unsigned long start, unsigne= d long end, pfn_max_align_up(end), migratetype); return ret; } +EXPORT_SYMBOL(alloc_contig_range); =20 static int __alloc_contig_pages(unsigned long start_pfn, unsigned long nr_pages, gfp_t gfp_mask) @@ -8576,6 +8577,7 @@ void free_contig_range(unsigned long pfn, unsigned = int nr_pages) } WARN(count !=3D 0, "%d pages are still in use!\n", count); } +EXPORT_SYMBOL(free_contig_range); =20 /* * The zone indicated has a new number of managed_pages; batch sizes and= percpu --=20 2.25.3