Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1588250972-8507-1-git-send-email-maninder1.s@samsung.com>
 <1588250972-8507-4-git-send-email-maninder1.s@samsung.com>
 <CGME20200430125001epcas5p2a6f02e9888481cef96f32ba14450bc63@epcms5p5>
 <CAK7LNASf687MLf1oWqrUiOHtw=p9Ug02bi1r-KevsxnFtQni2g@mail.gmail.com> <20200507105122epcms5p543853209caaec4c3b031d64f916f9ccc@epcms5p5>
In-Reply-To: <20200507105122epcms5p543853209caaec4c3b031d64f916f9ccc@epcms5p5>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Thu, 7 May 2020 20:58:59 +0900
Message-ID: <CAK7LNATkW08MPhiZ4c1ScdZwQ1bu5TnLsj+Tcu1QP7KdmXgNsQ@mail.gmail.com>
Subject: Re: [PATCH 4/4] scripts/checkstack.pl: fix arm sp regex
To:     Maninder Singh <maninder1.s@samsung.com>
Cc:     "George G. Davis" <george_davis@mentor.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        AMIT SAHRAWAT <a.sahrawat@samsung.com>,
        Vaneet Narang <v.narang@samsung.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, May 7, 2020 at 8:43 PM Maninder Singh <maninder1.s@samsung.com> wrote:
>
> Hi Masahiro,
>
> Thanks for review.
> We will integrate your review comements and send v2.
>
> >>
>
> >> so making regex $re for ARM similar to aarch64
> >>
> >> Signed-off-by: Vaneet Narang <v.narang@samsung.com>
> >> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> >
> >
> >This looks good to me, and it is a bug fix.
> >
> >Just a question about the SOB.
> >
> >
> >Maninder Singh is the author and also the submitter, right?
> >
> >What does "Signed-off-by: Vaneet Narang <v.narang@samsung.com>" mean?
> >
> >Co-developed-by or something else?
>
> Yes All 4 patches are co-developed by Vaneet and me.
> we were checking stack usage for arm and AARCH64 and found
> some changes in scrips which can help others also.
>

OK. Then,

Co-developed-by: Vaneet Narang <v.narang@samsung.com>

is the correct tag.


Signed-off-by is added when the patch is forwarded by
somebody else. This is not the case.


-- 
Best Regards
Masahiro Yamada