Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp715943ybj; Thu, 7 May 2020 06:06:56 -0700 (PDT) X-Google-Smtp-Source: APiQypKOMLMGEwfuyH8gO3xB2rOy/Bsqb7rcqhKo5LJo0Yw7uacHdIRzEHiONvGfe12bZ1/rvKWr X-Received: by 2002:a17:906:6990:: with SMTP id i16mr11519933ejr.175.1588856815800; Thu, 07 May 2020 06:06:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588856815; cv=none; d=google.com; s=arc-20160816; b=vWzyYgewarXyXh/CUOQ6HbzxwquLtSL1N03R1iRl5JzoC5Ch0wPiJ/cmz8qFdD7k3b rdte9dmQzMTlADtw75Loe8AJlbp4E01BVOzKKqF97iTDS0Ip0L3/tx+qm1+gE0qoIQm1 RaUpKoh18FeITjnsm6+2ST0nwV4+1Ef6q3rGt0PZVY8oC5AUko0OiRdWHX2fcvHASS0+ ivhijUvEawFYtEp7PUtdEXvE+vnrZkGNB51uPfFuXf6Ul4ohx3Ft8Mq9Cvk49M8Rgdo3 2l+XSnvcdrkVzIAQne1+V6R4vK1FullFr3s0jYsWmVBjXOdBNANq8KD0cQGNKTVP54pY ikXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject; bh=Ka3RQelGFF6nJp5S2JKueCKR/gmc/hipFrZU0HdFaQQ=; b=CY5/S6LzSvMTpeRzjbXcZamRpp2USGWwxhkvy4d4zq63GVc+Kkp3Fnm1Qy5HL4MR7n bG7AkK9Obl/FP6+IEpiK5f+6NzcaQdie8k0j7ok9zPl053mFZvI+UIj00I0EPUdpmvuB xKDy4W5+lT00L2XOFo2gpKDq6zMF3E8JWUTRuVN2aKEuXbvj+xuwNKYGJyS7dCxQS1VM CuShBGzl67uYDbLCPybMQ7nZnhzJdoDoAGGI+XAi2td50DwPq0XG/rxFtuDwO99uWOVJ dOZMkdDxzMoBzNlxD3/8t6avUyb0L5cUqwmB1tT09q7mZKVd8DuCQ7rgezJg0DhEolrq T9Fw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p16si3013609ejx.212.2020.05.07.06.06.28; Thu, 07 May 2020 06:06:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726598AbgEGNEq (ORCPT + 99 others); Thu, 7 May 2020 09:04:46 -0400 Received: from out30-133.freemail.mail.aliyun.com ([115.124.30.133]:58059 "EHLO out30-133.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725914AbgEGNEq (ORCPT ); Thu, 7 May 2020 09:04:46 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R881e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e07425;MF=tianjia.zhang@linux.alibaba.com;NM=1;PH=DS;RN=37;SR=0;TI=SMTPD_---0TxqomBt_1588856677; Received: from 30.27.116.247(mailfrom:tianjia.zhang@linux.alibaba.com fp:SMTPD_---0TxqomBt_1588856677) by smtp.aliyun-inc.com(127.0.0.1); Thu, 07 May 2020 21:04:38 +0800 Subject: Re: [PATCH v4 2/7] KVM: arm64: clean up redundant 'kvm_run' parameters To: Marc Zyngier Cc: pbonzini@redhat.com, tsbogend@alpha.franken.de, paulus@ozlabs.org, mpe@ellerman.id.au, benh@kernel.crashing.org, borntraeger@de.ibm.com, frankja@linux.ibm.com, david@redhat.com, cohuck@redhat.com, heiko.carstens@de.ibm.com, gor@linux.ibm.com, sean.j.christopherson@intel.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, christoffer.dall@arm.com, peterx@redhat.com, thuth@redhat.com, chenhuacai@gmail.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200427043514.16144-1-tianjia.zhang@linux.alibaba.com> <20200427043514.16144-3-tianjia.zhang@linux.alibaba.com> <35eb095a344b4192b912385bc02c54e6@kernel.org> From: Tianjia Zhang Message-ID: Date: Thu, 7 May 2020 21:04:37 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <35eb095a344b4192b912385bc02c54e6@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/5/5 16:39, Marc Zyngier wrote: > Hi Tianjia, > > On 2020-04-27 05:35, Tianjia Zhang wrote: >> In the current kvm version, 'kvm_run' has been included in the 'kvm_vcpu' >> structure. For historical reasons, many kvm-related function parameters >> retain the 'kvm_run' and 'kvm_vcpu' parameters at the same time. This >> patch does a unified cleanup of these remaining redundant parameters. >> >> Signed-off-by: Tianjia Zhang > > On the face of it, this looks OK, but I haven't tried to run the > resulting kernel. I'm not opposed to taking this patch *if* there > is an agreement across architectures to take the series (I value > consistency over the janitorial exercise). > > Another thing is that this is going to conflict with the set of > patches that move the KVM/arm code back where it belongs (arch/arm64/kvm), > so I'd probably cherry-pick that one directly. > > Thanks, > >         M. > Do I need to submit this set of patches separately for each architecture? Could it be merged at once, if necessary, I will resubmit based on the latest mainline. Thanks, Tianjia