Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp732965ybj; Thu, 7 May 2020 06:29:18 -0700 (PDT) X-Google-Smtp-Source: APiQypLhJGqbeyjaPCdG1/PulFgI4YSii8kUwzqOJ78PZCc4iVjYfKUwbtUPa3sDuEJA+0CFWMmg X-Received: by 2002:aa7:dd84:: with SMTP id g4mr12195178edv.273.1588858158500; Thu, 07 May 2020 06:29:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588858158; cv=none; d=google.com; s=arc-20160816; b=yF9gQVQsyHOsuozf7BIaTmXYG568RZcPynt8Ge8hLKeQpcdZHt9bTY8tUb7FD6x0/x 4XBINPnVl0RFMGRDeBGyhn0UgUFRc4riHfZM/SzOxDPgA4wdGyLjc9CP9M9bHhYfjKgF bDMEbUImfTfm8SFcFEcZalVy5htOGaJ5+TIWPDsyc27wf5XRID4WbuAy2A8gMoQgeXVQ HKYSS6rU9pP3N+W828rQzoBoNbkCQmYqvTRme2GaOiN0e4aGTmzy2PdbuAKilXj8cyKe WlpGIZx3cCbPHE0O/u66fuCj3mtqBcKG9yDS6j5dHF+8KOaN7Oj5BKFlK1X36R0KhhJx Atog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :robot-unsubscribe:robot-id:message-id:mime-version:references :in-reply-to:cc:subject:to:reply-to:from:date; bh=GnlGE0VETSJBvVuk1NrPgvCcZy08lQ8KUSwIHM6xb7I=; b=MeaDa2OIu8q6BLTPX2MR1DaBgFqwVXss939j4vbV6ixYRJCFm3Qxja59rU2CT3+cMs bdduetEXv7axkIxvcc12l4MJzmr6FInGtz2D3eLZddj+cD98+44HcJU4u6+wC5ahEzvX 5qR3o/Gx/ozYTryX94uW+Ozp4jmS1pjLssxNkixqkoznq6gEulrEcWfpZSo11/ihzbU5 GbME0t+3e00TmsBGIsB0drj8YOsMNvgLX5UrtgEJA+R5P3lyrPh+LVpwvM2dJtM4eHxS mQ31VQ5Z99AhkrXV1yGPcxLmtXuA4Kn0WDWdTdmLh1lF5btNIHugzMW/4GVJ3jFTOCoG 3QNA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p4si3211557ejd.3.2020.05.07.06.28.53; Thu, 07 May 2020 06:29:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726408AbgEGN0Z (ORCPT + 99 others); Thu, 7 May 2020 09:26:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725914AbgEGN0Z (ORCPT ); Thu, 7 May 2020 09:26:25 -0400 Received: from Galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDA95C05BD43; Thu, 7 May 2020 06:26:24 -0700 (PDT) Received: from [5.158.153.53] (helo=tip-bot2.lab.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1jWgXc-0001F7-Qb; Thu, 07 May 2020 15:26:20 +0200 Received: from [127.0.1.1] (localhost [IPv6:::1]) by tip-bot2.lab.linutronix.de (Postfix) with ESMTP id DF7C31C001A; Thu, 7 May 2020 15:26:19 +0200 (CEST) Date: Thu, 07 May 2020 13:26:19 -0000 From: "tip-bot2 for Qais Yousef" Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: smp/core] cpu/hotplug: Remove __freeze_secondary_cpus() Cc: Qais Yousef , Thomas Gleixner , "Rafael J. Wysocki" , x86 , LKML In-Reply-To: <20200430114004.17477-2-qais.yousef@arm.com> References: <20200430114004.17477-2-qais.yousef@arm.com> MIME-Version: 1.0 Message-ID: <158885797977.8414.5020896178410312608.tip-bot2@tip-bot2> X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the smp/core branch of tip: Commit-ID: fb7fb84a0c4e8021ddecb157802d58241a3f1a40 Gitweb: https://git.kernel.org/tip/fb7fb84a0c4e8021ddecb157802d58241a3f1a40 Author: Qais Yousef AuthorDate: Thu, 30 Apr 2020 12:40:04 +01:00 Committer: Thomas Gleixner CommitterDate: Thu, 07 May 2020 15:18:41 +02:00 cpu/hotplug: Remove __freeze_secondary_cpus() The refactored function is no longer required as the codepaths that call freeze_secondary_cpus() are all suspend/resume related now. Signed-off-by: Qais Yousef Signed-off-by: Thomas Gleixner Cc: "Rafael J. Wysocki" Link: https://lkml.kernel.org/r/20200430114004.17477-2-qais.yousef@arm.com --- include/linux/cpu.h | 7 +------ kernel/cpu.c | 4 ++-- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/include/linux/cpu.h b/include/linux/cpu.h index 9d34dc3..5269258 100644 --- a/include/linux/cpu.h +++ b/include/linux/cpu.h @@ -144,12 +144,7 @@ static inline void get_online_cpus(void) { cpus_read_lock(); } static inline void put_online_cpus(void) { cpus_read_unlock(); } #ifdef CONFIG_PM_SLEEP_SMP -int __freeze_secondary_cpus(int primary, bool suspend); -static inline int freeze_secondary_cpus(int primary) -{ - return __freeze_secondary_cpus(primary, true); -} - +extern int freeze_secondary_cpus(int primary); extern void thaw_secondary_cpus(void); static inline int suspend_disable_secondary_cpus(void) diff --git a/kernel/cpu.c b/kernel/cpu.c index d766929..9f89214 100644 --- a/kernel/cpu.c +++ b/kernel/cpu.c @@ -1327,7 +1327,7 @@ void bringup_nonboot_cpus(unsigned int setup_max_cpus) #ifdef CONFIG_PM_SLEEP_SMP static cpumask_var_t frozen_cpus; -int __freeze_secondary_cpus(int primary, bool suspend) +int freeze_secondary_cpus(int primary) { int cpu, error = 0; @@ -1352,7 +1352,7 @@ int __freeze_secondary_cpus(int primary, bool suspend) if (cpu == primary) continue; - if (suspend && pm_wakeup_pending()) { + if (pm_wakeup_pending()) { pr_info("Wakeup pending. Abort CPU freeze\n"); error = -EBUSY; break;