Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp764904ybj; Thu, 7 May 2020 07:10:40 -0700 (PDT) X-Google-Smtp-Source: APiQypIAw7LtN0RW1VYUyiKCR/DVKZeTx3H+gv1ef6WsQij89PnTKuyK6bGvMjUKD2aGLJanCGR6 X-Received: by 2002:a17:907:9c4:: with SMTP id bx4mr11917615ejc.199.1588860640369; Thu, 07 May 2020 07:10:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588860640; cv=none; d=google.com; s=arc-20160816; b=ynSVaPXdkJ4/sjxQQ8as4xnwTwzGmL7EzAY5SCrovn7fcjFZVibJEhdRw1/5P6FSEv CJ2DQRAhJ3SkyXRL5Phj2HHpVPtJuXQ2Pw6pLzqgTCGBPcWIkC5rjxPKxwWd7NaA79/2 m/mF7p5HZDc1SCWjCecizRHjNlnFdpJQ18NL6tFzDJDveIWtSTkx9ZjiuNmpxaZizRph yIX9g5Qtn+kjiLQi6P8GR8zobSel1fCrpapTVKvIRFbkhw9MrWp1lSje8sZ9dpIUbVuf kwvSptotVIeCG33CWwYqqsCb8AnR7DuwJyKOgAq1DXE/sIKMsnwTTSxioqYGFBHaRTnL xyRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=eOP30ZfbB5xXUoj+O5a7ctZUbKBtVH52EXqUPU0EMv0=; b=CrB3Tao72oTlPpwDYNwJdbcDjAij/cwmlh3myrpE6LN2OjGCaB9nJTtsYnyhBgB2Vn xQj8D6zuLhf0hqP3+pkjj0qx6pJpgdmzUOBZIkjBmtg0mdt/+xnlZ7RPyHf1kvkHt5qX ZHLfTK5GxNi/82xf9DemYEJbINha25nEr2C/tNdQHyCxRnvmJ9z7rv2apx9hY8fGRMIl YbM+xW5rr+6Kge/bfN/xqvLiwm0eBPl4Xk+X6yVd0rE4mgGBJevp4ZZoDchHDCuG4Tcl c7X66EzzUwf3xpCuP/Dz4eMVbLeoa+lBhyJT6PKIC1o33GBuNLVcH8LPFERIQBPYqZhs bZUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=jsUyk3Go; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v12si3271264edb.234.2020.05.07.07.10.16; Thu, 07 May 2020 07:10:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=jsUyk3Go; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728032AbgEGOIA (ORCPT + 99 others); Thu, 7 May 2020 10:08:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:60618 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726268AbgEGOH7 (ORCPT ); Thu, 7 May 2020 10:07:59 -0400 Received: from Mani-XPS-13-9360 (unknown [157.46.59.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F03462084D; Thu, 7 May 2020 14:07:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588860478; bh=up72YqQmbXKsh+0pM1oCFb1Y0z05K3pNe8Mi871M7kc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jsUyk3GojI51408CO+VP69Uj5RZ4eJkVtRwanijT5SOihR0odMv6AqV9EZzz+J4vR T6Tr+k2nnIhLGKQQWLg10jhz8YQoFL9axsSFvzcb+NeN05rqb4r2Q3PvDv3Hw90MXl 7te6rl2Rr1MRb/oDmEb64s1lK3JiRdPHtZK4Ev5U= Date: Thu, 7 May 2020 19:37:50 +0530 From: Manivannan Sadhasivam To: gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, fabrice.gasnier@st.com, andy.shevchenko@gmail.com, robh+dt@kernel.org, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com Subject: Re: [PATCH v3 0/2] Add CTS/RTS gpio support to STM32 UART Message-ID: <20200507140750.GA2019@Mani-XPS-13-9360> References: <20200420170204.24541-1-mani@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200420170204.24541-1-mani@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Greg, On Mon, Apr 20, 2020 at 10:32:02PM +0530, mani@kernel.org wrote: > From: Manivannan Sadhasivam > > Hello, > > This patchset adds CTS/RTS gpio support to STM32 UART controller. > Eventhough the UART controller supports using dedicated CTS/RTS gpios, > sometimes we need to use different set of gpios for flow control. > > This is necessary for the upcoming STM32MP1 based board called Stinger96 > IoT-Box. On that board, a bluetooth chip is connected to one of the UART > controller but the CTS/RTS lines got swapped mistakenly. So this patchset > serves as a workaround for that hardware bug and also supports the > usecase of using any gpio for CTS/RTS functionality. As per the sugggestion > provided by Andy for v1, I've now switched to mctrl_gpio driver. > > This patchset has been validated with Stinger96 IoT-Box connected to Murata > WiFi-BT combo chip. > Are you planning to take this series for 5.8? Thanks, Mani > Thanks, > Mani > > Changes in v3: > > * Added Andy's reviewed-by tag > * Fixed minor issues spotted by Fabrice > > Changes in v2: > > As per the review by Andy: > > * Switched to mctrl_gpio driver instead of using custom CTS/RTS > implementation > * Removed the use of software flow control terminology. > > Manivannan Sadhasivam (2): > dt-bindings: serial: Document CTS/RTS gpios in STM32 UART > tty: serial: Add modem control gpio support for STM32 UART > > .../bindings/serial/st,stm32-uart.yaml | 14 +++++ > drivers/tty/serial/Kconfig | 1 + > drivers/tty/serial/stm32-usart.c | 53 ++++++++++++++++++- > drivers/tty/serial/stm32-usart.h | 1 + > 4 files changed, 67 insertions(+), 2 deletions(-) > > -- > 2.17.1 >