Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp794830ybj; Thu, 7 May 2020 07:49:23 -0700 (PDT) X-Google-Smtp-Source: APiQypI1rf0JH3eYPopnPkyo22SJFYAiG7SX6Gh9PIVAfe5PtbAW3ou5vZTbJzrlBo6zlXhCPyl8 X-Received: by 2002:a50:eacb:: with SMTP id u11mr12059591edp.162.1588862962956; Thu, 07 May 2020 07:49:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588862962; cv=none; d=google.com; s=arc-20160816; b=YlM1n5FgKEnzP072QepvnbnryiaPlrrnEXNrecPIzy/VeCowvwLY9x/+g7IYlXoTsr ap/cxGSIJIdK8o+qwERBTXXim5IzQHiKUGURVcmdu1TbNBC/aEdTFX0w5y3ROPF9L+CB WtDJ715S3IpS9+E7USr/6iQIlPJB9bM2hGcHMWuYc/khMJrHR29GsIEuvpMN2BvmgwNO iwY7gtfcDMLkunMLtVXS4eOlYGSMX1kyfDX5ymam8V9OaYwVvnBEFPHr0sTUn5i+PsTi 9MvRmiPTAbFhkS33yMEU26YsbrdepRGWrvq3lqL1JVQ0C10yHhI4RhLLRN5/gqSYZ7Y1 4B2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:ironport-sdr :ironport-sdr; bh=NSpBu/q+H9fvROQezLRsjhdnOK0tXRX2Si+6xqM9UKQ=; b=uU9LR0aB0yQNE//+CpYLHc/rK9LrKnkbaw1EHlFSS/4PFRR7JdjY6ZlwdskAW5inGh F9lPUZgql36HMGjlFkYrV3K9lXQ9Y63y2FBa//7ywB8zXw7ENyh+caluPSy+PS0Tmrsi SVmdymUMaxvYK9DViBwzuBYdyu9JeNJ3gut+OoHfTyLZ82rEqaTaZf3VRNiwg+LP3PZM /FS2WpFeRfxL/Co+KXgt5Yca2V1d2G8d6GSrVcWkqnfZooUyGamGbMJzS2VdJmLuAmFC biAk9esw01vD7EcnAJSrpdMeTlHWQhNA2Ggcsv73P3uOlqFlfZ3fKS1mnVugU4ot15hr 9n+Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cm14si3119701edb.546.2020.05.07.07.48.59; Thu, 07 May 2020 07:49:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728261AbgEGOor (ORCPT + 99 others); Thu, 7 May 2020 10:44:47 -0400 Received: from mga14.intel.com ([192.55.52.115]:13074 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726069AbgEGOor (ORCPT ); Thu, 7 May 2020 10:44:47 -0400 IronPort-SDR: y4XDnlcFXx1rnW1BhOFtYUp2Vwbc59k8Eh4Y2HlqnwP0h5BUF7uuUC7cAgYifzQ2lZcmcnhhIN wXF3SKIXLlCg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2020 07:44:45 -0700 IronPort-SDR: 9i3xISujTRUf3ti8cieSFQSZ916JIV3ob91xq5STMWcgLzGqBILU2lddGBJB4zPBKrCadZ8weZ sjKSe2RlgVNQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,364,1583222400"; d="scan'208";a="263956282" Received: from smericks-mobl.amr.corp.intel.com (HELO [10.252.140.100]) ([10.252.140.100]) by orsmga006.jf.intel.com with ESMTP; 07 May 2020 07:44:44 -0700 Subject: Re: [PATCH 1/2] arch/x86: Rename config X86_INTEL_MEMORY_PROTECTION_KEYS to generic x86 To: Sebastian Andrzej Siewior Cc: Babu Moger , corbet@lwn.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, pbonzini@redhat.com, sean.j.christopherson@intel.com, x86@kernel.org, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, mchehab+samsung@kernel.org, changbin.du@intel.com, namit@vmware.com, yang.shi@linux.alibaba.com, asteinhauser@google.com, anshuman.khandual@arm.com, jan.kiszka@siemens.com, akpm@linux-foundation.org, steven.price@arm.com, rppt@linux.vnet.ibm.com, peterx@redhat.com, dan.j.williams@intel.com, arjunroy@google.com, logang@deltatee.com, thellstrom@vmware.com, aarcange@redhat.com, justin.he@arm.com, robin.murphy@arm.com, ira.weiny@intel.com, keescook@chromium.org, jgross@suse.com, andrew.cooper3@citrix.com, pawan.kumar.gupta@linux.intel.com, fenghua.yu@intel.com, vineela.tummalapalli@intel.com, yamada.masahiro@socionext.com, sam@ravnborg.org, acme@redhat.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org References: <158880240546.11615.2219410169137148044.stgit@naples-babu.amd.com> <158880253347.11615.8499618616856685179.stgit@naples-babu.amd.com> <4d86b207-77af-dc5d-88a4-f092be0043f6@intel.com> <20200507072934.d5l6cpqyy54lrrla@linutronix.de> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: <034cfb90-7f75-8e36-5b1e-ceaef0dfa50d@intel.com> Date: Thu, 7 May 2020 07:44:44 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200507072934.d5l6cpqyy54lrrla@linutronix.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/7/20 12:29 AM, Sebastian Andrzej Siewior wrote: >>> -config X86_INTEL_MEMORY_PROTECTION_KEYS >>> - prompt "Intel Memory Protection Keys" >>> +config X86_MEMORY_PROTECTION_KEYS >>> + prompt "Memory Protection Keys" >>> def_bool y >>> # Note: only available in 64-bit mode >>> - depends on CPU_SUP_INTEL && X86_64 >>> + depends on X86_64 && (CPU_SUP_INTEL || CPU_SUP_AMD) >>> select ARCH_USES_HIGH_VMA_FLAGS >>> select ARCH_HAS_PKEYS >>> ---help--- >> It's a bit of a bummer that we're going to prompt everybody doing >> oldconfig's for this new option. But, I don't know any way for Kconfig >> to suppress it if the name is changed. Also, I guess the def_bool=y >> means that menuconfig and olddefconfig will tend to do the right thing. > You could add a new option (X86_MEMORY_PROTECTION_KEYS) which is > def_bool X86_INTEL_MEMORY_PROTECTION_KEYS and avoiding the prompt line. > Soo it is selected based on the old option and the user isn't bother. A > few cycles later you could remove intel option and add prompt to other. > But still little work for… That does sound viable, if we decide it's all worth it. So, for now my preference would be to change the prompt, but leave the CONFIG_ naming in place. If we decide that transitioning the config is the right thing (I don't feel super strongly either way), let's use Sebastian's trick to avoid the Kconfig prompts.