Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Alexandre Chartre <alexandre.chartre@oracle.com>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [patch V4 part 2 05/18] x86/entry: Move irq tracing on syscall entry to C-code
In-Reply-To: <87sggbj0ok.fsf@nanos.tec.linutronix.de>
References: <20200505134112.272268764@linutronix.de> <20200505134340.611961721@linutronix.de> <207acd23-4acb-3fd1-7c92-9f48c79fa059@oracle.com> <87sggbj0ok.fsf@nanos.tec.linutronix.de>
Date:   Thu, 07 May 2020 17:03:59 +0200
Message-ID: <87368bg528.fsf@nanos.tec.linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Thomas Gleixner <tglx@linutronix.de> writes:
> Alexandre Chartre <alexandre.chartre@oracle.com> writes:
>> On 5/5/20 3:41 PM, Thomas Gleixner wrote:
>>> -	/*
>>> -	 * User mode is traced as though IRQs are on, and the interrupt
>>> -	 * gate turned them off.
>>> -	 */
>>> -	TRACE_IRQS_OFF
>>> -
>>>   	movq	%rsp, %rdi
>>>   	call	do_int80_syscall_32
>>>   .Lsyscall_32_done:
>>> 
>>
>> enter_from_user_mode() is also called with the CALL_enter_from_user_mode macro,
>> which is used in interrupt_entry() and identry. Don't you need to also remove
>> the TRACE_IRQS_OFF there now?
>
> Hrm. right. OTOH, it's just redundant and should be no harm, but let me have a
> look at that again.

Grr, no. It'll trigger the warnon when context tracking is enabled. /me
scratches head and goes to fix.