Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH next] ARM: dts: am437x: fix networking on boards with
 ksz9031 phy
To:     Oleksij Rempel <o.rempel@pengutronix.de>
CC:     Tony Lindgren <tony@atomide.com>,
        "David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>,
        Andrew Lunn <andrew@lunn.ch>,
        Philippe Schenker <philippe.schenker@toradex.com>
References: <20200506190835.31342-1-grygorii.strashko@ti.com>
 <20200507044056.4smicagmxve5yshn@pengutronix.de>
From:   Grygorii Strashko <grygorii.strashko@ti.com>
Message-ID: <7c36e45f-5617-22dd-d1cf-7a2558aac459@ti.com>
Date:   Thu, 7 May 2020 18:13:24 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <20200507044056.4smicagmxve5yshn@pengutronix.de>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 07/05/2020 07:40, Oleksij Rempel wrote:
> Hi Grygorii,
> 
> thank you for you patches!
> 
> On Wed, May 06, 2020 at 10:08:35PM +0300, Grygorii Strashko wrote:
>> Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the
>> KSZ9031 PHY") the networking is broken on boards:
>>   am437x-gp-evm
>>   am437x-sk-evm
>>   am437x-idk-evm
>>
>> All above boards have phy-mode = "rgmii" and this is worked before, because
>> KSZ9031 PHY started with default RGMII internal delays configuration (TX
>> off, RX on 1.2 ns) and MAC provided TX delay. After above commit, the
>> KSZ9031 PHY starts handling phy mode properly and disables RX delay, as
>> result networking is become broken.
>>
>> Fix it by switching to phy-mode = "rgmii-rxid" to reflect previous
>> behavior.
>>
>> Cc: Oleksij Rempel <o.rempel@pengutronix.de>
>> Cc: Andrew Lunn <andrew@lunn.ch>
>> Cc: Philippe Schenker <philippe.schenker@toradex.com>
>> Fixes: commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY")
>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>> ---
>>   arch/arm/boot/dts/am437x-gp-evm.dts  | 2 +-
>>   arch/arm/boot/dts/am437x-idk-evm.dts | 2 +-
>>   arch/arm/boot/dts/am437x-sk-evm.dts  | 4 ++--
>>   3 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm.dts
>> index 811c8cae315b..d692e3b2812a 100644
>> --- a/arch/arm/boot/dts/am437x-gp-evm.dts
>> +++ b/arch/arm/boot/dts/am437x-gp-evm.dts
>> @@ -943,7 +943,7 @@
>>   
>>   &cpsw_emac0 {
>>   	phy-handle = <&ethphy0>;
>> -	phy-mode = "rgmii";
>> +	phy-mode = "rgmii-rxid";
>>   };
>>   
>>   &elm {
>> diff --git a/arch/arm/boot/dts/am437x-idk-evm.dts b/arch/arm/boot/dts/am437x-idk-evm.dts
>> index 9f66f96d09c9..a7495fb364bf 100644
>> --- a/arch/arm/boot/dts/am437x-idk-evm.dts
>> +++ b/arch/arm/boot/dts/am437x-idk-evm.dts
>> @@ -504,7 +504,7 @@
>>   
>>   &cpsw_emac0 {
>>   	phy-handle = <&ethphy0>;
>> -	phy-mode = "rgmii";
>> +	phy-mode = "rgmii-id";
>>   };
> 
> Do you have here really rgmii-id?
> 

Right, thanks you.

-- 
Best regards,
grygorii