Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp816890ybj; Thu, 7 May 2020 08:16:39 -0700 (PDT) X-Google-Smtp-Source: APiQypJKPkbVI99ocaBSamhdaAATVSRof9LN1bYtbxR/AlMD7Xi9pENy8i1k1iOQ2hUfAnN8gtpC X-Received: by 2002:a17:906:148d:: with SMTP id x13mr1690843ejc.152.1588864598864; Thu, 07 May 2020 08:16:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588864598; cv=none; d=google.com; s=arc-20160816; b=sjrvzjrk636N/DDuMj0eYrnYysBkcfQhevF6Vb+dA0q/hkCYiCzbgMZ95ITaIi8Km7 QlPBJbZzzP6mPwduGNaOkxX2euzRucV0XADKA2+5f4qjjT3MZz+fSqBA1cLDMmSC2D4t aTPi6zT43wnfAx/fc+rQZFPLuGlyovSjOO9Z4hIV9j8jATgqdG32mSiMD1rs7zuOaMvF Po44m7c88eyi5dnd+TW44HkcdHb4pdsjv/ICUFXTS5aRx7MCay+6hsPSwMgJhI7fFsCl AaEspkwXlUxJcoLATSRupcBzdkwxnnFwyqBFeNQOp4vzODLjjGSs23laltW5Xen5auM7 V+zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:content-transfer-encoding:mime-version :message-id:date:subject:cc:from:dkim-signature; bh=wCNfAcxLHirtWhA7szQNX73G2LCH8rXx5QD9p4rA8Dk=; b=WFAm98VvPCbBSr4GgaU43cX0mXjoOvJTgd71wr3qv3dn1C4y35NX4MwMTHX8q+4QrP G28xRUHLKEazIfFpEBBojbZ2mo8kHXcSBjdLgh+LLl1RRwuwUJcWGc+fQn0h6TWA5mIf Wxiy1WKBiitBH/cuMXYOvi/h/81d2dPV20Nd2Po4cF5ikdiv5pLzLDmEhYaBjH9dY8/2 u6f69iqzzEVeGBdD6E51nBni7RFNS6ElDZuapjQ2rEiLOIl9htCo81v2q/lmM5IkwnIe gEBWAKKSt/sF5pbLFgWTL9eOVqgPgFYYu8SeRHTu8xqw7LL8wWiny3PNx6MCFmcQ2NBU paZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=fnItiLad; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dd22si3104866edb.162.2020.05.07.08.16.12; Thu, 07 May 2020 08:16:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=fnItiLad; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728143AbgEGPNx (ORCPT + 99 others); Thu, 7 May 2020 11:13:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727778AbgEGPNw (ORCPT ); Thu, 7 May 2020 11:13:52 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5C59C05BD43; Thu, 7 May 2020 08:13:52 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id 18so3133509pfv.8; Thu, 07 May 2020 08:13:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=wCNfAcxLHirtWhA7szQNX73G2LCH8rXx5QD9p4rA8Dk=; b=fnItiLadgw6gVujkCLGxeMWnUOu819/tIkaEKowyFt2g/Nn5mUHkALPznXH/TNOJ79 yWdwyURQZlI5T5wZROAv2M29GKPJTD4oUIlR9Ok5e0xh2scXtpiqYk2ZZOlgncX/KnCF a66SYwlNiFizvPuObtEK4h/OXk1dGLhnzVd8zIrpbccuHyqFthc9h3dcasHhv2Jkhphi VgOJXrMFGryLIG39lrJIdtXZf42cY/GDJgUYxFN+VUTWPgBdTBg0ge0Izm2wQvq2Hb5R mPAzY+dbzTO5NnUosx31byzGn1LXlAiN8iDlwoUX0injGUVcIUHfU+XrPHvV3Lk+ucmu JIdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=wCNfAcxLHirtWhA7szQNX73G2LCH8rXx5QD9p4rA8Dk=; b=ZbuVrk0lfx11DkBQaBnNQILnO8NJEMZEqfDKgPGHlppZtWjt1eiLuHQUxE+5YxUUbj wZM885am+YdcFVvmNyQ4YCGk2K6S0aXnq/Q28mR2oXpk0MYiNYnRmeyRaqduk4Ubrr1w jmsc4Yf4UHBvyxPTLVREloQUUma5vTLcSQ/tLfgtf4PUcwqZMM/h1R1bhBFcmBARGojt u147TsgMD7Q8z3UwjSE9N97Tfv8RJlp0qyCbYwzWR+feNZS8UE97D3+zQWbTBqU2ivjA rwoV8PfHowLxxYaFg9lmof20RtphNJTOQ0f/NfyYCxKMgpDgumqiETdT1FQUY0l7ZcsF rmlA== X-Gm-Message-State: AGi0PuZJIoiHxSYYRDk1G8F75UFHb+Z6OB6YijlJTcOONKv6ojWCqeju o4gTAohAsA1Bk8SfqEzYLD0= X-Received: by 2002:aa7:8f26:: with SMTP id y6mr14474231pfr.36.1588864432467; Thu, 07 May 2020 08:13:52 -0700 (PDT) Received: from suzukaze.ipads-lab.se.sjtu.edu.cn ([202.120.40.82]) by smtp.gmail.com with ESMTPSA id d2sm5118326pfa.164.2020.05.07.08.13.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2020 08:13:51 -0700 (PDT) From: Chuhong Yuan Cc: "K . Y . Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Greg Kroah-Hartman , linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, Chuhong Yuan Subject: [PATCH] uio_hv_generic: add missed sysfs_remove_bin_file Date: Thu, 7 May 2020 23:13:43 +0800 Message-Id: <20200507151343.792816-1-hslester96@gmail.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This driver calls sysfs_create_bin_file() in probe, but forgets to call sysfs_remove_bin_file() in remove. Add the missed call to fix it. Signed-off-by: Chuhong Yuan --- drivers/uio/uio_hv_generic.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/uio/uio_hv_generic.c b/drivers/uio/uio_hv_generic.c index 3c5169eb23f5..4dae2320b103 100644 --- a/drivers/uio/uio_hv_generic.c +++ b/drivers/uio/uio_hv_generic.c @@ -361,6 +361,7 @@ hv_uio_remove(struct hv_device *dev) if (!pdata) return 0; + sysfs_remove_bin_file(&dev->channel->kobj, &ring_buffer_bin_attr); uio_unregister_device(&pdata->info); hv_uio_cleanup(dev, pdata); hv_set_drvdata(dev, NULL); -- 2.26.2