Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <1588864628.5685.78.camel@linux.ibm.com>
Subject: Re: [RFC][PATCH 1/3] evm: Move hooks outside LSM infrastructure
From:   Mimi Zohar <zohar@linux.ibm.com>
To:     Roberto Sassu <roberto.sassu@huawei.com>,
        "david.safford@gmail.com" <david.safford@gmail.com>,
        "viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
        "jmorris@namei.org" <jmorris@namei.org>,
        John Johansen <john.johansen@canonical.com>
Cc:     "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        "linux-integrity@vger.kernel.org" <linux-integrity@vger.kernel.org>,
        "linux-security-module@vger.kernel.org" 
        <linux-security-module@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Silviu Vlasceanu <Silviu.Vlasceanu@huawei.com>
Date:   Thu, 07 May 2020 11:17:08 -0400
In-Reply-To: <ab879f9e66874736a40e9c566cadc272@huawei.com>
References: <20200429073935.11913-1-roberto.sassu@huawei.com>
         <1588794293.4624.21.camel@linux.ibm.com>
         <1588799408.4624.28.camel@linux.ibm.com>
         <ab879f9e66874736a40e9c566cadc272@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 2020-05-07 at 07:53 +0000, Roberto Sassu wrote:
> > -----Original Message-----
> > From: Mimi Zohar [mailto:zohar@linux.ibm.com]
> > Sent: Wednesday, May 6, 2020 11:10 PM
> > To: Roberto Sassu <roberto.sassu@huawei.com>; david.safford@gmail.com;
> > viro@zeniv.linux.org.uk; jmorris@namei.org; John Johansen
> > <john.johansen@canonical.com>
> > Cc: linux-fsdevel@vger.kernel.org; linux-integrity@vger.kernel.org; linux-
> > security-module@vger.kernel.org; linux-kernel@vger.kernel.org; Silviu
> > Vlasceanu <Silviu.Vlasceanu@huawei.com>
> > Subject: Re: [RFC][PATCH 1/3] evm: Move hooks outside LSM infrastructure

Roberto, please fix your mailer or at least manually remove this sort
of info from the email.

> > 
> > On Wed, 2020-05-06 at 15:44 -0400, Mimi Zohar wrote:
> > > Since copying the EVM HMAC or original signature isn't applicable, I
> > > would prefer exploring an EVM portable and immutable signature only
> > > solution.
> > 
> > To prevent copying the EVM xattr, we added "security.evm" to
> > /etc/xattr.conf.  To support copying just the EVM portable and
> > immutable signatures will require a different solution.
> 
> This patch set removes the need for ignoring security.evm. It can be always
> copied, even if it is an HMAC. EVM will update it only when verification in
> the pre hook is successful. Combined with the ability of protecting a subset
> of files without introducing an EVM policy, these advantages seem to
> outweigh the effort necessary to make the switch.

As the EVM file HMAC and original signature contain inode specific
information (eg. i_version, i_generation), these xattrs cannot ever be
copied.  The proposed change is in order to support just the new EVM
signatures.

At least IMA file hashes should always be used in conjunction with
EVM.  EVM xattrs should always require a security.ima xattr to bind
the file metadata to the file data.  The IMA and EVM policies really
need to be in sync.

Mimi