Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp840468ybj; Thu, 7 May 2020 08:47:50 -0700 (PDT) X-Google-Smtp-Source: APiQypJhm6uA9ZEFO4by/87RQaWARZYchtPTN6QwxoorPqAkHrRbpWlAt51mkDzYNlHLNL3IxrZb X-Received: by 2002:a05:6402:221b:: with SMTP id cq27mr13041824edb.65.1588866470449; Thu, 07 May 2020 08:47:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588866470; cv=none; d=google.com; s=arc-20160816; b=MxdVJXfVH11jrFG5juamH/P20MxLPHj1BRVvoRNQNxrRXRHelPIiTAWEc+tfezwgqr 3Dctho/9TEWdJ4zTmrmx/a7sVXy3G+4IanxP/6qFMLmz1sOtI7RrQ29orK+5+bbB0CWi aJei9nNWQNhRNBI3Yvv2XSNXLnbk+GHZqpMxBrghOkG+sWKoHUIRrRxim99nlr7ZNotX njzosHkCadg27XJ1qdsjj8LheBlmFjkgEdPSI72pJW+TOIq8NbSFkwsCtfSaXclceRph aGAFsnUHHM5HG0nUESjHR/a9qbEwfrAziOzIA6XU3hWpv2kSMeYTj+nvEbHsEtENsdJj M8nQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=rr00nOov8uojkmqhFTd5VuStAl8J9JhvttiIuCPX7p8=; b=yGUuk6noaRggScIBnQNSlE9L2BJWcxzNcicWIMcHQhyZ34LNub7X31l0J0bzDkQhrx irWEVDBC4srVemByueg92Gp0FdTLcg0Y2Pdv/y573AdWTKMWkdyUEKsxZYPKxnKQRrk8 oYNAQJaquTyqhufXFQbEWEkoiG6ZeJNoIVhHuxpR+/2htRsJumYfXD+qLJKzFHmOi5A4 i1dUkp+uOAkdFQtrlUfyAqf1FgfAXl6vl8+II/UrAvXBa8X6n/R+islb0I+Zgju9ypfH CpqBbZqtOgEMkYHutSM8iJLjvd0/BMtBcacWjZRIzm8vxxl8da1odA9+UuUv+RyjuAhA O2PQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j22si3265931ejm.490.2020.05.07.08.47.24; Thu, 07 May 2020 08:47:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726963AbgEGPp6 (ORCPT + 99 others); Thu, 7 May 2020 11:45:58 -0400 Received: from verein.lst.de ([213.95.11.211]:47463 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725914AbgEGPp5 (ORCPT ); Thu, 7 May 2020 11:45:57 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id F2D2D68B05; Thu, 7 May 2020 17:45:54 +0200 (CEST) Date: Thu, 7 May 2020 17:45:54 +0200 From: Christoph Hellwig To: Stefan Haberland Cc: Christoph Hellwig , axboe@kernel.dk, linux-block@vger.kernel.org, hoeppner@linux.ibm.com, linux-s390@vger.kernel.org, heiko.carstens@de.ibm.com, gor@linux.ibm.com, borntraeger@de.ibm.com, linux-kernel@vger.kernel.org, Peter Oberparleiter Subject: Re: [PATCH 1/1] s390/dasd: remove ioctl_by_bdev from DASD driver Message-ID: <20200507154554.GA32006@lst.de> References: <20200430111754.98508-2-sth@linux.ibm.com> <20200430131351.GA24813@lst.de> <4ab11558-9f2b-02ee-d191-c9a5cc38de0f@linux.ibm.com> <70f541fe-a678-8952-0753-32707d21e337@linux.ibm.com> <20200505124423.GA26313@lst.de> <20200506045258.GB9846@lst.de> <10918cd1-a4a9-7872-9672-efcd28ef0751@linux.ibm.com> <20200507152906.GA31257@lst.de> <35ee027b-7892-23ab-c31d-7c17750da8f4@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <35ee027b-7892-23ab-c31d-7c17750da8f4@linux.ibm.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 07, 2020 at 05:43:40PM +0200, Stefan Haberland wrote: > Not checked till now. I just was thinking about the basicapproach. > > I could either check the block_device_operations like you suggested > or I could verify that the gendisk pointer is already in our devmap > and therefor belongs to the DASD driver. The ops pointer check is simpler and cheaper, so I'd suggest that.