Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp851375ybj; Thu, 7 May 2020 09:02:59 -0700 (PDT) X-Google-Smtp-Source: APiQypLunczAGl769o8miN4Xw1v0BbzBi/CoDpPZ4s1IUi6vC54gq5ENKshTBwiKqSPV86GEy2GB X-Received: by 2002:a50:bb6b:: with SMTP id y98mr12243074ede.296.1588867378855; Thu, 07 May 2020 09:02:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588867378; cv=none; d=google.com; s=arc-20160816; b=FRmQPTwrlHSLDkWWDDPPwUf7x77KQC2e58af9j+Ky2QlUNo8BxoShkZojEuceeeBWZ oh5zIDBBjjgWwy6oLg9FItabRkd/neiyNkPc6q5c6zMW+YUTyX2Nn3jX0KY94QZpONHQ wkLCIpbrynPtQDxPUf0aitmEPvviFsvNufppdoGfoRyYHgjFYaWDPm9tb9z/PUdYpiMC 8dSWMq74qMeRzUhbHo5BasonNt4bWohpUdYtclcn9Ghhi5cj5seSCIRHVdn98/9c6wUw EvfZkRzEwEQ0Z+sy2tVioCIV+egUh1CA3zfzE+GX8ceI3sxQLeolzgb9rBjqA20E8upD xc5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=M+aukI46ITULcG3EshDXWdNbff4ibEMytvpHcg1erw8=; b=sKaMW2FAEbcaXxe3NjLdSHVsBQJ3aMWdmJMnlbTLpnrXvuRoECwaRz0L4F7Rhx0Suw v/0DJm6/NW9oMb1D1OEJtp20S97VlSqiYwsJ0uKJOX4Hgfg4Q9qwXphL4jedP5b98gXA WL1JcxDi+5hMI3y9R7pP+yThkg+4wiNdfTexNGPvJNSr/nMESjFF/IAFEt3qrj7Ul7dN 0R1SNeuvupui9Xe8oBTaQFi12rOD5qly4Z5EC/gAfylCJ7ZNokaB5MnueYnYGxlXkbKU oe6nR+/lZeAR8Fj1ayR5gaaOdUAZSkUqN8qs7xyIIOLKescrEA3wppkLXTqZ3+uOxgTb VyGg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 62si3544605edc.448.2020.05.07.09.01.27; Thu, 07 May 2020 09:02:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727983AbgEGP6r (ORCPT + 99 others); Thu, 7 May 2020 11:58:47 -0400 Received: from www62.your-server.de ([213.133.104.62]:55438 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726029AbgEGP6r (ORCPT ); Thu, 7 May 2020 11:58:47 -0400 Received: from sslproxy06.your-server.de ([78.46.172.3]) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1jWiuH-0008Cw-Lt; Thu, 07 May 2020 17:57:53 +0200 Received: from [178.195.186.98] (helo=pc-9.home) by sslproxy06.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jWiuH-0008HP-1i; Thu, 07 May 2020 17:57:53 +0200 Subject: Re: [PATCH v2] bpf, i386: remove unneeded conversion to bool To: Martin KaFai Lau , Jason Yan Cc: davem@davemloft.net, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, udknight@gmail.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, ast@kernel.org, songliubraving@fb.com, yhs@fb.com, andriin@fb.com, john.fastabend@gmail.com, kpsingh@chromium.org, lukenels@cs.washington.edu, xi.wang@gmail.com, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200506140352.37154-1-yanaijie@huawei.com> <20200506220443.pmszq4jnfr2pcjp4@kafai-mbp> From: Daniel Borkmann Message-ID: <1f762d57-7439-37e4-1cfb-f53df6dd47d0@iogearbox.net> Date: Thu, 7 May 2020 17:57:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20200506220443.pmszq4jnfr2pcjp4@kafai-mbp> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.102.2/25805/Thu May 7 14:14:46 2020) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/7/20 12:04 AM, Martin KaFai Lau wrote: > On Wed, May 06, 2020 at 10:03:52PM +0800, Jason Yan wrote: >> The '==' expression itself is bool, no need to convert it to bool again. >> This fixes the following coccicheck warning: > Make sense. > > It may belong to bpf-next instead. > > Acked-by: Martin KaFai Lau Applied, thanks!