Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp873304ybj; Thu, 7 May 2020 09:30:56 -0700 (PDT) X-Google-Smtp-Source: APiQypKjyzXzzUuWcT4v2Q80Ric2kR9Zjn7HtHOyjisZTLcQ2A6jU3ag3s4D8+VlBI+jONt9W1x+ X-Received: by 2002:a50:b412:: with SMTP id b18mr12412320edh.42.1588869056387; Thu, 07 May 2020 09:30:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588869056; cv=none; d=google.com; s=arc-20160816; b=s6TKZnGzQ2oOLqNdRFBmEf+gNoeec9UUueaIiad+LiRlaPTKNyKbksyyT93DdBL8FE e6ywSBLALnGgjb5yZFm2cGRO+9NxQaMZVfmXgGd3aPLPZAi4dXI3oHJdWzAK/CbwEU9B piQruYBYeZJ3NbLtgvggKOEJynyZiLf5lIopbuxSvYoHZDCDxux8PiZC22/am5lMP80n bpb9CfhZGfCnzv5SYPxwPkXTPQTkjYU46qiO0iiI3xq5542r9oizwbxm9LAzQ8uYhggY oFn2FUoEfBNiC8El1ZhfFZ5DSTM5RULZNSRIpuHXfcNDKJ7WCb7BjbTr69LvaLAmocFr 8l7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=hNBQn8RGXkzuzyW94k1gEQbE5L42hMG3X4gJXxIKo1I=; b=0WIO3UIZm0DbltkffimX1iap+5Lwvamb6mrxwoxHJpnUyPXmrapLGI6KuKWf1GPYIP yKsOyFT7vgFT7Bob+pEqCUo0gmudUrmvCQAZVkDdJMQx8URt+czBiC5ayoLIYmjhKHue sh6+dtSaomTmntK+f0wkma1ohC9BB35Pq10aEWeLP3FvvSp9fhs8kW+L+lryspb5mk3T ZBU5P5tOavhiaz8GQAr7DegJLilanD+X+phngGwYHbjKeqrUiaH6Aoxlzvm93t9gNKin +cxZjov9XMLADUx2erlPozw1HqAMJi9eaM0NKory1dXCqvSm+d8E+AgsC3SZ00UBqryu XnPg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o59si3203709eda.39.2020.05.07.09.30.31; Thu, 07 May 2020 09:30:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727119AbgEGQ3I (ORCPT + 99 others); Thu, 7 May 2020 12:29:08 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:37996 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726495AbgEGQ3H (ORCPT ); Thu, 7 May 2020 12:29:07 -0400 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 047G1rQw037604; Thu, 7 May 2020 12:29:03 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 30twj0jmgd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 07 May 2020 12:29:02 -0400 Received: from m0098394.ppops.net (m0098394.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 047G2SNp041118; Thu, 7 May 2020 12:29:02 -0400 Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0a-001b2d01.pphosted.com with ESMTP id 30twj0jmg5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 07 May 2020 12:29:02 -0400 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id 047GQ2qp027014; Thu, 7 May 2020 16:29:01 GMT Received: from b01cxnp22035.gho.pok.ibm.com (b01cxnp22035.gho.pok.ibm.com [9.57.198.25]) by ppma01dal.us.ibm.com with ESMTP id 30s0g761dq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 07 May 2020 16:29:01 +0000 Received: from b01ledav001.gho.pok.ibm.com (b01ledav001.gho.pok.ibm.com [9.57.199.106]) by b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 047GT0ds46072128 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 7 May 2020 16:29:00 GMT Received: from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3235528059; Thu, 7 May 2020 16:29:00 +0000 (GMT) Received: from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F26E42805C; Thu, 7 May 2020 16:28:59 +0000 (GMT) Received: from localhost (unknown [9.65.234.211]) by b01ledav001.gho.pok.ibm.com (Postfix) with ESMTP; Thu, 7 May 2020 16:28:59 +0000 (GMT) From: "Paul A. Clarke" To: linux-perf-users@vger.kernel.org Cc: linux-kernel@vger.kernel.org, acme@kernel.org, ananth@linux.vnet.ibm.com, maddy@linux.vnet.ibm.com, naveen.n.rao@linux.vnet.ibm.com, sukadev@linux.ibm.com, mpe@ellerman.id.au, irogers@google.com Subject: [PATCH 1/2] perf: Fix POWER9 metric 'lsu_other_stall_cpi' Date: Thu, 7 May 2020 11:28:57 -0500 Message-Id: <1588868938-21933-2-git-send-email-pc@us.ibm.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1588868938-21933-1-git-send-email-pc@us.ibm.com> References: <1588868938-21933-1-git-send-email-pc@us.ibm.com> X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216,18.0.676 definitions=2020-05-07_10:2020-05-07,2020-05-07 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 priorityscore=1501 lowpriorityscore=0 bulkscore=0 spamscore=0 phishscore=0 malwarescore=0 impostorscore=0 suspectscore=1 mlxscore=0 clxscore=1015 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2005070125 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Paul A. Clarke" The metric definition is too long for the current value of EXPR_MAX_OTHER. Increase the value EXPR_MAX_OTHER sufficiently to allow 'lsu_other_stall_cpi' to build properly. Before: -- $ perf list | grep lsu_other lsu_other_stall_cpi # perf stat -a --metrics lsu_other_stall_cpi /bin/sleep 1 Cannot find metric or group `lsu_other_stall_cpi' Usage: perf stat [] [] -M, --metrics monitor specified metrics or metric groups (separated by ,) -- After: -- # perf stat -a --metrics lsu_other_stall_cpi /bin/sleep 1 Performance counter stats for 'system wide': 438,086,889 pm_cmplu_stall_lsu # 1.74 lsu_other_stall_cpi [...] -- Signed-off-by: Paul A. Clarke --- tools/perf/util/expr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/expr.h b/tools/perf/util/expr.h index 87d627bb699b..a0991959cca4 100644 --- a/tools/perf/util/expr.h +++ b/tools/perf/util/expr.h @@ -2,7 +2,7 @@ #ifndef PARSE_CTX_H #define PARSE_CTX_H 1 -#define EXPR_MAX_OTHER 20 +#define EXPR_MAX_OTHER 28 #define MAX_PARSE_ID EXPR_MAX_OTHER struct expr_parse_id { -- 2.18.2