Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp896944ybj; Thu, 7 May 2020 10:04:36 -0700 (PDT) X-Google-Smtp-Source: APiQypJPi1k3Z9sZtFgLHZH3Vfkj7y+dDdz7DKGio1lXHoBhhSkMGkWhTzKtK9vLGjqC2AUEwdup X-Received: by 2002:a05:6402:3125:: with SMTP id dd5mr13507705edb.208.1588871076611; Thu, 07 May 2020 10:04:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588871076; cv=none; d=google.com; s=arc-20160816; b=b+Us5BdWdT2j1+bLafpqnbIra5SNkY051JmqBvoj4pbbisPmDdWo4Rqy8FF9Zuu8lP rRsg/UVTKUgTSgpeFN0EksEW0QKBW9yoXlxkowPykvzY7mLWZWtzj1N0c0T07RUwtvqV MMvsyAUod2yilGTUMB2DYoaV0hS14CbKZjFCMf5h1ntS0gzBYhaZrvAGPW03iK50W1oA uac3PZK2Yt/sEXPZ4/NvfHIjERudStE6+N/BJ4/aZqGvybtT8xLBpJ/Wt3npQxvAFPB5 DdDrvcJ87QL4fbVoKKv0K8ALdFQv6siOenluyh0VWvuhH3DaQhS60OphHqvkgUdeYcPf EM3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=AogGO7KQ2cbQNwYsj968bylJ7TQTugwVFwFQ369LPww=; b=p3uFVxcwbRbWZqnhTI1LlbL7D984W8rgB3IZB9en8TXwHdrl435exmCs5anE1/N1uJ Ur6vS3cFVMNrPWbN3rP3IkRuekMVa00HIkWk/MwzyzVI5T4F4FQR3W4oDfRW3uuuBgud O3pCCNdNoGItz2WEn6Hwz6aGta8pETHriU076fYOogObQmselI3o9RM9xdOOE5TgzTNE A1eIqne76wylx8QHhuuGEOb9+VK42ioTiHGHB5WjO7y/cf+rQ7deGh2JehSUbQe3dAOd PpbEzDn7dZPTpsr9TFZSv0ufZD8SPKYsa2hE1FH1QsjfRGu0BcxaWVl5gR0KN53uOs// 39xQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=B9521p8G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ce9si3629058ejb.154.2020.05.07.10.04.11; Thu, 07 May 2020 10:04:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=B9521p8G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727993AbgEGRB4 (ORCPT + 99 others); Thu, 7 May 2020 13:01:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727978AbgEGRBz (ORCPT ); Thu, 7 May 2020 13:01:55 -0400 Received: from mail-qt1-x841.google.com (mail-qt1-x841.google.com [IPv6:2607:f8b0:4864:20::841]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37195C05BD43 for ; Thu, 7 May 2020 10:01:54 -0700 (PDT) Received: by mail-qt1-x841.google.com with SMTP id o10so5389942qtr.6 for ; Thu, 07 May 2020 10:01:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=AogGO7KQ2cbQNwYsj968bylJ7TQTugwVFwFQ369LPww=; b=B9521p8GGVcZpv1qM6GfYzouKvPp4grKwjYFaXKUDPG4zfEuTqq3geopKa9AL0tOb+ 5Mxtar2ygaAjvMyZDIRb0W9xvnacTchxTSMHI1tZPA2PbNDtQCUh8e9BQackKUrAvFvD K/r3KBj6JEFLxpFwhYYzgnUafXu+gr4v+lpgKsj9w51U75EBYUNEN5AEE+mpiXIoVLfX YUCLKWuxDU6umtMxIF3sS2wwRZWavK4GF7RBR78va/EV/Trd0n92xXmWZM15cG1YUCPE 447hhPafKpmEgEnBqlAtJlVO7nr1VcdIbXbeVCxKhZwsqhFlAFqrzadqLRKUS34zqkYz Sbkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=AogGO7KQ2cbQNwYsj968bylJ7TQTugwVFwFQ369LPww=; b=X5QitP8Uuma9AJaJRNPGjUfdkxO1RZ24iuPL6j9pCyk5RsVfwHda4I7pS0pkrkM4hS MiORGTziTrUQcDH1/HRk7FlopbQW9e1UB8zOqNa9bI6C95oj5SdEIRDxk9rXDwf3D7I5 T5K51KMVVQtUCZPc0FdkuF5HiTiUoiF1PFu9fBGSM7TJTpMK5E12SbczgA7Q6+s8J2FK 3U6BTkbI56FseifD1lhyMV5Wt8RDkeQbFPwdY2QSFFr6lEQjpT5Jr1nJM46iKBoL1Dc2 256ZNSdcys770NbiRWDsuMUlPqqN0T/P9f3KKd4CdO25KUVj3/TxrYRgTD/E7aWtxHWX aEzw== X-Gm-Message-State: AGi0PubR3+bVfTY2DkCgQ7FBUECQ3rsi9eBD8T43rw1KaHavb3C76OaX nUnqG8FERXsAwLV3ucT8niXoSi2DpoESdqYaKEqyvQ== X-Received: by 2002:ac8:568b:: with SMTP id h11mr15009985qta.197.1588870913354; Thu, 07 May 2020 10:01:53 -0700 (PDT) MIME-Version: 1.0 References: <20200505140231.16600-1-brgl@bgdev.pl> <20200505140231.16600-7-brgl@bgdev.pl> <1588844771.5921.27.camel@mtksdccf07> <20200507131645.GM208718@lunn.ch> In-Reply-To: <20200507131645.GM208718@lunn.ch> From: Bartosz Golaszewski Date: Thu, 7 May 2020 19:01:42 +0200 Message-ID: Subject: Re: [PATCH 06/11] net: ethernet: mtk-eth-mac: new driver To: Andrew Lunn Cc: "Mark-MC.Lee" , linux-devicetree , Felix Fietkau , Arnd Bergmann , netdev , Bartosz Golaszewski , Sean Wang , LKML , Fabien Parent , Rob Herring , linux-mediatek@lists.infradead.org, John Crispin , Matthias Brugger , Jakub Kicinski , "David S . Miller" , arm-soc Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org czw., 7 maj 2020 o 15:16 Andrew Lunn napisa=C5=82(a): > > On Thu, May 07, 2020 at 12:50:15PM +0200, Bartosz Golaszewski wrote: > > czw., 7 maj 2020 o 11:46 Mark-MC.Lee napisa= =C5=82(a): > > > > > > Hi Bartosz: > > > I think the naming of this driver and its Kconfig option is too gene= ric > > > that will confuse with current mediatek SoCs eth driver architecture(= for > > > all mt7xxx SoCs). > > > Since mtk_eth_mac.c is not a common MAC part for all mediatek SoC b= ut > > > only a specific eth driver for mt85xx, it will be more reasonable to > > > name it as mt85xx_eth.c and change NET_MEDIATEK_MAC to > > > NET_MEDIATEK_MT85XX. How do you think? > > > > > > > Hi Mark, > > > > I actually consulted this with MediaTek and the name is their idea. > > Many drivers in drivers/net/ethernet have very vague names. I guess > > this isn't a problem. > > They have vague names, but they tend to be not confusing. > > NET_MEDIATEK_MAC vs NET_MEDIATEK_SOC is confusing. > > I think the proposed name, mt85xx_eth.c and NET_MEDIATEK_MT85XX is > good. Or some variant on this, mt8xxx? > I've just verified with MediaTek that this IP will be used in future designs as well - even on ones that don't share the mt8* prefix. It doesn't really have a name though by itself. How much confusion can it cause anyway? People who want to compile this driver will know which one to choose, right? It's not like it's an i2c component shared across many board designs. Bart