Date: Thu, 9 Mar 2006 18:47:59 -0800
From: Andrew Morton <akpm@osdl.org>
To: Markus Gutschke <markus@google.com>
Cc: linux-kernel@vger.kernel.org, dkegel@google.com
Subject: Re: [PATCH 1/1] x86: Make _syscallX() macros compile in PIC mode on
 i386
Message-Id: <20060309184759.591e3551.akpm@osdl.org>
In-Reply-To: <4410BB32.1020905@google.com>
References: <4410BB32.1020905@google.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1031
Lines: 23

Markus Gutschke <markus@google.com> wrote:
>
> Gcc reserves %ebx when compiling position-independent-code on i386. This 
>  means, the _syscallX() macros in include/asm-i386/unistd.h will not 
>  compile. This patch is against 2.6.15.6 and adds a new set of macros 
>  which will be used in PIC mode. These macros take special care to 
>  preserve %ebx.

But we don't compile the kernel with -fpic...  We might want to, for kdump
convenience at some stage, perhaps.

If we do, it'd be better to simply replace those _syscallX functions with
versions which work in either mode, rather than having two versions.

The syscallX() macros are almost obsolete - it's preferred that code simply
include syscalls.h and call sys_foo() directly.  But there are a few
hard-to-convert places, iirc.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/