Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 7 May 2020 10:52:19 -0700
From:   Tony Lindgren <tony@atomide.com>
To:     Philippe Schenker <philippe.schenker@toradex.com>
Cc:     "davem@davemloft.net" <davem@davemloft.net>,
        "grygorii.strashko@ti.com" <grygorii.strashko@ti.com>,
        "o.rempel@pengutronix.de" <o.rempel@pengutronix.de>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
        "andrew@lunn.ch" <andrew@lunn.ch>
Subject: Re: [PATCH v2] ARM: dts: am437x: fix networking on boards with
 ksz9031 phy
Message-ID: <20200507175219.GX37466@atomide.com>
References: <20200507151244.24218-1-grygorii.strashko@ti.com>
 <91c1ba87f2dfa66e11681d2660782a2efce2615d.camel@toradex.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <91c1ba87f2dfa66e11681d2660782a2efce2615d.camel@toradex.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

* Philippe Schenker <philippe.schenker@toradex.com> [200507 15:17]:
> On Thu, 2020-05-07 at 18:12 +0300, Grygorii Strashko wrote:
> > Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for
> > the
> > KSZ9031 PHY") the networking is broken on boards:
> >  am437x-gp-evm
> >  am437x-sk-evm
> >  am437x-idk-evm
> > 
> > All above boards have phy-mode = "rgmii" and this is worked before,
> > because
> > KSZ9031 PHY started with default RGMII internal delays configuration
> > (TX
> > off, RX on 1.2 ns) and MAC provided TX delay. After above commit, the
> > KSZ9031 PHY starts handling phy mode properly and disables RX delay,
> > as
> > result networking is become broken.
> > 
> > Fix it by switching to phy-mode = "rgmii-rxid" to reflect previous
> > behavior.
> > 
> > Cc: Oleksij Rempel <o.rempel@pengutronix.de>
> > Cc: Andrew Lunn <andrew@lunn.ch>
> > Cc: Philippe Schenker <philippe.schenker@toradex.com>
> > Fixes: commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support
> > for the KSZ9031 PHY")
> > Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> 
> Reviewed-by: Philippe Schenker <philippe.schenker@toradex.com>

Thanks applying into fixes.

Tony