Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp955814ybj; Thu, 7 May 2020 11:20:03 -0700 (PDT) X-Google-Smtp-Source: APiQypIEzDK2xuZrQ2oqAnko9BltQGV94354Y7izXUPNMCb/4UKNCh00WVDzuc9S6RLMBRjidqLe X-Received: by 2002:aa7:ca45:: with SMTP id j5mr12530134edt.268.1588875603332; Thu, 07 May 2020 11:20:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588875603; cv=none; d=google.com; s=arc-20160816; b=i2HZlKcP+5A2hoP1hwzoxqj2EdeoQDUIVtBzN8Gpn7qsCXU2VurBhkpaS8rwCVfjvd rNSe61R6T0Lej/Cctorf35QiQ6YKwE2HudVokPE5Y+mwxgwyB4O9QoLqtzJQEhM5u2I1 pWQc7cTCtXGmzFQQ9NO4PgXl/uoXGMsJt/6gO/5K5H0BidtfSS9VBkfjHZsRCwIdYJSp RSJ4rfP4jkliDYXFfl7r8ucm2TLkRYMEQhiLgu8Fn3L2smah8Qsf0A2pr1B1iV6peOCA l7lCwjbl9m4vWfDGb0y4prl+bfSKJJZlGHX9DUI18LsRHFBawvNqE/u20onnYHX/wN9J keRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=Cr6L5NPGCJCn6sABly9dACbq1Nd5HEsx+2Hik/xO1bw=; b=jCYY1xHJBkaIm1UjeMee5sTZYzFommsTAKBCcCExA1uaOIRcAQvTbNuhqNDlkh/xWB 7K5jZrigLZnlykgNlJE+Lg3GpiBdZcmQLjHfZSyTEiich8sTLHpCW+A1Hzg7DRQdvk+D rdR5xmn99iHOWKwfaWJGcPEtzbqAedqmK9lpImN/4vzYOZtt0f6WmJARzk+JENFbKx2b qAWaloicg6BqxjkW5ej9U1Icg5JRmgBwYecuAxisgURMWCsC9yBJvhKB2xnWU1YSMzHY vLTH0iX1H03FUh96mXdRnuKlg8DXuqXCJjz4qeS1RRdm7vgr+DusqRCdF6jxr79Qla+x 3v0Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k26si3773873ejc.127.2020.05.07.11.19.39; Thu, 07 May 2020 11:20:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728056AbgEGSQT (ORCPT + 99 others); Thu, 7 May 2020 14:16:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:53606 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726467AbgEGSQT (ORCPT ); Thu, 7 May 2020 14:16:19 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2BEFE20735; Thu, 7 May 2020 18:16:18 +0000 (UTC) Date: Thu, 7 May 2020 14:16:16 -0400 From: Steven Rostedt To: Masami Hiramatsu Cc: Yunfeng Ye , , , Subject: Re: [PATCH] tools/bootconfig: fix resource leak in apply_xbc() Message-ID: <20200507141616.5fb38310@gandalf.local.home> In-Reply-To: <20200508005805.9ae13059958e36ce9ebdd5aa@kernel.org> References: <583a49c9-c27a-931d-e6c2-6f63a4b18bea@huawei.com> <20200508005647.dc6f79c0aeca041203af1d8d@kernel.org> <20200508005805.9ae13059958e36ce9ebdd5aa@kernel.org> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 8 May 2020 00:58:05 +0900 Masami Hiramatsu wrote: > On Fri, 8 May 2020 00:56:47 +0900 > Masami Hiramatsu wrote: > > > On Thu, 7 May 2020 17:23:36 +0800 > > Yunfeng Ye wrote: > > > > > The @data and @fd is leak in the error path of apply_xbc(), so this > > > patch fix it. > > > > Good catch! Thanks for fixing! > > > > Acked-by: Masami Hiramatsu > > > > Hi Steve, can you pick this up? Yeah. I can add it to my 'for-linus' queue. As it's just part of the tools directory, I can skip the full testing I run on my patches. -- Steve