Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 7 May 2020 12:29:33 -0700
From:   Dmitry Torokhov <dmitry.torokhov@gmail.com>
To:     ChenTao <chentao107@huawei.com>
Cc:     kstewart@linuxfoundation.org, tglx@linutronix.de,
        gregkh@linuxfoundation.org, allison@lohutok.net,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input/misc/drv260x: Remove a useless comparison
Message-ID: <20200507192933.GK89269@dtor-ws>
References: <20200507051617.212434-1-chentao107@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200507051617.212434-1-chentao107@huawei.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

On Thu, May 07, 2020 at 01:16:17PM +0800, ChenTao wrote:
> Fix the following warning:
> 
> 'mode' and 'library' are u32, they are never be negative,
> DRV260X_LRA_MODE and DRV260X_LIB_EMPTY are 0x00, the comparison
> is always false.


The fact that the symbolic names resolve to 0 is just a happenstance. We
should not be writing code based on concrete values in this case. I
wish we could tell the compiler to ignore this kind of cases, where we
want to test a range of values, and do not care about concrete numeric
bounds of said range.

> 
> drivers/input/misc/drv260x.c:478:20: warning:
> comparison of unsigned expression < 0 is always false [-Wtype-limits]
>   if (haptics->mode < DRV260X_LRA_MODE ||
> drivers/input/misc/drv260x.c:490:23: warning:
> comparison of unsigned expression < 0 is always false [-Wtype-limits]
>   if (haptics->library < DRV260X_LIB_EMPTY ||

Are we planning on enabling this warning in kernel by default?

Thanks.

-- 
Dmitry