Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200507091311.10898-1-bernard@vivo.com> <462b6a26-2c25-f83a-887e-6d3a30072e71@amd.com>
In-Reply-To: <462b6a26-2c25-f83a-887e-6d3a30072e71@amd.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Thu, 7 May 2020 15:30:18 -0400
Message-ID: <CADnq5_NfHc0FWCcANbKmDXCxF5BjcCMM6WzJzsZr=yTnhYwxJg@mail.gmail.com>
Subject: Re: [PATCH v2] drm/amd/amdgpu: cleanup coding style a bit
To:     =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Cc:     Bernard Zhao <bernard@vivo.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        "David (ChunMing) Zhou" <David1.Zhou@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Tom St Denis <tom.stdenis@amd.com>,
        Sam Ravnborg <sam@ravnborg.org>,
        Ori Messinger <Ori.Messinger@amd.com>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        LKML <linux-kernel@vger.kernel.org>, opensource.kernel@vivo.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, May 7, 2020 at 5:22 AM Christian K=C3=B6nig <christian.koenig@amd.c=
om> wrote:
>
> Am 07.05.20 um 11:13 schrieb Bernard Zhao:
> > There is DEVICE_ATTR mechanism in separate attribute define.
> > So this change is to use attr array, also use
> > sysfs_create_files in init function & sysfs_remove_files in
> > fini function.
> > This maybe make the code a bit readable.
> >
> > Signed-off-by: Bernard Zhao <bernard@vivo.com>
>
> Reviewed-by: Christian K=C3=B6nig <christian.koenig@amd.com>
>

Applied with a minor change to make the array const to fix the build.

Alex

> >
> > Changes since V1:
> > *Use DEVICE_ATTR mechanism
> >
> > Link for V1:
> > *https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Flo=
re.kernel.org%2Fpatchwork%2Fpatch%2F1228076%2F&amp;data=3D02%7C01%7Cchristi=
an.koenig%40amd.com%7C073b9043be5346b3c90c08d7f266e6fb%7C3dd8961fe4884e608e=
11a82d994e183d%7C0%7C0%7C637244396096735223&amp;sdata=3DPjFsYvmw2pvVisZ6TzM=
qOyoSr0m3DsFN%2F0q%2B%2FfBxACg%3D&amp;reserved=3D0
> > ---
> >   drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 43 ++++++-------------=
-
> >   1 file changed, 13 insertions(+), 30 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c b/drivers/gpu=
/drm/amd/amdgpu/amdgpu_vram_mgr.c
> > index 82a3299e53c0..57bbc70662ff 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c
> > @@ -148,6 +148,15 @@ static DEVICE_ATTR(mem_info_vis_vram_used, S_IRUGO=
,
> >   static DEVICE_ATTR(mem_info_vram_vendor, S_IRUGO,
> >                  amdgpu_mem_info_vram_vendor, NULL);
> >
> > +static struct attribute *amdgpu_vram_mgr_attributes[] =3D {
> > +     &dev_attr_mem_info_vram_total.attr,
> > +     &dev_attr_mem_info_vis_vram_total.attr,
> > +     &dev_attr_mem_info_vram_used.attr,
> > +     &dev_attr_mem_info_vis_vram_used.attr,
> > +     &dev_attr_mem_info_vram_vendor.attr,
> > +     NULL
> > +};
> > +
> >   /**
> >    * amdgpu_vram_mgr_init - init VRAM manager and DRM MM
> >    *
> > @@ -172,31 +181,9 @@ static int amdgpu_vram_mgr_init(struct ttm_mem_typ=
e_manager *man,
> >       man->priv =3D mgr;
> >
> >       /* Add the two VRAM-related sysfs files */
> > -     ret =3D device_create_file(adev->dev, &dev_attr_mem_info_vram_tot=
al);
> > -     if (ret) {
> > -             DRM_ERROR("Failed to create device file mem_info_vram_tot=
al\n");
> > -             return ret;
> > -     }
> > -     ret =3D device_create_file(adev->dev, &dev_attr_mem_info_vis_vram=
_total);
> > -     if (ret) {
> > -             DRM_ERROR("Failed to create device file mem_info_vis_vram=
_total\n");
> > -             return ret;
> > -     }
> > -     ret =3D device_create_file(adev->dev, &dev_attr_mem_info_vram_use=
d);
> > -     if (ret) {
> > -             DRM_ERROR("Failed to create device file mem_info_vram_use=
d\n");
> > -             return ret;
> > -     }
> > -     ret =3D device_create_file(adev->dev, &dev_attr_mem_info_vis_vram=
_used);
> > -     if (ret) {
> > -             DRM_ERROR("Failed to create device file mem_info_vis_vram=
_used\n");
> > -             return ret;
> > -     }
> > -     ret =3D device_create_file(adev->dev, &dev_attr_mem_info_vram_ven=
dor);
> > -     if (ret) {
> > -             DRM_ERROR("Failed to create device file mem_info_vram_ven=
dor\n");
> > -             return ret;
> > -     }
> > +     ret =3D sysfs_create_files(&adev->dev->kobj, amdgpu_vram_mgr_attr=
ibutes);
> > +     if (ret)
> > +             DRM_ERROR("Failed to register sysfs\n");
> >
> >       return 0;
> >   }
> > @@ -219,11 +206,7 @@ static int amdgpu_vram_mgr_fini(struct ttm_mem_typ=
e_manager *man)
> >       spin_unlock(&mgr->lock);
> >       kfree(mgr);
> >       man->priv =3D NULL;
> > -     device_remove_file(adev->dev, &dev_attr_mem_info_vram_total);
> > -     device_remove_file(adev->dev, &dev_attr_mem_info_vis_vram_total);
> > -     device_remove_file(adev->dev, &dev_attr_mem_info_vram_used);
> > -     device_remove_file(adev->dev, &dev_attr_mem_info_vis_vram_used);
> > -     device_remove_file(adev->dev, &dev_attr_mem_info_vram_vendor);
> > +     sysfs_remove_files(&adev->dev->kobj, amdgpu_vram_mgr_attributes);
> >       return 0;
> >   }
> >
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx