Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp1017199ybj; Thu, 7 May 2020 12:48:14 -0700 (PDT) X-Google-Smtp-Source: APiQypLZ+B4wNN8MyoF2hllF3X5kOKehqZe2VMEodx3lEoAl0X9Mlcu3BuUt7fBVi90fxcRhQnap X-Received: by 2002:a17:906:4dd6:: with SMTP id f22mr1901923ejw.181.1588880893795; Thu, 07 May 2020 12:48:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588880893; cv=none; d=google.com; s=arc-20160816; b=IRYiMjPMG9eF6EKEu251Co7CyMWLlI3/Zawg96DRCq9SOFvKRWQSXtWJ4lvgIT9TTu F6sFvun+29VLmdEPwTnuJ0ebDiSeQVAKNWL2xQlMCl2bX+QvkVMr28d+bVeq8+EnIv6r HrlFK2PkuG6Rogi0UOXoi19gV2FxSU+So3RiaPPE9ZF31se4Yrwyno8RNZPj8Auji9mf koXsYc8hrJgS/56fvGfTQfuYb5AavuBeLYTP/AM68rIdz+uKQVRUiQpY65zgXqPdcCds Sm4NUbRRE4B4Y7/dkjzqIhVfrvjIu6T0w9IhS9APAKGIwxIW+baW/VZgbBjBnb73atM9 +4XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=IbfxBGzYrCHzzfTqHU4rAuwYtieZW8IZ52DJWF9xsUo=; b=LcBN2qHBvZQdILzkDQmbmv/oP0wj/iNGc5L+fvMAQP0FmK5r2N3S/qTV/VwyAyqB8y wswJoyUU/CTk1HvC6D9nWGW/SlrC5XF3WHwM8TcnFzOiWhp+vcIhDjSdsgHbGOVyNoKE WiGcpyRcjO8INQo+puIg9Mxa+pkUCA4gEOuRsi6bMBNc/XBiZGyx6iZa2eCFIGmvZUOj 2EMkCpfMaTOxrSbzQ7v9vRUZDwIsatfEDFq4bL5Q5Xh6hyQ3mU2z+LmAw7qtv4hIOS6E lwUAJNOT1r+BKM0fF1LgpcUnNvKqmCeEh5u9NxTjfUdCTxBIEXvOxJ4gTi7reZ1re4OA rM6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Oe0PU5NZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g22si3975573ejr.228.2020.05.07.12.47.50; Thu, 07 May 2020 12:48:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Oe0PU5NZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728518AbgEGTpp (ORCPT + 99 others); Thu, 7 May 2020 15:45:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726326AbgEGTpo (ORCPT ); Thu, 7 May 2020 15:45:44 -0400 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 780C2C05BD43 for ; Thu, 7 May 2020 12:45:43 -0700 (PDT) Received: by mail-pl1-x642.google.com with SMTP id t7so2500149plr.0 for ; Thu, 07 May 2020 12:45:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=IbfxBGzYrCHzzfTqHU4rAuwYtieZW8IZ52DJWF9xsUo=; b=Oe0PU5NZ2azBtHLJKpX3ha1q5sVBZ4ZHO+l13jT6Erh0ACOWTwKch462jXBcFXyD24 s/knbIwKHieGmlCElrOSj0hDSdIyuGY9V7VyJlbqfYR/GtTzoLQNjVaFkcRQYiSY3Hh+ 93C47ECe6RAr7s+FMJPAHvDax6a3hMvgtnLag= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=IbfxBGzYrCHzzfTqHU4rAuwYtieZW8IZ52DJWF9xsUo=; b=ThnYoPMIazo/DS27Z65U4GnPZz+LFiiNUMVWrvUCjREAvrOV4mSRTR4fSiYcWaDVX5 kqlv/t0FVim4WZtmVYsA3vOT4UH0xS00QJ0Ju8KJCx5I15SDGLSBlJ1/hRt4547sFxiG tbQRQrseE4KYqFCFOgRgjwruNS4Wrj5T1mcX3lbpnhlalVfsGMMRf4tVMmu9eRGUYrNb W6ubUsHx9T3cjonf/6pYc7iEtQ8ojOX32v19MgGvR+hlzoJqUKD9zO0Rk+H/ADvDUS6Z 9rRPUSdsUya5e6KOqhX2RS2sjQTNUwV0D10Jd8gL40hKKqGdGiIuy/sCKeMfpZQqIEOO o5zg== X-Gm-Message-State: AGi0Puaun2ST0VqmArmjL9UzR50qxuygZH8sC3TcDNDsaTN7s16LzT7/ OvmAKv6wcRT9zirC6ENMGE6krg== X-Received: by 2002:a17:902:eed1:: with SMTP id h17mr14686969plb.312.1588880743038; Thu, 07 May 2020 12:45:43 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id l30sm536526pje.34.2020.05.07.12.45.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2020 12:45:42 -0700 (PDT) Date: Thu, 7 May 2020 12:45:40 -0700 From: Kees Cook To: WeiXiong Liao Cc: Anton Vorontsov , Colin Cross , Tony Luck , Jonathan Corbet , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Mauro Carvalho Chehab , Rob Herring , "David S. Miller" , Greg Kroah-Hartman , Jonathan Cameron , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Subject: Re: [PATCH v3 00/11] pstore: mtd: support crash log to block and mtd device Message-ID: <202005071244.AAD82F41F@keescook> References: <1585126506-18635-1-git-send-email-liaoweixiong@allwinnertech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1585126506-18635-1-git-send-email-liaoweixiong@allwinnertech.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 25, 2020 at 04:54:55PM +0800, WeiXiong Liao wrote: > [PATCH v3]: > 1. patch 1~10: a lot of improvements according to Kees Cook > including rename module, typo, reorder, rewrite document, bugs > and so on. > 2. patch 11: rename funtions of pstore/blk and update document. This is looking good. I'm going to update it for the recent max_reason series, and make some tweaks here and there and send out a v4 tomorrow to see what you think. Thanks for your patience! -- Kees Cook