Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp1024690ybj; Thu, 7 May 2020 13:00:47 -0700 (PDT) X-Google-Smtp-Source: APiQypI+szAQjZuLnOjv82jFez0jVrk33l9PTIi+uWTup+C2+4I+C//xHah9s+2BgIWLJvelcN+m X-Received: by 2002:a17:906:3f45:: with SMTP id f5mr14144366ejj.18.1588881647839; Thu, 07 May 2020 13:00:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588881647; cv=none; d=google.com; s=arc-20160816; b=nxfUwYQA2oQeOLZsP6VMbS4Vtqep0ImvffMPjHn/ucbRNpurio7HbWkBJ8qfG+cyKj VCAU9qHKIVxLuPqkLgdkPUWA+cYANaRCfyUlzKQRtdEVFPfrUdyrdRN/kZLFoqCHYzQ4 PDh7Yc525d5+BbSoDCB2ijpMPvAq0CJ9suhTiwesEwhYoGH4iT2siseLlmwfjCfL6vNl y+dngNQlA3cxSh/8EvoLWOOe3AhI7kdAl07H4UwbiFTUuZjc65C74e6ylwoEiphlHtFm bwuaGnaCee5FrNZCLtJXuA6tHCJJXYCheJmuF2vAJ6cS5RnY3mbzm1u1JX+DKGHPRTLY ZHkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=L1RSKgifzUEi7T/SOve5DzjCXzqvheNtMNmc5XJ2jTQ=; b=FhvCilVX7Q80P0xr8o+EKM4cwtVpBlRabzqvlRyvSdZRnygOCSssbz7PCwPP5QvcFc JCki+haY8UrQcUCu875FC87b4UxJIYNLahrKLdHJd3KrjcDCy5Rh9jojwIgIx2Thkura PWMRXXcDkmrioJbKtUpakjatw/ddeSmqq/iM+54l5RatyOW0ZfwlJJsu5lznsELfOGNd ULqAmWpHDKpvMVrrw+lSUHH7QVH92LCpYIJ9PrvQuSLpKJtArSqqGsVzyD2zCJFNpgnw gVMrhfGTUH8CbhcVY0HPnFc623Sp5VcanrhDqhO/l38X2eICyPzu5oYKD+QTANyHZTrf P5nA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id di22si3708276edb.427.2020.05.07.13.00.24; Thu, 07 May 2020 13:00:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728227AbgEGT6R (ORCPT + 99 others); Thu, 7 May 2020 15:58:17 -0400 Received: from asavdk4.altibox.net ([109.247.116.15]:42078 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726326AbgEGT6R (ORCPT ); Thu, 7 May 2020 15:58:17 -0400 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 32D9380520; Thu, 7 May 2020 21:58:14 +0200 (CEST) Date: Thu, 7 May 2020 21:58:12 +0200 From: Sam Ravnborg To: Konrad Dybcio Cc: Thierry Reding , David Airlie , Daniel Vetter , Rob Herring , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [v4 PATCH 0/2] Add support for ASUS Z00T TM5P5 NT35596 panel Message-ID: <20200507195812.GB17398@ravnborg.org> References: <20200506210957.344590-1-konradybcio@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200506210957.344590-1-konradybcio@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=MOBOZvRl c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=kj9zAlcOel0A:10 a=m4rRuWqDM7RkiSaC_YMA:9 a=CjuIK1q_8ugA:10 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Konrad. On Wed, May 06, 2020 at 11:09:54PM +0200, Konrad Dybcio wrote: > changes since v3: > - fix dt-bindings issue > > changes since v2: > - fix Kconfig indentation > > changes since v1: > - make `backlight_properties props` constant > - a couple of line breaks > - change name and compatible to reflect ASUS being the vendor > - remove a redundant TODO > > Konrad Dybcio (2): > drivers: drm: panel: Add ASUS TM5P5 NT35596 panel driver > dt-bindings: display: Document ASUS Z00T TM5P5 NT35596 panel > compatible Thanks, applied in the reverse order to have the binding before the driver. Fixed a few checkpatch warnings while applying. We use --strict for code in drivers/gpu/* Sam > > .../panel/asus,z00t-tm5p5-nt35596.yaml | 56 +++ > drivers/gpu/drm/panel/Kconfig | 10 + > drivers/gpu/drm/panel/Makefile | 1 + > .../drm/panel/panel-asus-z00t-tm5p5-n35596.c | 367 ++++++++++++++++++ > 4 files changed, 434 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/asus,z00t-tm5p5-nt35596.yaml > create mode 100644 drivers/gpu/drm/panel/panel-asus-z00t-tm5p5-n35596.c > > -- > 2.26.2