Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp1030351ybj; Thu, 7 May 2020 13:08:25 -0700 (PDT) X-Google-Smtp-Source: APiQypJ/Ah+cxdu4n8YKVGtd7LExfbXnYPmQaamGAYCO99TTraFeLG3WUuE4qmCi48nXD4l/8fEo X-Received: by 2002:a17:907:42d6:: with SMTP id ng6mr13493720ejb.265.1588882105389; Thu, 07 May 2020 13:08:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588882105; cv=none; d=google.com; s=arc-20160816; b=chiwLjz0vVh5TXtXLgxUbQ/xntrs1JhT/P5GzSC1viAqxd9lFYe//cLTN7xgMW2/x/ vGo8uZb3Z5jJxrMMjmLSEunhKUK69YrEoyCIoSvtJEG7y4eFHfKGLxGNCAwNpF/8lG33 1DCRie4fakUtI5ZSqS5YbZ8q6lciHp6wFnk2onK4lsd+dibBpXdlc+jbx3HSBQpRkR3A AJELb+XkAtDcYSCijhRtF+G2VCurX1S8HqkwESQJprMhXs17RP5f7fOXhmpHM6plul0m k6KbzdkV+WfWkHGr65K3JF9/gktuf+Srhv630qZ7WJAifO9woOYG1qJYP2Jxlk7Z3yxY s3xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=nLXfWNt4EId5bFDr8qN/QrF6yC/aB3banj1wABXH9Ec=; b=Kxt4YFCCKipXkOe4P8NrnY2OhWj5izDevJmZ7XISAlCf1Cm8xsUBt90n0GtOHfTpM0 p2DL3FzUWhCGZ/NCPKGASLthcRan3QKLOAx8BHIyhDlxQFTHG/gtx5md10Xf5+0Z9v3E N299JsxJjzSSC0vL3BUdoJrWFFJ/Xbpj+0CBpBSUFsg1ftPK95G78JmksHe6/Uu8nUnT i2+QEOUwPtPoxHTpX4ZLMiMu/jGRWTvBp0hjVrKfdxU17P409WA5ubNVCUi8g9FSPDj+ uE4i1KxHsBmZf3PLhUA30rfWIZKMJRfpMoReLkvKwIOeaGYyVAp8Qlqz/LMf2ajnPdtY iDDA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gj19si3888882ejb.297.2020.05.07.13.08.02; Thu, 07 May 2020 13:08:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728227AbgEGUGL (ORCPT + 99 others); Thu, 7 May 2020 16:06:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726491AbgEGUGL (ORCPT ); Thu, 7 May 2020 16:06:11 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79F81C05BD43; Thu, 7 May 2020 13:06:11 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 1FE9A119504E1; Thu, 7 May 2020 13:06:11 -0700 (PDT) Date: Thu, 07 May 2020 13:06:10 -0700 (PDT) Message-Id: <20200507.130610.2218488895332459354.davem@davemloft.net> To: Po.Liu@nxp.com Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, netdev@vger.kernel.org, dan.carpenter@oracle.com, claudiu.manoil@nxp.com Subject: Re: [net-next] net:enetc: bug fix for qos sfi operate space after freed From: David Miller In-Reply-To: <20200507105738.29961-1-Po.Liu@nxp.com> References: <20200507105738.29961-1-Po.Liu@nxp.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 07 May 2020 13:06:11 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Po Liu Date: Thu, 7 May 2020 18:57:38 +0800 > 'Dan Carpenter' reported: > This code frees "sfi" and then dereferences it on the next line: >> kfree(sfi); >> clear_bit(sfi->index, epsfp.psfp_sfi_bitmap); > > This "sfi->index" should be "index". > > Reported-by: Dan Carpenter > Signed-off-by: Po Liu Applied.