Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp1031225ybj; Thu, 7 May 2020 13:09:37 -0700 (PDT) X-Google-Smtp-Source: APiQypKuIFJmzJCryXEx4EdoQxStWMPSwu9GxavmCJhS5+145a5FV88kFluJMsnOmWXS96dLJENZ X-Received: by 2002:a05:6402:887:: with SMTP id e7mr14095726edy.178.1588882177086; Thu, 07 May 2020 13:09:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588882177; cv=none; d=google.com; s=arc-20160816; b=DLQSQLbtLmvfE+B3r/v0F6gaFf6djZ9QTRsMFbmOxunbRZ00TLsA9DR2LuZOp/iYOI //BbuBDYUSvo1JgQEbPNy1KSBtt46AiZGJZz/9u0aVWuYDawkXkpFWqOZA6LV3mF5JJc teLKvh42OV8TpiMmhWjru+jJWdy9iQTyPzEwY4qwx6oZqs8bRr+JJd6eD6stl4O9p5Gp 28ryxK9ObT1GC+OzXzmQXJy2/eP4aG0KEStWZad2nWKmNP3Cx5b9jX6CjeAaL2gHYlU5 cXXpy7dtL+3RNHCWk+nN4gCXBl0wO/vIreQrMZ+3ASzJ5XiBYZWTviab6T0E34keGuT0 wgIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=dnJf/GTHdpYU7s4rsc6kjfrSGwgCWWXDsnoEEg1X6ws=; b=JWOjs8M+jNWIhoOk+adHWy+1v+/7KiZqJuaiKk0RS8vUZp9ufVOB4BhzilyqVFc1YI IlEqReGNQCkYDxtHdMZnE1dgL3+VHpRpSD7KaiY6c4rmk+tK1Mz2moMb95kCh9Kb6aEm OMmS/r37Oxtv1Ts4rnDLwnpiUwqrIU2JhNWIik8eRsH2liSEPd4NEESBUB2eS2TYw5I+ cI/8gS9yhMG6nGaAHAJwuHoVb7+JiBk2ioS99W5kGZ5pAVm8e2xXMqbI92MdzVi+fS11 J0MdSr9LAAgPBCesO04/Jl1jNJfg8XgTSD9KEn5RLHeCzoGJvRVVG1pe6AzzfSxejFiS PwDw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n20si3910076edo.531.2020.05.07.13.09.13; Thu, 07 May 2020 13:09:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728660AbgEGUEy (ORCPT + 99 others); Thu, 7 May 2020 16:04:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1728629AbgEGUEu (ORCPT ); Thu, 7 May 2020 16:04:50 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6BD88C05BD43; Thu, 7 May 2020 13:04:50 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 2CE7B1195077F; Thu, 7 May 2020 13:04:50 -0700 (PDT) Date: Thu, 07 May 2020 13:04:49 -0700 (PDT) Message-Id: <20200507.130449.2112285936469831023.davem@davemloft.net> To: yanaijie@huawei.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] net: encx24j600: make encx24j600_hw_init() return void From: David Miller In-Reply-To: <20200507110905.38211-1-yanaijie@huawei.com> References: <20200507110905.38211-1-yanaijie@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 07 May 2020 13:04:50 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jason Yan Date: Thu, 7 May 2020 19:09:05 +0800 > This function always return 0 now, we can make it return void to > simplify the code. This fixes the following coccicheck warning: > > drivers/net/ethernet/microchip/encx24j600.c:609:5-8: Unneeded variable: > "ret". Return "0" on line 653 > > Signed-off-by: Jason Yan Applied.