Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp1039692ybj; Thu, 7 May 2020 13:22:14 -0700 (PDT) X-Google-Smtp-Source: APiQypLZjSyHo+3zKSVyuw/f1sMMw0HZOSuwcXkpg2qL+f0ziThsJkp8P3/zlCT8jK3Jh2Wg8eHS X-Received: by 2002:a17:906:4f03:: with SMTP id t3mr13456915eju.254.1588882934031; Thu, 07 May 2020 13:22:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588882934; cv=none; d=google.com; s=arc-20160816; b=Id3ZP/hlCdp1gx+OJi7mNSk5YuSyqXSjpcU6QYHHwr+aRkui45e6h5Dx2zSOwlhKeS ggl5tWODhXAUeefXnan0czfbBsMzwMVFhzSVUrIltkz6bbXwysdyGqDd3bmXqq6v1ho2 vYqqKRP7cQen2Yz/SyBl9seeHEY8Ps3ffrfnGaIZJFbot9l4Fu1m9OFXiftDFZ4/PUhF eAEBFBoNVB/KLFU3ArbNcSJ0aNmJUGpZo2ukTykQjojzTd+wwWT5VXuuB24/BeGHRaz+ sZAgKOA77KDfytOFcbqK0/VxdGhdPwNnUOFF+l1EalUSj/MVu68xrqpV7Y04rGC32yH9 W+zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=lmlvlx4k2qq71CQ70f5I610PdFj1qudcCCoKuhEp/xA=; b=wfbD72KPpZ6oo0gAZdjCv04Fi3VwaaksUy3cJ7HgIILjqs4ej9loV3CPI5me5d8O1W n4YpR0iPFOBFPuUx/B3r2b+2mJUW3BdOvwiNtjytdlCvno/Xa+Rw4ZpYvX53ETxMrFMV 1r6zgYyshmeYGRDkaaupyFZsSmlHbP2hH4z/tydmf/vXQ+jqSKJPfzwluWQ2wH2xm80U jBTUv8wwH4Bf9aqFGzJKiCVr509EuD78fw8/f29/K3VC52giM4Y4nuAc4Mss8aXapIhD zSw6bADIaGnj9MxiP2sNXGjiZ8JEc7MvvAz8k9b9u5nPP/jYnGLd4eeItVy3SdCItMsE ocww== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dc9si3895974ejb.503.2020.05.07.13.21.50; Thu, 07 May 2020 13:22:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728433AbgEGUSf (ORCPT + 99 others); Thu, 7 May 2020 16:18:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726320AbgEGUSf (ORCPT ); Thu, 7 May 2020 16:18:35 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19781C05BD43; Thu, 7 May 2020 13:18:35 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 9E68C1195050E; Thu, 7 May 2020 13:18:34 -0700 (PDT) Date: Thu, 07 May 2020 13:18:34 -0700 (PDT) Message-Id: <20200507.131834.1517984934609648952.davem@davemloft.net> To: tangbin@cmss.chinamobile.com Cc: saeedm@mellanox.com, leon@kernel.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, zhangshengju@cmss.chinamobile.com Subject: Re: [PATCH] net/mlx5e: Use IS_ERR() to check and simplify code From: David Miller In-Reply-To: <20200507115010.10380-1-tangbin@cmss.chinamobile.com> References: <20200507115010.10380-1-tangbin@cmss.chinamobile.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 07 May 2020 13:18:34 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tang Bin Date: Thu, 7 May 2020 19:50:10 +0800 > Use IS_ERR() and PTR_ERR() instead of PTR_ZRR_OR_ZERO() > to simplify code, avoid redundant judgements. > > Signed-off-by: Zhang Shengju > Signed-off-by: Tang Bin Saeed, please pick this up. Thank you.