Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp1050283ybj; Thu, 7 May 2020 13:38:56 -0700 (PDT) X-Google-Smtp-Source: APiQypJVVj+bX5HmtAkK8Nik/D/Z9LW7jzWN4kQYTncsBBhe6y85gVMkB0GaN1toLHcfQ8BKN5G5 X-Received: by 2002:a17:906:138c:: with SMTP id f12mr14223360ejc.35.1588883936543; Thu, 07 May 2020 13:38:56 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1588883936; cv=pass; d=google.com; s=arc-20160816; b=ZLInzyHR4d/JoCwV/kZV3S6wD6bskSi37x545cbmBbaUY946+2t4RP5BKrhh0ZnwdQ QnlFs2lueDZzxzNHvkb8xAfU5p/eUfKuaW80VFJoWVZCOY7pt6xnbb0GY6s/yqBqSah8 j5zI+Ar2oYjEBEK1jQX1k0W1KGy9xwKErD8BD/xN8ROK62gUgxMx3kjEHZT4Zd47jv5N Vixx6cqtT9aBJsUJzIf5HOkX+bkr7deDICvqNustrGOBzBPGZOiF7Hj/Xi4/Rix1wAYP H4sL+x1SiOyLdkAyt5n/sRn+syActbgcH8ZMuzMk30f8DcfrZ5x2K4OQBJI+USBBKEku 4qrA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :dlp-version:dlp-reaction:dlp-product:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:to:from:dkim-signature:ironport-sdr :ironport-sdr; bh=Q6con+BcDNwNjzg/askOZCSN7LAOJJ1IcWoPFw+IduU=; b=s/w4uVDP8xUu516DidrC7E0Sng0/IGvGMWF/p3kglc7KutITf5O7lSUpvxqFp4uDav bVFMDCDauydChEcAB3M3bUzm4RjNdqSMOAhj8fTnr5FFQtfF70pb2SXUuiBAan+SvbjR ZuXaaPrpnqYT9W5NUMpM5v0TKd/TyvAI0RVRI1DiQx8Onr0vHeHRYqPhRUbCkQcwUPKY C15PjrDVECdh/BQrKSrAiPMu5skuIp72r8o855TV8o1/8wy4WQZY1PsKrm8FbY4xfSoO nPzolJcSfC7z8TclXHltaSIWjRkOyazSybcaLfC3gGqLrmNrmtMXEtv5mkbVabKspqC4 myIg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=X71LDGF2; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s26si3688816edq.433.2020.05.07.13.38.32; Thu, 07 May 2020 13:38:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=X71LDGF2; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726807AbgEGUhG (ORCPT + 99 others); Thu, 7 May 2020 16:37:06 -0400 Received: from mga07.intel.com ([134.134.136.100]:52779 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726268AbgEGUhF (ORCPT ); Thu, 7 May 2020 16:37:05 -0400 IronPort-SDR: JtVDAZYvpo5pTdDaMABivG2m5zfB4V9bXpLuKuOS5XlXMo8B14lbRnETWcR71xXK/6+F4GTip2 NObL/DMdkmFQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2020 13:37:05 -0700 IronPort-SDR: tsfILzCklbVEDZonvV3Vguv/f86AgUf6+1Qg8+UzEN9uJrbDuxIqvjXk3wKAnJpmWQLiQlLRd9 dGEeE/IU9Ykw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,365,1583222400"; d="scan'208";a="407769504" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by orsmga004.jf.intel.com with ESMTP; 07 May 2020 13:37:05 -0700 Received: from orsmsx156.amr.corp.intel.com (10.22.240.22) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 7 May 2020 13:37:04 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX156.amr.corp.intel.com (10.22.240.22) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 7 May 2020 13:37:04 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.175) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 7 May 2020 13:37:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DSXshcvLJD573HkqDAVME3P90/+UKONpYWUUYbzTrb/kNTsHJGYibZouqUXFRAhEoGV0/zQopvh544yxVZZAed6tQQ1mSUpTZWfEMnaG9cS5M4WM9FyB/YIqzwaW+5yS9BlQZE9cs/hpAxinaU3R/NJdCyoLNvss9EuSgVNtUH/3eFVW2mzjDl+pnRpO3MIaSlBxMDO4Q7xNjzDwhwHc7sf+GCnJPQbo0bIiciycHzwr8+B6Grx5GaxyDQ/CyjrEp2DUhO+b+mS8IsaumxR2gJNnNb7HfqKBthqKIarhCqlwVbUdrKs4eOFcxr57ATAIK+ayxim6euaQxDRjznt+7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q6con+BcDNwNjzg/askOZCSN7LAOJJ1IcWoPFw+IduU=; b=FnF8z6FE7dnslIqgAowhezTlIX0NGZY+PSAZLZqN7cgEU1hpTBfieETRF6ZcFcREKUZ2d44pK8334/ngUrI7ltjimGewvvMMAtw8kA0/V9belmsG19O1iV6W8B90frC910dayY9w6MtIGTAZH4YIBobjcqVxKN7c6o60qFZAMNl2sezEikz5Y5Jv7gI3e+btjkYYJ/YxHzDEgl7V0mlPLWNyM4LmlJat0uvvr2rMWHT3JPLBGPrXobQBf+Z70oD7PPPUp7HM0A4ONeUPXkdzQcPVuH84aEf4BQNm5OLrA2+H4dLsj4D2xJuR5dSyq7iPJKhnf0wy2RoZTqgfzGRmgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q6con+BcDNwNjzg/askOZCSN7LAOJJ1IcWoPFw+IduU=; b=X71LDGF2hWHkMJWjc+jKyh8Qj/JXQZu/eNcAMYaDnrerzH/Wi3K+htrw22WgdoiM6NDDwB6NLYC/p8dbKL2ug0r5u/xnqJwfl6INrh3cHUFM3oAKPgFtkIwK+0HzQqxGbWv7kWXpcmG4EzZDtvL9RVSIAo/8u/bHKJ82k3re2zU= Received: from DM5PR11MB1659.namprd11.prod.outlook.com (2603:10b6:4:6::20) by DM5PR11MB1594.namprd11.prod.outlook.com (2603:10b6:4:5::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.30; Thu, 7 May 2020 20:37:03 +0000 Received: from DM5PR11MB1659.namprd11.prod.outlook.com ([fe80::34e5:3ad6:73cd:4783]) by DM5PR11MB1659.namprd11.prod.outlook.com ([fe80::34e5:3ad6:73cd:4783%12]) with mapi id 15.20.2979.028; Thu, 7 May 2020 20:37:02 +0000 From: "Bowers, AndrewX" To: "netdev@vger.kernel.org" , "intel-wired-lan@lists.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: RE: [Intel-wired-lan] [PATCH net-next] ixgbe: fix signed-integer-overflow warning Thread-Topic: [Intel-wired-lan] [PATCH net-next] ixgbe: fix signed-integer-overflow warning Thread-Index: AQHWIob5Szp0EI9s4kGOWba/IHdMOKidGTaA Date: Thu, 7 May 2020 20:37:02 +0000 Message-ID: References: <20200505024521.24635-1-xiexiuqi@huawei.com> In-Reply-To: <20200505024521.24635-1-xiexiuqi@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.207] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 897b7073-c892-46e9-5771-08d7f2c66611 x-ms-traffictypediagnostic: DM5PR11MB1594: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3044; x-forefront-prvs: 03965EFC76 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: b83cvhFVzcxsS9HEpNWMl33Ntgv402kfMMIvSZDxXrFIvAcdAeDWdK0I3qYnKpD4I3TyFhrBd9EzRmLy1m2Mlg1QKKw09tI6dqIABlFTTwWunPnG0+NJ0QnO9lS8DLJybotH+pOUjv4vQ99Gx0h/VIu/WKNkTnUAh842UC11FYzvgPZMJb/qm9rwnUY5H/s6yvp8IS5EDS1IDIP0gdE7sSxafKLvFFYpo3KXwIAw6Gv+ctgbFXfu4bAj0+TLePOiBNqxywPcls3WInDlOdLWoInyrfHM7R3IeiEZn2Tg6SaTz0bZJqRUrTrGb6tk0mQoomW9603H9ViLW9MW+s23HrTibIqyC+ddCKHaUQWUyPqK33UeLjwQG1OjMKD+9n/UqAnlVmLnn3/L3AUGyn0hyjTVQU+89qIO3YMsQNkHK8WpuCb0N6ci7FXGyHxiwg2tOiG+EWgqkjoZwMVUnObihO1zsobTBgrW2lCmw5Qm1Pvuft1cQr15Gvjrq6g4XWGnv4BdbnQNGKa5rrcEzkjfaA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR11MB1659.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(136003)(39860400002)(366004)(396003)(376002)(346002)(33430700001)(86362001)(6506007)(26005)(53546011)(7696005)(186003)(83300400001)(2906002)(33656002)(83320400001)(83280400001)(83310400001)(83290400001)(52536014)(76116006)(66556008)(66446008)(64756008)(71200400001)(66476007)(478600001)(5660300002)(110136005)(33440700001)(55016002)(9686003)(316002)(66946007)(8676002)(8936002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: 73OEoiUFnJ4osLFHjKwui1KbGbsm8RALShjy0AgC1cVDWKK7MkcZWQDO9qF2mJaTQ52AlOnLRbEWGDG+9BNA4wI0qudMCicptF5hUz7qBjKRcUSQbqXWbthZuU/ZYjlVPK2s7HN5Qnu4ukTdlerSjj9AsOXuhZ3vx8NTsdPpYFkzkn9U6HGEIrbsuODNWDBoLF1ULEsfpoQHahpqhqyDycm6kgbqzvH3Ux81xnjjwDsunhtq+gQhktnrDYOoO29DG+2fkcRAOmfKNBZmHiZZJ6Pc3btHzgEck/pLwu8xg0Aib6N2vstMitL8jIWfoY8sPoXYtwlG3Cb/+4xkzcjd4FPwc0wCzsTi03UbRqiHrb6tQgs01zPR4scWThmg0wjDJJ7LR84e3Gh9TpPGo/r5Lj6VxQP6WlXjf5K94vE2IdH+/+076yonz+gEkJ7A8kQ75/b64FOpoC+tM4ADRlVbGXbC6Kqwjcq3wcRmU9ipv98wUBErTq68wkYFWMJPEI892uJX3Sze4/5ax2TVrc4v1TKxXwQv8KPufeSpPJh9Hh18jZEiB1JLtMMNaui7u0FJXw08ooxuwwcYknLh/S4cZ0+PJew1hyY5/3G6CE5RTLiBty6syZhlcCtPkhmnVxGjkxvnZ2vxS0qc+cqkhSE2FqRJaSEpiJoJ89oh3es/SLMWhtaiftwgd8Fq2f31H6tc6pT2sA+Tuj72WH50rVNbu0XmdVU/iw6sAtyGUTATFZyTj8oNJ024e64SiTAEAn3H3WzvrXXElqnKtdKFKKbwGik9toKBzJ5REr2tIVMCbmg= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 897b7073-c892-46e9-5771-08d7f2c66611 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 May 2020 20:37:02.3964 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uqH6pT9jbN6cRwgL4JBv8k7vJJby+1tV8RNt2PXrFT7cL7gNuYjGCSf9KyUPORnmynKr/KE+Xfio3DKZYBsj5+2P9nE5U0hU+Jg8uCa8Lxk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1594 X-OriginatorOrg: intel.com Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org -----Original Message----- From: Intel-wired-lan On Behalf Of Xie= XiuQi Sent: Monday, May 4, 2020 7:45 PM To: Kirsher, Jeffrey T ; davem@davemloft.net Cc: netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; linux-kernel@= vger.kernel.org Subject: [Intel-wired-lan] [PATCH net-next] ixgbe: fix signed-integer-overf= low warning ubsan report this warning, fix it by adding a unsigned suffix. UBSAN: signed-integer-overflow in drivers/net/ethernet/intel/ixgbe/ixgbe_common.c:2246:26 65535 * 65537 cannot be represented in type 'int' CPU: 21 PID: 7 Comm: kworker/u256:0 Not tainted 5.7.0-rc3-debug+ #39 Hardwa= re name: Huawei TaiShan 2280 V2/BC82AMDC, BIOS 2280-V2 03/27/2020 Workqueue: ixgbe ixgbe_service_task [ixgbe] Call trace: dump_backtrace+0x0/0x3f0 show_stack+0x28/0x38 dump_stack+0x154/0x1e4 ubsan_epilogue+0x18/0x60 handle_overflow+0xf8/0x148 __ubsan_handle_mul_overflow+0x34/0x48 ixgbe_fc_enable_generic+0x4d0/0x590 [ixgbe] ixgbe_service_task+0xc20/0x1f78 [ixgbe] process_one_work+0x8f0/0xf18 worker_thread+0x430/0x6d0 kthread+0x218/0x238 ret_from_fork+0x10/0x18 Reported-by: Hulk Robot Signed-off-by: Xie XiuQi --- drivers/net/ethernet/intel/ixgbe/ixgbe_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Tested-by: Andrew Bowers