Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp1138264ybj; Thu, 7 May 2020 16:00:36 -0700 (PDT) X-Google-Smtp-Source: APiQypL43gCppM/2xgGERqflccf79rLS001umUalyu7S/vGxLMchQEu1+qGkgxcj1dVxZCq29oVr X-Received: by 2002:a17:907:42fe:: with SMTP id oa22mr13765620ejb.98.1588892435813; Thu, 07 May 2020 16:00:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588892435; cv=none; d=google.com; s=arc-20160816; b=BF4sCAV0gCxMseosX/D3Q8f5T4s+HZkXKZVjde1FQpDAIrXnezmE/jSShkCqloYJe1 n1Tgin9CiPNX5GIRxyJsmNAwPTJOj40Yvwd595lWq02GoTFslFq5Q/+Xp2V2qdr8xy47 jgQnCUpFW0pJe5teOvd8mssOsgkGfr11C9h86SN97ogvCc+qgMvgDPuaHpS8k/CQujHa NNvfePEIaLNcrxpZzXWykHQ7TiVa/NBsZiW/TaWYjLefuDrGApVZB6lRRKDJlRtFd7PN p9jUK0z9GPslJSKnKu9pb0bAmzZinqpYYyATVlQvgrnAS0MHF9aDYeCPPOBPJfzc1l0c jciQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=DFVZVtjOy5Zq82K7JozE2r2KIIrkXMdk+V1nGag44c4=; b=xhMJ6ommN+m9tWx5Ix+AFpvoLuUPxqHvc9TeFip/bVu3RwpJJ0bLC1OBh4jlQCl2g3 FNAyeRMQaSsKIkdC58jTj1j6zuuUYz9dpkpZLfnyZPYo6+hencuM+wJszfux+v97KOyS TL2QqP85aKbSOpWJNCXYg0MuRMiLkfwlVSFGa59a5klygmEVtYxKucWdI5p14zUMebUP nmzbc3s0Ik3+9V/yUYdxFMp811kUDXHVsKogE60/IdCGe4jWL+2Fy7DVtGZ7boQFZP+W rthmHwJbgLo8Zd25D736COiX+nT16OxXtCXAaHPWea2OsxnD805r7rMt/seKasuE+9kb F/9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=cfWvMsu2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bs26si3945456ejb.527.2020.05.07.16.00.11; Thu, 07 May 2020 16:00:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=cfWvMsu2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727071AbgEGW4x (ORCPT + 99 others); Thu, 7 May 2020 18:56:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:52782 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726515AbgEGW4w (ORCPT ); Thu, 7 May 2020 18:56:52 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B888A2083B; Thu, 7 May 2020 22:56:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588892212; bh=DFVZVtjOy5Zq82K7JozE2r2KIIrkXMdk+V1nGag44c4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=cfWvMsu2a/TSPk7q/+Zmfy29Q+AC9QWezN1eQf99G/LyIFEochDHBbNGHvRrHDHwd SZglIFhyk6ytKrqx4WYehFbADUTk/TTe7OKAqe6BCfjM+R6c6vfSj6H2Ogxrf/0GT4 qWEFvrGtflMZ2XaXUvIx5uz56muVQ9+ZoWAD9EJ0= Date: Thu, 7 May 2020 15:56:50 -0700 From: Jakub Kicinski To: Bartosz Golaszewski Cc: Bartosz Golaszewski , Rob Herring , "David S . Miller" , Matthias Brugger , John Crispin , Sean Wang , Mark Lee , Arnd Bergmann , Fabien Parent , devicetree , Linux Kernel Mailing List , netdev , Linux ARM , linux-mediatek@lists.infradead.org, Heiner Kallweit Subject: Re: [PATCH 05/11] net: core: provide devm_register_netdev() Message-ID: <20200507155650.0c19229e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: References: <20200505140231.16600-1-brgl@bgdev.pl> <20200505140231.16600-6-brgl@bgdev.pl> <20200505103105.1c8b0ce3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20200506101236.25a13609@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20200507095315.1154a1a6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 7 May 2020 19:03:44 +0200 Bartosz Golaszewski wrote: >> To implement Edwin's suggestion? Makes sense, but I'm no expert, let's >> also CC Heiner since he was asking about it last time. =20 >=20 > Yes, because taking the last bit of priv_flags from net_device seems > to be more controversial but if net maintainers are fine with that I > can simply go with the current approach. =46rom my perspective what Edwin suggests makes sense. Apart from little use for the bit after probe, it also seems cleaner for devres=20 to be able to recognize managed objects based on its own state.