Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp1144671ybj; Thu, 7 May 2020 16:08:33 -0700 (PDT) X-Google-Smtp-Source: APiQypJqrN1Rm7Nq7kyeJr/oVbLRWD5aQTYeWL6brC8Q0Wci/N04Ur37FmIBan3TtOSWYDdnZ0PM X-Received: by 2002:a50:8b06:: with SMTP id l6mr13919824edl.190.1588892913103; Thu, 07 May 2020 16:08:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588892913; cv=none; d=google.com; s=arc-20160816; b=ExxcjLrGd7Pkp51gqLOxPYG9oqjUBu9Qz8Hf5om1jCFCJ4eEidgJtbWCdOsBJEeBl8 A9MignXo6su/vWS5pqtsgMKNR6Pje8wZ6jZ0IHISGj6cMFbzdbrqpOlftNEccRgPc2tt /axAaKciPJnKyHRuMPwO4XNyD+noEjJtu2X5DzgDxRn8u2jxJMT3FGXheo/Lazq4O8j1 T97k656uVuKbr3yi9lyNg0haJsQorbuiHPJL515A6N0V5wpY2f4mGfATf5Tc1fKLl2Mb hymq/9cmBskt0TQtXONxPyoIGplYqDSaqQkSPKCTGZgjudJtQogt2mfirVYM3J5063ke x4WQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=o2rTRdeQQq6SkGxZBFlrZoJ13Bbr37Amr0GE6DXS4fY=; b=U2BFk2a9sfhVo6WAjK7QhTtd3VB2OC4P4IynOEcwZxpST5i5oVRMjx26qxE7Q0Rn1h 7j/I1YRLxNNakmkwZGqFLP+T93qTHqKx4Zpp2amAO4jJWZ6nk/9swe3Yp97uptrttnWy gq3j1I4rGPEB3zkB9CFDVU1a9JQmvSJLxt4Sncv3a+3Nz8SFJ1W/lX5az53qAQrHfLPz dRbWmphnXSqIMtoK0sfeUSHw3bR5VbnBuXD12J9NKH9RA6MdIgiUXIOFp7alIkTS1rKN m/VfpNRWPz7dZqqVCTNgFXxlADJ9z1StM7w+1a4ulMWXY13SyFEKKBt48OxSH/AG4yBp Fqxg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=NSwLOrPu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 27si4108613ejx.245.2020.05.07.16.08.10; Thu, 07 May 2020 16:08:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=NSwLOrPu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726922AbgEGXEj (ORCPT + 99 others); Thu, 7 May 2020 19:04:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:36258 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726531AbgEGXEj (ORCPT ); Thu, 7 May 2020 19:04:39 -0400 Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E092C208D6; Thu, 7 May 2020 23:04:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588892679; bh=sOdZ8xLeykG3/i/JUyklEJJMF0/D0IIXGb47O2HJ2Mg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NSwLOrPuuyCkN9Lb9rVz/kC4ALjEmJWYGRAMAB9dt/uvKnLN9DYPrEwpFrNRCbn5j r9LRq+rK7er4T9EDm4MINIqFA1mQxQ0btLmgBoOvGJRS4xGhFv05Kin09la/Q5qGHB IJOwvyF6k/oZB0Zf7bVEVN3jGL11M4UPJ3VMRSR0= Date: Thu, 7 May 2020 16:04:38 -0700 From: Andrew Morton To: "Guilherme G. Piccoli" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, gavin.guo@canonical.com, kernel@gpiccoli.net, Mel Gorman Subject: Re: [PATCH] mm, compaction: Indicate when compaction is manually triggered by sysctl Message-Id: <20200507160438.ed336a1e00c23c6863d75ae5@linux-foundation.org> In-Reply-To: <20200507215946.22589-1-gpiccoli@canonical.com> References: <20200507215946.22589-1-gpiccoli@canonical.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 7 May 2020 18:59:46 -0300 "Guilherme G. Piccoli" wrote: > Currently we have no way to determine if compaction was triggered > by sysctl write, but this is an interesting information to have, > specially in systems with high uptime that presents lots of > fragmented memory. There's no statistic indicating if compaction > was triggered manually or ran by Linux itself, the vmstat numbers > cannot tell the user this information. Could add it to vmstat? > This patch adds a very simple message to kernel log when compaction > is requested through a write to sysctl file, and also it accumulates > the number of previously manual compaction executions. It follows > the approach used by drop_caches. Userspace could write to /dev/kmsg when it decides to trigger compaction? Although using the kernel log seems a fairly lame way for userspace to record its own actions...