Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp1164099ybj; Thu, 7 May 2020 16:39:03 -0700 (PDT) X-Google-Smtp-Source: APiQypLhBbfVefN50uXtnFagjmVAHI3g4r+EYomsA+UTFqcji5g4zUevYoi6GHcpS6i5loxolQOV X-Received: by 2002:a05:6402:297:: with SMTP id l23mr6483271edv.57.1588894743808; Thu, 07 May 2020 16:39:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588894743; cv=none; d=google.com; s=arc-20160816; b=zmEeB0M370biHSMSSwa2ga/LL3o5vUocoJe/Gf3xhpuqB5Vstxm4CAqwh7QDKkfP4x CWVK2za2HRPmi4YwTntDOD9iZGvRtCVZuNWpHeeurTdbcGEy/WOpuo1k/l2Kbl5Wk46Q UvOyHzpHps3x2fQxGfPiuQK4V3+hMyecMSEBKuh/+ppLb+NuE42lyGZr/Le4UJnuH3Aq xZC4lloHs0UKrmuFCU4sEnFSWM4yVDlZ/lJL2ZXEWxFkibBVeJPoK7pWW8E25W33cEG4 geXeQxRlzJppTZOF0eRychUkasyuN7xkR1ckcUyZx/idFU9uFeP8Pfq7lXjrlTA2R/pc GLcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=IF1gr0Ej8dhAMBdv+LPk159EvF5Y2nzU/01Tj5qgwcY=; b=mlFi7hOPPL3+K0HNpBLLJSyQXGI8nQGCOtAprD+uPblOnUR+VzS0VuR/uqJ3Ed7z/K Dque7nzTHvIOVUT00O+Q7DHRXH53pn4sGgpUBNviyX/OigbkzqCLNxH/f8Np0bDJC74o DxUbSo7CBo/vOXUXj6SyGTGuD8vg0IksFlalozJ6+qCACxQ4QCnDxDqjZGFO+WjKBrks h5ejLOnxJvAFI6DV5kBAPVHQUjbl/+ZHTBSYcYRghhtkByv1jWK2ZiiiENwaK+qSz1E4 fmGYtOA8j7Kiuuh6pY5EcaYRciny0l58HrQCuL0+havcVkeIP53HHhKdowMwC52k55Sy JXqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="c6zNwiO/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z18si4045304edx.121.2020.05.07.16.38.39; Thu, 07 May 2020 16:39:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="c6zNwiO/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726538AbgEGXgw (ORCPT + 99 others); Thu, 7 May 2020 19:36:52 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:25243 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726514AbgEGXgv (ORCPT ); Thu, 7 May 2020 19:36:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588894610; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IF1gr0Ej8dhAMBdv+LPk159EvF5Y2nzU/01Tj5qgwcY=; b=c6zNwiO/lJR7P9dtH6tyWdXJ550UydTrH0JPmEW7F6N3bxtmJ/Fiqf2ak0D9H4zMBoszod 8dU8LPrqdrpMUUXtf3AIudkIYw3tXC98bwMNrK0xQLKJJiza6sJjm4sADyxLocNk4Yndaq Fjb4j29tQBeFu0fNpzIgzIfiIBnGBpY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-110-wTxwCdqhMDe1rHI9QmCmlw-1; Thu, 07 May 2020 19:36:46 -0400 X-MC-Unique: wTxwCdqhMDe1rHI9QmCmlw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 196B21899520; Thu, 7 May 2020 23:36:45 +0000 (UTC) Received: from optiplex-lnx (unknown [10.3.128.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E6101707B0; Thu, 7 May 2020 23:36:37 +0000 (UTC) Date: Thu, 7 May 2020 19:36:34 -0400 From: Rafael Aquini To: Qian Cai Cc: Andrew Morton , LKML , linux-doc@vger.kernel.org, kexec@lists.infradead.org, linux-fsdevel@vger.kernel.org, dyoung@redhat.com, Baoquan He , Jonathan Corbet , Luis Chamberlain , Kees Cook Subject: Re: [PATCH] kernel: add panic_on_taint Message-ID: <20200507233634.GA367616@optiplex-lnx> References: <20200507221503.GL205881@optiplex-lnx> <6B423101-ACF4-49A3-AD53-ACBF87F1ABE0@lca.pw> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6B423101-ACF4-49A3-AD53-ACBF87F1ABE0@lca.pw> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 07, 2020 at 07:07:20PM -0400, Qian Cai wrote: > > > > On May 7, 2020, at 6:15 PM, Rafael Aquini wrote: > > > > It's a reasonable and self-contained feature that we have a valid use for. > > I honestly fail to see it causing that amount of annoyance as you are > > suggesting here. > > It is not a big trouble yet, but keeping an obsolete patch that not very straightforward to figure out that it will be superseded by the panic_on_taint patch will only cause more confusion the longer it has stayed in linux-next. > > The thing is that even if you can’t get this panic_on_taint (the superior solution) patch accepted for some reasons, someone else could still work on it until it get merged. > > Thus, I failed to see any possibility we will go back to the inferior solution (mm-slub-add-panic_on_error-to-the-debug-facilities.patch) by all means. > There are plenty of examples of things being added, changed, and removed in -next. IOW, living in a transient state. I think it's a reasonable compromise to keep it while the other one is beind ironed out. The fact that you prefer one solution to another doesn't invalidate the one you dislike. Cheers, -- Rafael