Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp1219016ybj; Thu, 7 May 2020 18:11:38 -0700 (PDT) X-Google-Smtp-Source: APiQypI0G6lCi7wzNV+dg0L59gj2sNqyrJdSmnsgZq1VphV8ljKY6Qb04YKt3TqM40WDwX8Y5kiZ X-Received: by 2002:a17:906:d299:: with SMTP id ay25mr9977221ejb.348.1588900297909; Thu, 07 May 2020 18:11:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588900297; cv=none; d=google.com; s=arc-20160816; b=sungiurQ11FpSNLxp78yxA574NHB4R/MW2/4cZJZ+xibIgCxInfMw/8UzVCo8G6pux G0tZzOm9uJmp9VygZH6pvLnWFPX+GvcwvGddb1Q5gKJUDo9TZgOYFfT8XtnUygbPP/KM 2g71G1pARkPeEVFA0gZ9S5GffEUpblksu9xUoZSWRcYTINxLKq6BXV+s5Icq4OQaw0CS XtBm+0rq67AWlOgtQhubzVPtm90gTTcTApszSByab1DLhIq97BrKWcdTv0e9xZW47IDz gYIzdO2cIfFuAXspSn6vwRm//4dMOufq/ggEvpVW2nIcnY7U4PnHgYItp2aXr4YWlx2W erGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=K3w1YrriT/Qxz2DMtDFsXD0Yj5/S217lmLg86px5sZ8=; b=ohr6n+O6qB9eO2+xAIFHKYhfXttPKImPvff+lM8j5ps8RLeEbNiRojYR5VE+39rYo1 uxhFGBrlK+wnpd5QAZr4Lkg8Wu7dmCzS7SUPtHdVhfzchLic/lHYDM3cmoUAaMfxlovb OC/+o5p1mVrXSIys6sv79Ca8/pjo9UbpCiP4rMt9iXQQlwQ2KwmG1zYP5ngoBdj39JT7 Xgx4XUuVHwnPonCF2Heqlj8KUKDMIZYO0u2XG2cN6x6IQ9+N85cNEvBCiMrKcF6jbty6 I5sBivXKuQIrPEqzL6Zw6ZY5HbynMZMBi7KlfmUtBZG6sXtZJYeyw7ihAkhlXpzl9Nl8 Cxvg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t4si46348ejr.418.2020.05.07.18.11.11; Thu, 07 May 2020 18:11:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726907AbgEHBJH (ORCPT + 99 others); Thu, 7 May 2020 21:09:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726612AbgEHBJG (ORCPT ); Thu, 7 May 2020 21:09:06 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D322DC05BD43; Thu, 7 May 2020 18:09:06 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 9005E119376D7; Thu, 7 May 2020 18:09:06 -0700 (PDT) Date: Thu, 07 May 2020 18:09:06 -0700 (PDT) Message-Id: <20200507.180906.1564204342326324600.davem@davemloft.net> To: hslester96@gmail.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: microchip: encx24j600: add missed kthread_stop From: David Miller In-Reply-To: <20200507151320.792759-1-hslester96@gmail.com> References: <20200507151320.792759-1-hslester96@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 07 May 2020 18:09:06 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chuhong Yuan Date: Thu, 7 May 2020 23:13:20 +0800 > This driver calls kthread_run() in probe, but forgets to call > kthread_stop() in probe failure and remove. > Add the missed kthread_stop() to fix it. > > Signed-off-by: Chuhong Yuan Applied, thanks.